1090308 - Invalidate mDaysOfHistory when getObservers is invoked

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

currently mDaysOfHistory is invalidated in various code points, among which notifications pass-through (notifyOnItemExpired...)

bug 1089332 wants to expose GetObservers() like we did with bookmarks, so that we can remove nsPIPlacesHistoryListenersNotifier and notify directly. For that we want a solution that allows to invalidate mDaysOfHistory in a more automatic way (we would not be able to do that from js).

Comment 1

[Marco Bonardo [:mak]]

I tried the trigger solution but it's not good.
Since Sqlite supports only FOR EACH ROW triggers, for each addition/removal we'd have to run a function that enqueues a runnable... if one removes 1000 visits, that's not sustainable.

What I'm going to do instead is implementing bug 1089332 and invalidating the cache when getObservers is invoked.
As a bonus, I have a patch that removes our only hasHistoryEntries consumer from the tree, I made that when trying the triggers path, it's worth to keep it.

Comment 2

[Marco Bonardo [:mak]]

Due to bug 1097213, the patch for this bug slipped into bug 1089332, that's ok since they are dependent, though I'm reporting that just for clarity.

Comment 3

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/fx-team/rev/44ebd54f1b9c

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/44ebd54f1b9c