Closed Bug 1090308 Opened 5 years ago Closed 5 years ago
Days Of History when get Observers is invoked
currently mDaysOfHistory is invalidated in various code points, among which notifications pass-through (notifyOnItemExpired...) bug 1089332 wants to expose GetObservers() like we did with bookmarks, so that we can remove nsPIPlacesHistoryListenersNotifier and notify directly. For that we want a solution that allows to invalidate mDaysOfHistory in a more automatic way (we would not be able to do that from js).
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Iteration: --- → 36.3
I tried the trigger solution but it's not good. Since Sqlite supports only FOR EACH ROW triggers, for each addition/removal we'd have to run a function that enqueues a runnable... if one removes 1000 visits, that's not sustainable. What I'm going to do instead is implementing bug 1089332 and invalidating the cache when getObservers is invoked. As a bonus, I have a patch that removes our only hasHistoryEntries consumer from the tree, I made that when trying the triggers path, it's worth to keep it.
Summary: Invalidate mDaysOfHistory through a trigger → Invalidate mDaysOfHistory when getObservers is invoked
Due to bug 1097213, the patch for this bug slipped into bug 1089332, that's ok since they are dependent, though I'm reporting that just for clarity.
Flags: in-testsuite? → in-testsuite+
Target Milestone: --- → mozilla36
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.