Closed
Bug 1089332
Opened 10 years ago
Closed 9 years ago
Add a getObservers API for accessing the history observers list from History.jsm and nsPlacesExpiration
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
People
(Reporter: asaf, Assigned: mak)
References
Details
Attachments
(2 files, 1 obsolete file)
Similar to the bookmarks patch in bug 1081099, we need a way to notify history observers from the new History.jsm module and from nsPlacesExpiration (see bug 937560 comment 15). Once that's in place, nsPIPlacesHistoryListenersNotifier should be removed. This may be done in a follow up.
Flags: firefox-backlog+
Assignee | ||
Comment 1•10 years ago
|
||
yep, sounds like a nice cleanup to do.
Assignee | ||
Updated•10 years ago
|
No longer blocks: asyncHistory
Comment 2•10 years ago
|
||
OK, we've got a "similar to this other patch". If we can get a DXR link in here, this looks like a good mentored but. Mano, feel like mentoring a contributor through this?
Flags: needinfo?(mano)
Reporter | ||
Comment 3•10 years ago
|
||
Of course but we need this fixed in the next few weeks. If it cannot happen by then (and the sooner the better). I'll take it myself, or maybe Marco will. http://dxr.mozilla.org/mozilla-central/source/toolkit/components/places/nsINavBookmarksService.idl#550 <- Port that to nsINavHistoryService.idl http://dxr.mozilla.org/mozilla-central/source/toolkit/components/places/nsNavBookmarks.cpp#2674 <- Port that to nsNavHistory.cpp And there's also the test: http://dxr.mozilla.org/mozilla-central/source/toolkit/components/places/tests/unit/test_bookmark_catobs.js
Flags: needinfo?(mano)
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 4•10 years ago
|
||
taking cause it's needed for bug 1090308.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•10 years ago
|
||
Marco please add this to the current iteration
Points: 3 → 2
Flags: needinfo?(mmucci)
Assignee | ||
Updated•10 years ago
|
Flags: qe-verify? → qe-verify-
Assignee | ||
Updated•10 years ago
|
Summary: private-API for accessing the history observers list from History.jsm and nsPlacesExpiration → Add a getObservers API for accessing the history observers list from History.jsm and nsPlacesExpiration
Assignee | ||
Comment 7•10 years ago
|
||
Attachment #8525334 -
Flags: review?(mano)
Assignee | ||
Comment 8•10 years ago
|
||
/r/783 - Bug 1089332 - Add a getObservers API for accessing the history observers list. r=Mano Pull down this commit: hg pull review -r 5f5fef9378a8dc3ac9efaf297c6208ead39db21d
Assignee | ||
Comment 9•10 years ago
|
||
/r/783 - Bug 1089332 - Add a getObservers API for accessing the history observers list. r=Mano /r/785 - Bug 1090308 - Invalidate mDaysOfHistory when getObservers is invoked. r=Mano Pull down these commits: hg pull review -r 598e4a507f2731d62b60bc13ba00ecc86d4a7608
Reporter | ||
Comment 10•10 years ago
|
||
https://reviewboard.mozilla.org/r/785/#review441
Reporter | ||
Comment 11•10 years ago
|
||
https://reviewboard.mozilla.org/r/783/#review443 ::: toolkit/components/places/tests/unit/test_history_catobs.js (Diff revision 1) > + let notificationsPromised = new Promise((resolve, reject) => { trailing spaces
Reporter | ||
Comment 12•10 years ago
|
||
https://reviewboard.mozilla.org/r/783/#review445 Ship It!
Reporter | ||
Comment 13•10 years ago
|
||
https://reviewboard.mozilla.org/r/783/#review447 Ship It!
Assignee | ||
Comment 14•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/dc582009548d
Flags: in-testsuite? → in-testsuite+
Target Milestone: --- → mozilla36
Comment 15•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dc582009548d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•9 years ago
|
Attachment #8525334 -
Flags: review?(mano) → review+
Assignee | ||
Comment 16•9 years ago
|
||
Attachment #8525334 -
Attachment is obsolete: true
Attachment #8618460 -
Flags: review+
Attachment #8618461 -
Flags: review+
Assignee | ||
Comment 17•9 years ago
|
||
Assignee | ||
Comment 18•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•