1090554 - Bookmarks sidebar can have its entries invisible until moused over (updated summary comment #20)

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Luís Miguel [:quicksaver] (not reading bugmail)]

Attachment: OmniSidebar 1.5a1

STR:

1. Install OmniSidebar dev version xpi attached
2. Open bookmarks sidebar (if it isn't already, Ctrl+B)
3. Undock the sidebar (button next to the sidebar close button)
4. Apply the following style:
> #bookmarksPanel scrollbar {visibility: collapse !important;}
5. Resize the window vertically, so the sidebar also resizes

The items will be invisible until you mouse over them (screenshot in next comment). This doesn't happen if you disable preference gfx.direct2d.use1_1 or if the sidebar is docked.

This is a regression I don't think I can fix within the add-on itself.

Comment 1

[Luís Miguel [:quicksaver] (not reading bugmail)]

Attachment: Sidebar Entries Disappearing

Comment 2

[Luís Miguel [:quicksaver] (not reading bugmail)]

I should mention, if instead of visibility:collapse you set display:none you get the exact same results, but if you set visibility:hidden the bug doesn't happen.

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

Probably related to all the other ones with "not drawn until mouse over" bugs.

Comment 4

[Luís Miguel [:quicksaver] (not reading bugmail)]

BTW, the entries will also be invisible until moused over if there aren't enough to require a scrollbar, without the need of any of the visibility property settings I mentioned.

Milan, what other mouse over bugs, can you link me please? I'd like to follow them.

Comment 5

[Luís Miguel [:quicksaver] (not reading bugmail)]

Thanks, but I highly doubt those are related. They are being experienced in release (33) while this issue has specifically appeared in direct2d 1.1 enabled builds (35 onwards, latest aurora and nightly only), which is why I blocked bug 902952.

Comment 6

[Luís Miguel [:quicksaver] (not reading bugmail)]

[Tracking Requested - why for this release]:regression that appeared since D2D1.1 was enabled by default

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Bas - is this something you can take on for 35? It looks like a blocker to keeping D2D1.1 enabled on 35 given the user impact.

Comment 8

[Bas Schouten (:bas.schouten)]

Is this still happening? We've made fixes to Direct2D 1.1 since this was first reported.

Comment 9

[Luís Miguel [:quicksaver] (not reading bugmail)]

[Tracking Requested - why for this release]:

(In reply to Bas Schouten (:bas.schouten) from comment #8)
> Is this still happening? We've made fixes to Direct2D 1.1 since this was
> first reported.

Yes.

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Since D2D1.1 was disabled for 35 in bug 1095608 this shouldn't be an issue for release. Leaving tracking for 36 and higher.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Milan, if we want to ship with D2D1.1 in 36, I believe this bug should be fixed. Can you help? Thanks

Comment 12

[Milan Sreckovic [:milan] (needinfo for best results)]

I'm not convinced this is D2D1.1/graphics, rather than D2D1.1 exposing an existing problem.  We still have bug 1105386 and bug 1094086 and bug 937306, and those (unfixed) seem to have stalled.

Comment 13

[Bas Schouten (:bas.schouten)]

I suspect this may also have a similar cause to bug 1102896. Which is a layout issue being exposed by D2D 1.1.

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Luis, we disabled D2D 1.1 in 36 beta 9. Could you check if you still have the bug? Thanks

Comment 15

[Luís Miguel [:quicksaver] (not reading bugmail)]

[Tracking Requested - why for this release]:
(In reply to Sylvestre Ledru [:sylvestre] from comment #14)
> Luis, we disabled D2D 1.1 in 36 beta 9. Could you check if you still have
> the bug? Thanks

Confirmed bug not happening in latest beta but still happening in latest Nightly.

Comment 16

[Sylvestre Ledru [:Sylvestre]]

OK. So, disabling D2D 1.1 fixed the issue.
Thanks for testing.

Comment 17

[Lawrence Mandel [:lmandel] (use needinfo)]

Milan - D2D 1.1 is enabled in 37+. Even if this is not a problem with D2D 1.1 specifically, as you said in comment 12, it may expose this bug. Where does this bug fall on the priority list? Can you find an owner?

Comment 18

[Milan Sreckovic [:milan] (needinfo for best results)]

Luis, are you using WM_MOUSEFIRST/WM_MOUSELAST in the add-on?

Comment 19

[Luís Miguel [:quicksaver] (not reading bugmail)]

(In reply to Milan Sreckovic [:milan] from comment #18)
> Luis, are you using WM_MOUSEFIRST/WM_MOUSELAST in the add-on?

Hmm I don't know what those even are, so I'm going to say no.

Comment 20

[Luís Miguel [:quicksaver] (not reading bugmail)]

Updated STR (simplified):

1. New profile in Nightly
2. Install latest version of OmniSidebar: https://addons.mozilla.org/firefox/addon/omnisidebar/
3. Open bookmarks sidebar if it doesn't open automatically (Ctrl+B)
4. Undock the sidebar (undock button next to the sidebar close button in the sidebar header)
5. Move the mouse into and out of the sidebar and the browser margin to make it hide and show repeatedly.

5.1. Each time the sidebar moves, the text from the bookmarks entries will be invisible until you move the mouse over them (screenshot comment #1). Sometimes they will reappear after a second but this part seems a bit random to me.

6. Disable pref extensions.omnisidebar.autoHide (so the undocked sidebar doesn't hide automatically)
7. Vertically resize the window to the point where the bookmarks sidebar needs a scrollbar; might be easier if you expand some bookmarks folders first
7.1. The entries text will always be visible as normal
8. Vertically resize the window again to the point the scrollbar is no longer necessary and disappears
8.1. Bookmarks entries text becomes invisible again until hovered.

If you disable pref gfx.direct2d.use1_1, the bookmarks entries text will always be visible as normal when following the steps above.

e10s and non-e10s windows produce the same results, so it seems irrelevant.

Nifty new little detail: the sidebar's border-radius seems to be causing the whole bug. If you apply the follow code:
> .omnisidebar_resize_box { border-radius: 0 !important; }
or toggle pref extensions.omnisidebar.aboveSquared which also removes that border-radius, the entries text will remain visible as normal. (.omnisidebar_resize_box is the sidebar itself, it is a direct child of #sidebar-box and contains the rest of the sidebar's nodes and stuff, basically a box in a box)

Comment 21

[Luís Miguel [:quicksaver] (not reading bugmail)]

Milan, the detail about the border-radius I mentioned in comment #20 makes me think otherwise of what you said in comment #12 about this not being directly D2D1.1 related. Do you still consider that's the case?

Comment 22

[Milan Sreckovic [:milan] (needinfo for best results)]

That's a good clue in comment 20.

Comment 23

[Bas Schouten (:bas.schouten)]

We should retest with bug 1102896 landed. I suspect it will fix it.

Comment 24

[Luís Miguel [:quicksaver] (not reading bugmail)]

(In reply to Bas Schouten (:bas.schouten) from comment #23)
> We should retest with bug 1102896 landed. I suspect it will fix it.

Just confirmed that the bug doesn't happen in today's nightly. I'll close/RESOLVE this bug as soon as bug 1102896 is uplifted to aurora and beta.

Comment 25

[Lawrence Mandel [:lmandel] (use needinfo)]

Bug 1102896 was uplifted to Beta and Aurora a week ago. I'm marking this bug as resolved. Can you test again in Beta 5, which is set to release on Friday?

Comment 26

[Andrew I.R.]

I'm sorry, I did not find any bugs in the database, which is the most similar to the the sense my bug 1137615.
This is the same problem? My error is reproduced on 36.0.1 and 37.0.b4, in any case, and reproduced previously on 38 and 39 (I have not tested the latest releases).
All(?) x-icon favicon images in separate folders of bookmarks sidebar are invisible umtil I move the mouse over the bookmarks.

Comment 27

[Luís Miguel [:quicksaver] (not reading bugmail)]

(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #25)
> Bug 1102896 was uplifted to Beta and Aurora a week ago. I'm marking this bug
> as resolved. Can you test again in Beta 5, which is set to release on Friday?

From the pushlog, it seems it's actually been fixed since beta 2. Either way, just tested in all latest beta, aurora and nightly builds and verified fixed everywhere.