1090929 - Enable the debugger tests for e10s

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Comment 1

[Eddy Bruel [:ejpbruel]]

Attachment: Enable the blackboxing tests

Comment 2

[Eddy Bruel [:ejpbruel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6192263b9758

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6192263b9758

Comment 4

[Eddy Bruel [:ejpbruel]]

Attachment: Enable the break-on-dom tests

Comment 5

[Eddy Bruel [:ejpbruel]]

Green try push for the blackboxing tests:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ebe1cafbed90

Comment 6

[Eddy Bruel [:ejpbruel]]

Green try push for the break-on-dom tests:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=d51d315e091f

Comment 7

[Eddy Bruel [:ejpbruel]]

I just realized those try pushes are probably invalid because I didn't enable the e10s tests on try (I had a commit that does that, but didn't include it in the diff I used to push to try).

The blackboxing tests already landed, but I'm confident those won't cause any problems. I will redo the try push for the break-on-dom tests. If there are any problems with the blackboxing tests, they should show up in that try push as well.

Comment 8

[Eddy Bruel [:ejpbruel]]

Attachment: Enable the pretty-print tests

Comment 9

[Eddy Bruel [:ejpbruel]]

Attachment: Enable the source-mapping tests

Comment 10

[Eddy Bruel [:ejpbruel]]

Attachment: Enable the variables-view-popup tests

Comment 11

[Eddy Bruel [:ejpbruel]]

Attachment: Enable the variables-view-filter tests

Comment 12

[Eddy Bruel [:ejpbruel]]

Attachment: Enable the variables-view tests

Comment 13

[Eddy Bruel [:ejpbruel]]

Attachment: Enable the tracer tests

Comment 14

[Eddy Bruel [:ejpbruel]]

Green try run for the break-on-dom tests:
https://hg.mozilla.org/try/rev/ca60639afdd6

Comment 15

[Eddy Bruel [:ejpbruel]]

Green try run for the pretty-print tests:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ca60639afdd6

Comment 16

[Eddy Bruel [:ejpbruel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a93bb566e665

Comment 17

[Eddy Bruel [:ejpbruel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0c68932bcf9f

Comment 18

[Eddy Bruel [:ejpbruel]]

Attachment: Enable the conditional-breakpoint tests

Comment 19

[Eddy Bruel [:ejpbruel]]

Attachment: Enable the parser tests

Comment 20

[Eddy Bruel [:ejpbruel]]

Attachment: Enable the watch-expressions tests

Comment 21

[Eddy Bruel [:ejpbruel]]

Attachment: Enable the breakpoints tests

Comment 22

[Eddy Bruel [:ejpbruel]]

Attachment: Enable the search tests

Comment 23

[Eddy Bruel [:ejpbruel]]

Attachment: Enable the stack tests

Comment 24

[Eddy Bruel [:ejpbruel]]

Attachment: Enable the remaining tests

Comment 25

[Eddy Bruel [:ejpbruel]]

Once these patches land, about 90% of the frontend tests for the debugger should work on opt builds with E10S enabled.

On debug builds, the frontend tests are still leaking memory. Because I suspect the underlying cause is the same for each test, I've opened up a separate bug for this (1094749).

Comment 26

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8518090 [details] [diff] [review]
Enable the stack tests

Review of attachment 8518090 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/debugger/test/browser.ini
@@ +412,2 @@
>  [browser_dbg_stack-03.js]
> +skip-if = e10s # TODO

Maybe add a bug number here.

Comment 27

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8518091 [details] [diff] [review]
Enable the remaining tests

Review of attachment 8518091 [details] [diff] [review]:
-----------------------------------------------------------------

gTab is sometimes not cleaned up, r+ if you fix it.

The TODO comments should probably have a bug number or explaination.

::: browser/devtools/debugger/test/browser_dbg_event-listeners-01.js
@@ +23,5 @@
>        "Root actor should identify itself as a browser.");
>  
>      addTab(TAB_URL)
> +      .then((aTab) => {
> +        gTab = aTab;

gTab is not cleaned up anywhere... not sure why this doesn't leak but it should be cleaned up anyhow.

::: browser/devtools/debugger/test/browser_dbg_event-listeners-02.js
@@ +24,5 @@
>        "Root actor should identify itself as a browser.");
>  
>      addTab(TAB_URL)
> +      .then((aTab) => {
> +        gTab = aTab;

Same again

::: browser/devtools/debugger/test/browser_dbg_event-listeners-03.js
@@ +24,5 @@
>        "Root actor should identify itself as a browser.");
>  
>      addTab(TAB_URL)
> +      .then((aTab) => {
> +        gTab = aTab;

Again.

Comment 28

[Eddy Bruel [:ejpbruel]]

Failing try run for the source-mapping tests:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=33232f025e27

Comment 29

[Eddy Bruel [:ejpbruel]]

Based on the try log, the failing seems to be caused by bug 1093535. Strangely, I cannot reproduce the issue on try. I've disabled the failing test for now and did another push to try.

Comment 30

[Eddy Bruel [:ejpbruel]]

Green try run for the source-mapping tests:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=a9478a8cf99d

Comment 31

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a93bb566e665
https://hg.mozilla.org/mozilla-central/rev/0c68932bcf9f

Comment 32

[Eddy Bruel [:ejpbruel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/41c629664359

Comment 33

[Eddy Bruel [:ejpbruel]]

Green try push for the variables-view-popup tests:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=8d2987c65d21

Comment 34

[Eddy Bruel [:ejpbruel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0306fd1f4fee

Comment 35

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/41c629664359

Comment 36

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0306fd1f4fee

Comment 37

[ejpbruel]

Green try run for the variables-view-filter tests:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=fec0804947b7

Comment 38

[Eddy Bruel [:ejpbruel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/223e9af774c6

Comment 39

[Eddy Bruel [:ejpbruel]]

Green try run for the variables-view tests:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=a70cdb007874

Comment 40

[Eddy Bruel [:ejpbruel]]

Green try run for the tracer tests:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=40f7a4922b83

Comment 41

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/223e9af774c6

Comment 42

[Eddy Bruel [:ejpbruel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/320f80475bd3

Comment 43

[Eddy Bruel [:ejpbruel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/97cd2042865d

Comment 44

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/320f80475bd3
https://hg.mozilla.org/mozilla-central/rev/97cd2042865d

Comment 45

[Eddy Bruel [:ejpbruel]]

Green try run for the conditional-breakpoint tests:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=8241651b21d9

Comment 46

[Eddy Bruel [:ejpbruel]]

Green try run for the parser tests:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=0c06f46447a0

Comment 47

[Eddy Bruel [:ejpbruel]]

Attachment: Enable the variables-view-* tests

I just noticed that I was forgot to ask r+ for some of the variables-view tests, sorry about that Mike!

Comment 48

[Eddy Bruel [:ejpbruel]]

Green try run for the variables-view-* tests:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=47062604de60

Comment 49

[Eddy Bruel [:ejpbruel]]

Green try run for the watchpoint tests:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=adac098dcc7a

Comment 50

[Eddy Bruel [:ejpbruel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e30535bc1afc

Comment 51

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e30535bc1afc
https://hg.mozilla.org/mozilla-central/rev/08630240d556

Comment 52

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8521382 [details] [diff] [review]
Enable the variables-view-* tests

Review of attachment 8521382 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/debugger/test/head.js
@@ +970,5 @@
>    waitForMessageFromTab(tab, "test:call");
>  }
>  
> +function evalInTab(tab, string) {
> +  info("Evalling string " + string + " in tab.");

Might want to limit this dump to first n chars on first line of code to be eval'd, or else the logs might get crazy noisy for multi-line code evals.

Comment 53

[Eddy Bruel [:ejpbruel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/574f00fee84d

Comment 54

[Eddy Bruel [:ejpbruel]]

Green try run for the breakpoint tests:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=1ea4523a5267

Comment 55

[Eddy Bruel [:ejpbruel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e00755be6b7a

Comment 56

[Eddy Bruel [:ejpbruel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5d19cea005ca

Comment 57

[Eddy Bruel [:ejpbruel]]

Seeing test failures for the search tests on try (confusingly, in other tests):
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=020de4c6498c

Comment 58

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/574f00fee84d
https://hg.mozilla.org/mozilla-central/rev/e00755be6b7a
https://hg.mozilla.org/mozilla-central/rev/5d19cea005ca

Comment 59

[Eddy Bruel [:ejpbruel]]

Green try run for the search tests:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=f7e4f91ca819

Comment 60

[Eddy Bruel [:ejpbruel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/49a1440d3f33

Comment 61

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/49a1440d3f33

Comment 62

[Eddy Bruel [:ejpbruel]]

Green try run for the stack tests:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=906691576d63

Comment 63

[Eddy Bruel [:ejpbruel]]

Some try failures for the remaining tests:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=e8d23e5ad3ab

Comment 64

[Eddy Bruel [:ejpbruel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb8cff8e9350

Comment 65

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fb8cff8e9350

Comment 66

[Eddy Bruel [:ejpbruel]]

Green try run for the remaining tests after I redisabled two of them:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=6580af59fbda

Comment 67

[Eddy Bruel [:ejpbruel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/26112e1b5c61

Comment 68

[Eddy Bruel [:ejpbruel]]

With that patch, 203 out of 223 debugger tests are now running on Linux opt builds with e10s enabled. The remaining 20 tests are either blocked on bug 1093535 or have miscellaneous other issues. Finally, enabling these tests on Linux debug builds as well is blocked on bug 1073352.

Once the above patch sticks, this bug can be resolved. I'll open new bugs for enabling the remaining debugger tests for e10s and enabling the debugger tests for e10s debug builds.

Comment 69

[Eddy Bruel [:ejpbruel]]

Enable the debugger tests for e10s debug builds:
https://bugzilla.mozilla.org/show_bug.cgi?id=1103839

Comment 70

[Eddy Bruel [:ejpbruel]]

Enable the remaining debugger tests for e10s opt builds:
https://bugzilla.mozilla.org/show_bug.cgi?id=1103841

Comment 71

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/26112e1b5c61