Closed Bug 1091461 Opened 10 years ago Closed 10 years ago

Tapping anywhere under the 'Private Browsing' tip in the History panel will open the Custom menu

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox36 verified, firefox37 verified, firefox38 verified, fennec36+)

VERIFIED FIXED
Firefox 38
Tracking Status
firefox36 --- verified
firefox37 --- verified
firefox38 --- verified
fennec 36+ ---

People

(Reporter: cos_flaviu, Assigned: ally, Mentored)

References

Details

(Keywords: reproducible, Whiteboard: [good first bug])

Attachments

(2 files, 1 obsolete file)

Environment: 
Device: Nexus 4 (Android 4.4.4);
Build: Nightly 36.0a1 (2014-10-29);

Steps to reproduce:
1. Launch fennec with a clean profile;
2. Go to History panel;
3. Tap under the 'Private Browsing' tip.

Expected result:
Nothing happens.

Actual result:
Tapping anywhere under the 'Private Browsing' tip will open the Custom menu.
Attached image TextView-target.png
Chenxia, is this intentional?
Flags: needinfo?(liuche)
Blocks: 1014293
This should actually be handled by the layout patch in bug 1089810 (part 2).
Flags: needinfo?(liuche)
Fixed via bug 1089810
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Actually, after talking to :antlam, I landed bug 1089810 without the layout part - that's been moved to bug 1091826, which will be more focused on the changes. I'll put together a patch for this bug if that doesn't get pushed forward in the next day or few.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
tracking-fennec: --- → ?
Assignee: nobody → liuche
tracking-fennec: ? → 36+
Still reproducible on trunk 11/25
Status: REOPENED → ASSIGNED
Keywords: reproducible
Switching this to good-first-bug in case someone wants to take it, but otherwise I'll fix it early next week.
Assignee: liuche → nobody
Status: ASSIGNED → NEW
Whiteboard: [good-first-bug]
Whiteboard: [good-first-bug] → [good first bug]
Mentor: liuche
Should this still track 36 on Beta?
Assignee: nobody → ally
Attached patch aurora + beta bandaid (obsolete) — Splinter Review
Attachment #8552709 - Flags: review?(liuche)
Comment on attachment 8552709 [details] [diff] [review]
aurora + beta bandaid

Review of attachment 8552709 [details] [diff] [review]:
-----------------------------------------------------------------

Does this look fine with the other empty screens? Reading list, Bookmarks, etc. If so, r+.

If you want, make sure this patch applies to beta and aurora, and make try pushes; if you don't want to, I can do that.

::: mobile/android/base/resources/layout/home_empty_panel.xml
@@ +36,5 @@
>                android:visibility="gone"
>                android:gravity="top|center"
>                android:textAppearance="@style/TextAppearance.EmptyHint"
>                android:textColorLink="#FFA62F"
> +              />

Style: put this on the same line as the last property of the TextView.
Attachment #8552709 - Flags: review?(liuche) → review+
(In reply to Chenxia Liu [:liuche] from comment #9)
> Comment on attachment 8552709 [details] [diff] [review]
> aurora + beta bandaid
> 
> Review of attachment 8552709 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Does this look fine with the other empty screens? Reading list, Bookmarks,
> etc. If so, r+.

Yes, I went through and compared Nightly with the local build. They all look the same.

> 
> If you want, make sure this patch applies to beta and aurora, and make try
> pushes; if you don't want to, I can do that.

Er, how do I do that without downloading both hg trees?

> 
> ::: mobile/android/base/resources/layout/home_empty_panel.xml
> @@ +36,5 @@
> >                android:visibility="gone"
> >                android:gravity="top|center"
> >                android:textAppearance="@style/TextAppearance.EmptyHint"
> >                android:textColorLink="#FFA62F"
> > +              />
> 
> Style: put this on the same line as the last property of the TextView.



https://hg.mozilla.org/integration/fx-team/rev/a108c17840d4
Backed this out for visual regression, the tip should be directly below the empty text.
Attachment #8552709 - Attachment is obsolete: true
Attachment #8554068 - Flags: review?(liuche)
Comment on attachment 8554068 [details] [diff] [review]
m-a & m-b bandaid v2

Review of attachment 8554068 [details] [diff] [review]:
-----------------------------------------------------------------

Actually built it this time, and it looks good. Thanks Ally!
Attachment #8554068 - Flags: review?(liuche) → review+
Comment on attachment 8554068 [details] [diff] [review]
m-a & m-b bandaid v2

Approval Request Comment
[Feature/regressing bug #]: bug 1014293, added contextual hint and click
[User impact if declined]: Clicking the space under the link will trigger the hint
[Describe test coverage new/current, TreeHerder]: local build
[Risks and why]: very small, adding spacer views to a layout
[String/UUID change made/needed]: none
Attachment #8554068 - Flags: approval-mozilla-beta?
Attachment #8554068 - Flags: approval-mozilla-aurora?
Try pushes: comment 18 is Aurora, comment 17 is Beta.
https://hg.mozilla.org/mozilla-central/rev/d79a930a61f1
Status: NEW → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Attachment #8554068 - Flags: approval-mozilla-beta?
Attachment #8554068 - Flags: approval-mozilla-beta+
Attachment #8554068 - Flags: approval-mozilla-aurora?
Attachment #8554068 - Flags: approval-mozilla-aurora+
Verified as fixed in build 38.0a1 (2015-01-28);
Device: Lenovo Yoga Tab 10 (Android 4.4.2).
Verified as fixed in build 37.0a2 (2015-01-29);
Device: Lenovo Yoga Tab 10 (Android 4.4.2).
Depends on: 1127237
Tapping anywhere under the 'Private Browsing' won't open the Custom menu, so:
Verified fixed on:
Device: Nexus 4 (Android 4.4)
Build: Firefox for Android 36 Beta 6
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: