1091461 - Tapping anywhere under the 'Private Browsing' tip in the History panel will open the Custom menu

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Flaviu Cos]

Environment: 
Device: Nexus 4 (Android 4.4.4);
Build: Nightly 36.0a1 (2014-10-29);

Steps to reproduce:
1. Launch fennec with a clean profile;
2. Go to History panel;
3. Tap under the 'Private Browsing' tip.

Expected result:
Nothing happens.

Actual result:
Tapping anywhere under the 'Private Browsing' tip will open the Custom menu.

Comment 1

[Aaron Train [:aaronmt]]

Attachment: TextView-target.png

Chenxia, is this intentional?

Comment 2

[Chenxia Liu [:liuche]]

This should actually be handled by the layout patch in bug 1089810 (part 2).

Comment 3

[Aaron Train [:aaronmt]]

Fixed via bug 1089810

Comment 4

[Chenxia Liu [:liuche]]

Actually, after talking to :antlam, I landed bug 1089810 without the layout part - that's been moved to bug 1091826, which will be more focused on the changes. I'll put together a patch for this bug if that doesn't get pushed forward in the next day or few.

Comment 5

[Aaron Train [:aaronmt]]

Still reproducible on trunk 11/25

Comment 6

[Chenxia Liu [:liuche]]

Switching this to good-first-bug in case someone wants to take it, but otherwise I'll fix it early next week.

Comment 7

[Aaron Train [:aaronmt]]

Should this still track 36 on Beta?

Comment 8

[Allison Naaktgeboren :ally]

Attachment: aurora + beta bandaid

Comment 9

[Chenxia Liu [:liuche]]

Comment on attachment 8552709 [details] [diff] [review]
aurora + beta bandaid

Review of attachment 8552709 [details] [diff] [review]:
-----------------------------------------------------------------

Does this look fine with the other empty screens? Reading list, Bookmarks, etc. If so, r+.

If you want, make sure this patch applies to beta and aurora, and make try pushes; if you don't want to, I can do that.

::: mobile/android/base/resources/layout/home_empty_panel.xml
@@ +36,5 @@
>                android:visibility="gone"
>                android:gravity="top|center"
>                android:textAppearance="@style/TextAppearance.EmptyHint"
>                android:textColorLink="#FFA62F"
> +              />

Style: put this on the same line as the last property of the TextView.

Comment 10

[Allison Naaktgeboren :ally]

(In reply to Chenxia Liu [:liuche] from comment #9)
> Comment on attachment 8552709 [details] [diff] [review]
> aurora + beta bandaid
> 
> Review of attachment 8552709 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Does this look fine with the other empty screens? Reading list, Bookmarks,
> etc. If so, r+.

Yes, I went through and compared Nightly with the local build. They all look the same.

> 
> If you want, make sure this patch applies to beta and aurora, and make try
> pushes; if you don't want to, I can do that.

Er, how do I do that without downloading both hg trees?

> 
> ::: mobile/android/base/resources/layout/home_empty_panel.xml
> @@ +36,5 @@
> >                android:visibility="gone"
> >                android:gravity="top|center"
> >                android:textAppearance="@style/TextAppearance.EmptyHint"
> >                android:textColorLink="#FFA62F"
> > +              />
> 
> Style: put this on the same line as the last property of the TextView.



https://hg.mozilla.org/integration/fx-team/rev/a108c17840d4

Comment 11

[Chenxia Liu [:liuche]]

https://hg.mozilla.org/integration/fx-team/rev/76e19ace65ca

Comment 12

[Chenxia Liu [:liuche]]

Backed this out for visual regression, the tip should be directly below the empty text.

Comment 13

[Allison Naaktgeboren :ally]

Attachment: m-a & m-b bandaid v2

Comment 14

[Chenxia Liu [:liuche]]

Comment on attachment 8554068 [details] [diff] [review]
m-a & m-b bandaid v2

Review of attachment 8554068 [details] [diff] [review]:
-----------------------------------------------------------------

Actually built it this time, and it looks good. Thanks Ally!

Comment 15

[Chenxia Liu [:liuche]]

Comment on attachment 8554068 [details] [diff] [review]
m-a & m-b bandaid v2

Approval Request Comment
[Feature/regressing bug #]: bug 1014293, added contextual hint and click
[User impact if declined]: Clicking the space under the link will trigger the hint
[Describe test coverage new/current, TreeHerder]: local build
[Risks and why]: very small, adding spacer views to a layout
[String/UUID change made/needed]: none

Comment 16

[Allison Naaktgeboren :ally]

https://hg.mozilla.org/integration/fx-team/rev/d79a930a61f1

Comment 17

[Chenxia Liu [:liuche]]

https://tbpl.mozilla.org/?tree=Try&rev=eb8f645dad3d

Comment 18

[Chenxia Liu [:liuche]]

https://tbpl.mozilla.org/?tree=Try&rev=0ed2adc765ef

Comment 19

[Chenxia Liu [:liuche]]

Try pushes: comment 18 is Aurora, comment 17 is Beta.

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d79a930a61f1

Comment 21

[Flaviu Cos]

Verified as fixed in build 38.0a1 (2015-01-28);
Device: Lenovo Yoga Tab 10 (Android 4.4.2).

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6455585f44c6
https://hg.mozilla.org/releases/mozilla-beta/rev/f9d1601a87b1

Comment 23

[Flaviu Cos]

Verified as fixed in build 37.0a2 (2015-01-29);
Device: Lenovo Yoga Tab 10 (Android 4.4.2).

Comment 24

[Teodora Vermesan (:TeoVermesan)]

Tapping anywhere under the 'Private Browsing' won't open the Custom menu, so:
Verified fixed on:
Device: Nexus 4 (Android 4.4)
Build: Firefox for Android 36 Beta 6