Note: There are a few cases of duplicates in user autocompletion which are being worked on.

UITour: Info panel positioning breaks when the target is in the overflow panel when opened

RESOLVED FIXED in Firefox 36

Status

()

Firefox
Tours
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: MattN, Assigned: mikedeboer)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 38
Points:
2
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify ?

Firefox Tracking Flags

(firefox36 fixed, firefox37 fixed, firefox38 fixed)

Details

(Whiteboard: [HelloTour:P2])

Attachments

(3 attachments)

+++ This bug was initially created as a clone of Bug #1085330 +++

When opening an infor panel anchored at an item in the toolbar, info panel positioning breaks when the browser is resized down to a width where the icon moves into the "More tools..." overflow panel.

Bug 1085330 missed the info panel case so this is a follow-up for that.
Flags: firefox-backlog+
Thanks for filing a new bug Matt - do you think there's any chance of getting this one fixed before Nov 10th? I think there's a likely chance that some users may hit it, either in the privacy tour or Dev browser firstrun.

Comment 2

3 years ago
(In reply to Alex Gibson [:agibson] from comment #1)
> Thanks for filing a new bug Matt - do you think there's any chance of
> getting this one fixed before Nov 10th? I think there's a likely chance that
> some users may hit it, either in the privacy tour or Dev browser firstrun.

AIUI, extremely unlikely, considering we've made builds and unless there are breaking crazy mess-ups, won't respin anything. Dolske?
Flags: needinfo?(dolske)
Yeah, sorry we missed this case. :( I'll try to get a patch together today just to have it in-hand if a respin is needed for other reasons, but I think this isn't critical enough to respin by itself. So we'll ship with this bug.

The UITour should adapt by using showHighlight("forget") instead of showInfo("forget"). I.E. just the circular highlight instead of the panel with text/icon. Or, I suppose, use showInfo() and just accept that if the button is in overflow it will be a weird UX.
Flags: needinfo?(dolske)
Created attachment 8515093 [details]
Flow for adding forget button via info panel

For those that have added the Forget Button and it goes into the toolbar overflow, if we do display the info panel when its positioning is not accurate, it will look broken. 

The best case would be highlighting the overflow icon >> and extending the info panel with confirmation messaging from this highlight. 

If we can't do this accurately, I think it's best to not show the info panel when toolbar overflow is shown and highlight the >> icon only. Is it possible to not show an info panel for this condition, but continue to show it for those who do not have toolbar overflow?

(attached image is for referencing the info panel messaging, but does not show overflow state)
We can't tell if a target is within the overflow panel or not via the web page, so unless we can fix this bug we are probably left with one of the two options Justin proposes in Comment 3
(In reply to Justin Dolske [:Dolske] from comment #3)
> Yeah, sorry we missed this case. :( I'll try to get a patch together today
> just to have it in-hand if a respin is needed for other reasons, but I think
> this isn't critical enough to respin by itself. So we'll ship with this bug.

Just checking in before we decide on how to handle this bug in the tour - did we manage to get a patch in for this? (not sure if there has been a respin or not, but thought I may as well ask).
Flags: needinfo?(dolske)

Updated

3 years ago
Blocks: 1095486
(Previously followed up on this.)
Flags: needinfo?(dolske)
Blocks: 1098620
No longer blocks: 1098620
Created attachment 8532102 [details]
loop-panel.jpg

This bug seems to effect the loop panel a bit oddly: 

If a web page calls Mozilla.UITour.showMenu('loop') and the web page is resized, the positioning of the loop panel breaks when it moves into the overflow (see attached).

What's odd though is the positioning remains broken even after I then refresh the page when the target is no longer in the overflow?
In our wireframes for the /whatsnew and /firstrun tours landing in GA 36, we're putting additional attention on the Hello icon by opening a doorhanger. This bug must be resolved for that to happen.
Blocks: 1118874
Component: General → Tours
Depends on: 1109868
Marking this as a P2 (required, but not blocking immediate development) for Hello 36 tours.
Whiteboard: [UITour:P2]
(In reply to Matthew N. [:MattN] from comment #0)

> When opening an infor panel anchored at an item in the toolbar, info panel
> positioning breaks when the browser is resized down to a width where the
> icon moves into the "More tools..." overflow panel.

The focus of this bug should actually be that when an button starts off in overflow (no resizing involved), the infopanel is shown at the wrong spot.

Resizing will also make the panel jump to the wrong position, but I don't think we need to worry as much about someone resizing the window in the middle of the tour. I didn't fix that in bug 1085330.
Making the summary more clear.
Summary: UITour: Info panel positioning breaks when icon target moves into "more tools" overflow panel → UITour: Info panel positioning breaks when the target is in the overflow panel when opened
Whiteboard: [UITour:P2] → [HelloTour:P2]
(Assignee)

Updated

3 years ago
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
(Assignee)

Comment 13

3 years ago
Created attachment 8558454 [details] [diff] [review]
Patch v1: make sure the info panel anchors to the overflow chevron if needed
Attachment #8558454 - Flags: review?(jaws)
(Assignee)

Updated

3 years ago
Iteration: --- → 38.2 - 9 Feb
Points: --- → 2
Attachment #8558454 - Flags: review?(jaws) → review+
(Assignee)

Comment 14

3 years ago
Pushed to fx-team as: https://hg.mozilla.org/integration/fx-team/rev/03b0004eba32
https://hg.mozilla.org/mozilla-central/rev/03b0004eba32
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38

Updated

3 years ago
Flags: qe-verify?
(Assignee)

Comment 16

3 years ago
Comment on attachment 8558454 [details] [diff] [review]
Patch v1: make sure the info panel anchors to the overflow chevron if needed

Approval Request Comment
[Feature/regressing bug #]: Fx36 UITour for Hello
[User impact if declined]: The info popup is shown at the wrong position when the toolbar button is inside the toolbar overflow menu.
[Describe test coverage new/current, TreeHerder]: landed on m-c, tests passing.
[Risks and why]: minor.
[String/UUID change made/needed]: n/a.
Attachment #8558454 - Flags: approval-mozilla-beta?
Attachment #8558454 - Flags: approval-mozilla-aurora?
Attachment #8558454 - Flags: approval-mozilla-beta?
Attachment #8558454 - Flags: approval-mozilla-beta+
Attachment #8558454 - Flags: approval-mozilla-aurora?
Attachment #8558454 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/ee9666a1230b
https://hg.mozilla.org/releases/mozilla-beta/rev/2ad6015cdd1a
status-firefox36: --- → fixed
status-firefox37: --- → fixed
You need to log in before you can comment on or make changes to this bug.