1091954 - autocomplete suggestions stick around after corresponding input is removed

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect)

Description

[Andrew Lorente]

Attachment: removed-element.html

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140923175406

Steps to reproduce:

* have an input on a page
* fill that input out with some value, and submit the form (so there's an autocomplete suggestion available next time)
* refresh the page, or visit it fresh, etc.
* start filling out the input with the same value as before, so the autocomplete suggestion pops up
* cause the input to be removed (when I came across this, I had an event handler for the escape key) (I used jQuery's .remove(), which appears to be equivalent to myParent.removeChild(this)).

I've attached a short HTML file where you can see the problem. It uses an input named "email" so you can probably get autocompletion if you start typing your email address. The element is deleted if you hit escape.


Actual results:

the autocomplete suggestion box continues to exist. Sometimes I've seen it jump to the bottom of the window, but usually it's right where the input used to be


Expected results:

The autocomplete suggestion box should vanish.

Comment 1

[Loic]

The autocomplete tooltip disappears only if the user clicks on the page after removing the input by pressing ESC.
In rare cases, I saw the tooltip moving to the bottom of the browser window too.

Comment 2

[:Gijs (out for now; he/him)]

This was wontfixed for Firefox for Android. Unlike bug 713027 comment #1, I do think it's fixable, using a mutation observer... but I'm not sure that implementing that is worth the effort.

Comment 3

[Sergey Galich [:serg]]

Autocomplete disappears when element is removed, however pressing Down key right after that opens autocomplete again on the element that is not connected to the document.

Comment 4

[Sergey Galich [:serg]]

Attachment: Bug 1091954 - showing autocomplete on connected elements only r=#credential-management-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9c072524f41
showing autocomplete on connected elements only r=credential-management-reviewers,issammani,dimi

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d9c072524f41