dragging the "Personal Toolbar Folder" from the bookmarks folder, onto the Personal Toolbar. should be prevented

RESOLVED WORKSFORME

Status

SeaMonkey
Bookmarks & History
P2
critical
RESOLVED WORKSFORME
16 years ago
13 years ago

People

(Reporter: Phillip Rhodes, Assigned: Pierre Chanial)

Tracking

Trunk
Future
x86
Windows 2000
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Reporter)

Description

16 years ago
From Bugzilla Helper:
BuildID:    2001110803

If you try to drag the link representing the "Personal Toolbar Folder", from 
the bookmarks menu on the personal toolbar, onto the personal toolbar, Mozilla 
hangs for about 30 seconds, then crashes.

Reproducible: Always
Steps to Reproduce:
1.Launch Mozilla
2.expand the "bookmarks" folder that resides on the personal toolbar
3.drag the "personal toolbar" link from the folder, to the personal toolbar
4. drop the link there.


Actual Results:  when you drop the personal toolbar folder link to the toolbar, 
mozilla hangs, then crashes.

Expected Results:  Since it doesn't make sense to drag the personal toolbar 
folder onto itself in the first place, it probably shouldn't be permitted to 
drop it there.  And even it is, the browser shouldn't crash when you do it.

Since the crash that happens is preceded by a long hang, and then a stack 
overflow, and since dragging the personal toolbar onto itself is recursive, I'm 
thinking that this scenario creates a recursive call somewhere, that keeps 
executing until it blows the call stack.
(Reporter)

Comment 1

16 years ago
Created attachment 57189 [details]
A screen shot showing the scenario that causes the crash

Marked up by hand a little, since the mouse pointer isn't captured in the
screen shot.
(Reporter)

Comment 2

16 years ago
Created attachment 57190 [details]
A screen shot of the crash itself.
(Reporter)

Comment 3

16 years ago
Created attachment 57191 [details]
A screen shot from Visual C++, showing the exception that occurred.
(Reporter)

Comment 4

16 years ago
Created attachment 57192 [details]
A screen shot from Visual C++, shows disassembly window where the exception happened..

You can also see that the area of the screen where the bookmarks folder was, is
still showing the drop-down portion of the folder.  Weird.
(Reporter)

Comment 5

16 years ago
Some talkback events from this crash:


TB37771592Q

TB37770933H

TB37770852M

Comment 6

16 years ago
Confirming Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:0.9.5+) Gecko/20011108
TB37778681Z

Comment 7

16 years ago
and the stack trace... I wonder if this is a regression I thought we went
through all of the possible bad recursive D&D's. Should be a simple enough check
to disallow this type of drop.

Incident ID 37771592
Stack Signature nsPresContext::GetShell 30a1c3d2
Bug ID 109237
Trigger Time 2001-11-08 19:23:13
Email Address sprhodes@lycos.com
URL visited n/a
User Comments
Build ID 2001110809
Product ID MozillaTrunk
Platform ID Win32
Trigger Reason Stack overflow
Stack Trace
nsPresContext::GetShell
[d:\builds\seamonkey\mozilla\layout\base\src\nsPresContext.cpp, line 728]
nsCSSFrameConstructor::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp,
line 11179]
StyleSetImpl::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1518]
FrameManager::GetPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 597]
nsCSSFrameConstructor::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp,
line 11182]
StyleSetImpl::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1518]
FrameManager::GetPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 597]
nsCSSFrameConstructor::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp,
line 11182]
StyleSetImpl::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1518]
FrameManager::GetPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 597]
nsCSSFrameConstructor::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp,
line 11182]
StyleSetImpl::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1518]
FrameManager::GetPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 597]
nsCSSFrameConstructor::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp,
line 11182]
StyleSetImpl::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1518]
FrameManager::GetPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 597]
nsCSSFrameConstructor::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp,
line 11182]
StyleSetImpl::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1518]
FrameManager::GetPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 597]
nsCSSFrameConstructor::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp,
line 11182]
StyleSetImpl::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1518]
FrameManager::GetPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 597]
nsCSSFrameConstructor::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp,
line 11182]
StyleSetImpl::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1518]
FrameManager::GetPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 597]
nsCSSFrameConstructor::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp,
line 11182]
StyleSetImpl::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1518]
FrameManager::GetPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 597]
nsCSSFrameConstructor::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp,
line 11182]
StyleSetImpl::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1518]
FrameManager::GetPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 597]
nsCSSFrameConstructor::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp,
line 11182]
StyleSetImpl::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1518]
FrameManager::GetPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 597]
nsCSSFrameConstructor::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp,
line 11182]
StyleSetImpl::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1518]
FrameManager::GetPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 597]
nsCSSFrameConstructor::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp,
line 11182]
StyleSetImpl::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1518]
FrameManager::GetPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 597]
nsCSSFrameConstructor::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp,
line 11182]
StyleSetImpl::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1518]
FrameManager::GetPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 597]
nsCSSFrameConstructor::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp,
line 11182]
StyleSetImpl::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1518]
FrameManager::GetPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 597]
nsCSSFrameConstructor::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp,
line 11182]
StyleSetImpl::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1518]
FrameManager::GetPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 597]
nsCSSFrameConstructor::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp,
line 11182]
StyleSetImpl::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1518]
FrameManager::GetPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 597]
nsCSSFrameConstructor::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp,
line 11182]
StyleSetImpl::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1518]
FrameManager::GetPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 597]
nsCSSFrameConstructor::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp,
line 11182]
StyleSetImpl::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1518]
FrameManager::GetPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 597]
nsCSSFrameConstructor::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp,
line 11182]
StyleSetImpl::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1518]
FrameManager::GetPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 597]
nsCSSFrameConstructor::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp,
line 11182]
StyleSetImpl::FindPrimaryFrameFor
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1518]
FrameManager::GetPrimaryFrameFor
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 597] 
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Comment 8

16 years ago
marking p2 and mozilla0.9.9
Priority: -- → P2
Target Milestone: --- → mozilla0.9.9

Comment 9

16 years ago
--> me

I don't think this is a regression, I don't recall handling this case.
Assignee: pchen → blakeross
Status: ASSIGNED → NEW
Target Milestone: mozilla0.9.9 → mozilla0.9.7

Comment 10

16 years ago
This works for me in win2k.

Comment 11

16 years ago
Is this still reproducible?
Target Milestone: mozilla0.9.7 → mozilla0.9.8

Comment 12

16 years ago
Reproduced on 2001121003 on Win2K.
Dragging Personal Toolbar Folder from sidebar to Personal Toolbar crashes.

Talkback ID: TB327394K

Updated

16 years ago
Keywords: nsbeta1

Comment 13

16 years ago
->1.0
Target Milestone: mozilla0.9.8 → mozilla1.0

Comment 14

16 years ago
nsbeta1- per Nav triage team.  "Don't do that."
Keywords: nsbeta1 → nsbeta1-

Updated

16 years ago
Target Milestone: mozilla1.0 → Future
(Reporter)

Comment 15

16 years ago
Using build 2002031104, on Win2K, this no longer crashes, for me.  Now, it
allows you to drag the "personal toolbar folder" folder, onto the personal
toolbar.  No crash, but I still don't believe this is the proper behavior.  It
doesn't make sense to put the icon representing the "personal toolbar" onto the
personal toolbar.  

Comment 16

16 years ago
removing self from cc list

Comment 17

16 years ago
I can confirm this crash on Linux Mozilla buid ID 2002040814.
(Assignee)

Updated

16 years ago
Blocks: 133604
(Assignee)

Comment 18

16 years ago
*** Bug 156022 has been marked as a duplicate of this bug. ***

Comment 19

16 years ago
Using 2002080704 on win2k, if I go to Manage Bookmarks, select the folder that I
have set as my personal toolbar folder and drag it on the personal toolbar, I
get this same type of behavior: a hang for a few seconds, then a crash with an
unhandled software exception.  This bug (or at least this variation on it) does
still exist.

Comment 20

16 years ago
A variation on this bug is that the Personal Toolbar can be dragged onto itself.

To Reproduce: Click on an empty bit of the personal toolbar and drag to the left
of an existing bookmark/folder. It will insert a link to itself here.
Going to "Manage Bookmarks" and clicking on this new entry crashes the browser.

Using BuildID 2002072604 on Win2K
(Assignee)

Comment 21

16 years ago
bug 160019 will fix that
Assignee: blaker → chanial
Depends on: 160019

Comment 22

15 years ago
*** Bug 167339 has been marked as a duplicate of this bug. ***
(Assignee)

Comment 23

15 years ago
*** Bug 167479 has been marked as a duplicate of this bug. ***
(Assignee)

Updated

15 years ago
Summary: hang, followed by crash, in Mozilla, when attempting to drag the "Personal Toolbar Folder" from the bookmarks folder, onto the Personal Toolbar. → dragging the "Personal Toolbar Folder" from the bookmarks folder, onto the Personal Toolbar. should be prevented

Updated

15 years ago

Comment 24

15 years ago
*** Bug 169080 has been marked as a duplicate of this bug. ***

Comment 25

15 years ago
Is there a workaround or a way to clear this out manually? I have backups of old
profiles, can I just replace a file or two?

Comment 26

15 years ago
*** Bug 165184 has been marked as a duplicate of this bug. ***

Comment 27

15 years ago
*** Bug 174791 has been marked as a duplicate of this bug. ***

Comment 28

15 years ago
*** Bug 183305 has been marked as a duplicate of this bug. ***

Comment 29

15 years ago
*** Bug 183514 has been marked as a duplicate of this bug. ***

Comment 30

15 years ago
*** Bug 186048 has been marked as a duplicate of this bug. ***
This bug is fixed, please close it.
Also, this bug is a clear example of generalizing a bug. The original
description of this bug refers to a problem that is already fixed, so, please
change at least the summary, so people can look at it and stop posting
"duplicates" to this bug.
Question to all:
how many bug are reported in this bug? In the original description, only 1 bug
is described. But, looking at all duplicates of this bug I see that there are
many different bugs, not real duplicates.

What should be do? Keep generalizing this bug or close it(because it is fixed)
and keep working in the so called "duplicates"

Comments are welcome.
To Chris Lyon,
this bug is already fixed, please close it because:
You can't drag anymore the "Personal Toolbar Folder" into the Toolbar.
Please look at the first 2 attachments of this bug.

Thanks
worksforme: you can no longer drag that menu item.

If there are other related bugs, please keep them separate.

If some of the bugs marked dupes of this one are not dupes, then please re-open
them. Thanks.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → WORKSFORME
Comment #20
Lets talk about this in bug #183305, that bug is a crash one
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.