1092811 - Print Preview not working in Thunderbird and SeaMonkey since Bug 1082575

Status: RESOLVED FIXED

(Thunderbird :: Installer, defect)

Description

[Philip Chee]

STR SeaMonkey: 
1. Try print preview for any tab.
2. Actual Results: Print Preview progress box is shown. Does not proceed to display the print preview UI.
STR Thunderbird:
1. Try print preview any message (either in a message window on in the 3pane window)
2. Actual Results: Print Preview progress box is shown. Does not proceed to display the print preview UI.

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Package fix.

Bug 1082575 uses a message manager to talk to a frame script (toolkit/content/browser-content.js) but this isn't instantiated in comm-central applications.

browser-content.js is loaded by MainProcessSingleton.js:
http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/components/processsingleton/MainProcessSingleton.js?rev=c5e310d17e58#41

But MainProcessSingleton.js and friends aren't packaged in SeaMonkey, Thunderbird nor Instantbird.

References: Bug 1067576 - [e10s] Console.jsm doesn't work from child process on Windows

Bug 1067576 - Make console.log work in frame scripts
> +@BINPATH@/components/ProcessSingleton.manifest
> +@BINPATH@/components/MainProcessSingleton.js
> +@BINPATH@/components/ContentProcessSingleton.js

These three files need to be packaged in package-manifest.in .

Comment 2

[Hartmut Figge]

Attachment: print.png

I have tested the patch on SM-Trunk Linux x86_64 in the browser. There are issues with 'Print Preview'. Left/top shows the old behavior, right top the new one.

In the new one the preview is in a tab. The bar with the buttons for preview is still at the top. If you close the tab with the right most button on the tab bar, you get the picture right/bottom. The tab is closed and the preview bar is still at the top.

If you instead use the 'Close' button in the preview bar, the preview window is closed, but the sidebar has disappeared. That may be due to recent patch for the empty bookmarks.

Comment 3

[Philip Chee]

Hartmut: did you try in safe-mode? With addons disabled?

> In the new one the preview is in a tab.
The preview has always been in a separate tab (in Firefox and SeaMonkey Navigator). But normally the rest of the UI is hidden. How about print preview in a mailnews message window?

Comment 4

[Hartmut Figge]

Attachment: p3.png

p3 shows the preview window in the safe mode. For a message in mailnews no preview window appears and the error console says

Timestamp: 08.11.2014 22:29:00
Warning: Unknown property 'image-orientation'.  Declaration dropped.
Source File: chrome://messagebody/skin/messageBody.css
Line: 129, Column: 19
Source Code:
  image-orientation: from-image;

  Timestamp: 08.11.2014 22:29:00
Error: TypeError: printPreviewTB.initialize is not a function
Source File: chrome://global/content/printUtils.js
Line: 481

I have even renamed the chrome dir in my profile. Seems, it is used despite of safe-mode.

Comment 5

[Philip Chee]

> Warning: Unknown property 'image-orientation'.  Declaration dropped.
> Source File: chrome://messagebody/skin/messageBody.css
> Line: 129, Column: 19
> Source Code:
>   image-orientation: from-image;

http://mxr.mozilla.org/comm-central/source/mozilla/modules/libpref/init/all.js?rev=42078caf21b7#2105

Did you set layout.css.image-orientation.enabled to false?

>   Timestamp: 08.11.2014 22:29:00
> Error: TypeError: printPreviewTB.initialize is not a function
> Source File: chrome://global/content/printUtils.js
> Line: 481
Works for me.

Comment 6

[Hartmut Figge]

(In reply to Philip Chee from comment #5)

> Did you set layout.css.image-orientation.enabled to false?

Yes.

> >   Timestamp: 08.11.2014 22:29:00
> > Error: TypeError: printPreviewTB.initialize is not a function
> > Source File: chrome://global/content/printUtils.js
> > Line: 481
> Works for me.

You see a print preview window for a message in mailnews? For SM? Which OS? Nevertheless. time for a new profile. Created a new profile t1, minimal configuration, news account for news.mozilla.org, subscribed to mozilla.test. Still problems so additionally a mail account for localhost. You never know. :)

Started SM new with -mail -P t1. Opened a a message under mozilla.test. Opened error console. Cleared errors. Then File->Print Preview. A short flash of a window with few lines. Disappeared before much could be seen. Error console:

Timestamp: 10.11.2014 23:16:17
Error: DEPRECATION WARNING: getPrintPreview is now deprecated, and fully unsupported for multi-process browsers. Please use a frame script to get access to nsI
WebBrowserPrint from content.
You may find more details about this deprecation at: https://developer.mozilla.org/en-US/docs/Printing_from_a_XUL_App
chrome://global/content/printUtils.js 300 PrintUtils.getPrintPreview
chrome://communicator/content/printPreviewBindings.xml 125 printpreviewtoolbar_XBL_Constructor
chrome://global/content/printUtils.js 480 PrintUtils.enterPrintPreview/onEntered
null 0 null

Source File: resource:///modules/Deprecated.jsm
Line: 79

Timestamp: 10.11.2014 23:16:17
Error: DEPRECATION WARNING: getPrintPreview is now deprecated, and fully unsupported for multi-process browsers. Please use a frame script to get access to nsI
WebBrowserPrint from content.
You may find more details about this deprecation at: https://developer.mozilla.org/en-US/docs/Printing_from_a_XUL_App
chrome://global/content/printUtils.js 300 PrintUtils.getPrintPreview
chrome://communicator/content/printPreviewBindings.xml 332 updateToolbar
chrome://communicator/content/printPreviewBindings.xml 129 printpreviewtoolbar_XBL_Constructor
chrome://global/content/printUtils.js 480 PrintUtils.enterPrintPreview/onEntered
null 0 null

Source File: resource:///modules/Deprecated.jsm
Line: 79

Timestamp: 10.11.2014 23:16:17
Error: TypeError: printPreviewTB.initialize is not a function
Source File: chrome://global/content/printUtils.js
Line: 481

Hm. In this SM there is not only the patch for this bug, Patch v1.0 Package fix, but other patches too. So it seems wise to build a SM with only this one patch. Will be back with the result later.

Comment 7

[Hartmut Figge]

Attachment: build_config.png

New build which contains only the proposed patch for this bug. Another fresh profile. Testing the same way as in my previous comment. Same result.

The picture shows my build config. I have recently changed from gcc-4.7.3 to gcc-4.8.3, but i doubt that this is the reason for the problem. Do you have a recommendation how i should proceed debugging the issue?

Comment 8

[Hartmut Figge]

In my new build of SM-Trunk Linux x86_64 the problem is gone. All is well now. Change window

Last bad:   2014-11-11 18:11:00 PST
First good: 2014-11-12 16:02:00 PST

Comment 9

[Philip Chee]

(In reply to Hartmut Figge from comment #8)
> In my new build of SM-Trunk Linux x86_64 the problem is gone. All is well
> now. Change window
> 
> Last bad:   2014-11-11 18:11:00 PST
> First good: 2014-11-12 16:02:00 PST

That would be:
Bug 1091126 - Use the toolkit printPreviewBindings.xml instead of ours
http://hg.mozilla.org/comm-central/rev/40302dd8b857

Hmm I had that in my mercurial queue but forgot about that until I pushed a whole lot of patches to comm-central. Apologies for the confusion. My fault entirely

Comment 10

[Philip Chee]

> That would be:
> Bug 1091126 - Use the toolkit printPreviewBindings.xml instead of ours
> http://hg.mozilla.org/comm-central/rev/40302dd8b857
> 
> Hmm I had that in my mercurial queue but forgot about that until I pushed a
> whole lot of patches to comm-central. Apologies for the confusion. My fault
> entirely

http://hg.mozilla.org/comm-central/pushloghtml?startdate=2014-11-12&enddate=2014-11-13

Comment 11

[Mike Conley (:mconley) (:⚙️)]

So is this WFM then?

Comment 12

[Philip Chee]

(In reply to Mike Conley (:mconley) - Needinfo me! from comment #11)
> So is this WFM then?
No. Hartmut's problems were somewhere else. This bug/patch is still needed.

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8515627 [details] [diff] [review]
Patch v1.0 Package fix.

Review of attachment 8515627 [details] [diff] [review]:
-----------------------------------------------------------------

r=me for the mail/ bits. I'll get clokep for the im bits.

Comment 14

[Patrick Cloke [:clokep]]

Comment on attachment 8515627 [details] [diff] [review]
Patch v1.0 Package fix.

Review of attachment 8515627 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 15

[Philip Chee]

Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/4ad64638f1d9