Closed Bug 1093185 Opened 11 years ago Closed 10 years ago

Pass through additional subscription flags on incoming signups

Categories

(Websites :: Basket, defect)

Product:
Websites
Component:
Basket
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: jdavis, Unassigned)

References

Details

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla/basket/pull/123
42 bytes, text/x-github-pull-request
Details | Review
As part of the new Email News Redesign - Bug 1062523 - we're shifting how we deal with "Subscriptions" & "sub-Interest categories" for our main email programs and need to update our email newsletter signup forms to pass through the additional "Interest" categories at newsletter signup. all caps with underscores = ExactTarget field name with "_FLG" appended all lower caps with dashes = slug name in basket (*** EXCEPT FOR FIREFOX OS launches and Owner, Firefox for Android ***) ------- Main newsletter #1: Firefox & You (MOZILLA_AND_YOU mozilla-and-you) Interest categories to be marked as Y upon "mozilla-and-you" signup: Desktop (FIREFOX_DESKTOP firefox-desktop)* Mozilla (MOZILLA_GENERAL mozilla-general)* Android (ABOUT_MOBILE mobile) Marketplace Desktop (MARKETPLACE_DESKTOP marketplace-desktop) Marketplace Android (MARKETPLACE_ANDROID marketplace-android)* Firefox OS launches (FIREFOX_OS os)** ------- Main newsletter #2: Firefox OS News (FIREFOX_OS_NEWS firefox-os-news)* Interest categories: Firefox OS Owner (FIREFOX_OS_USER firefox-os)** Marketplace Firefox OS (MARKETPLACE marketplace) Mozilla (MOZILLA_GENERAL mozilla-general)* Whenever someone signs up for "firefox-os", these fields need to be marked as Y: Firefox OS News (FIREFOX_OS_NEWS firefox-os-news)* Marketplace Firefox OS (MARKETPLACE marketplace) Mozilla (MOZILLA_GENERAL mozilla-general)* Whenever someone signs up for "marketplace", these fields need to be marked as Y: Firefox OS News (FIREFOX_OS_NEWS firefox-os-news)* Firefox OS Owner (FIREFOX_OS_USER firefox-os)** Mozilla (MOZILLA_GENERAL mozilla-general)* ------- * Note: Jess/Ben need to add these fields to Master_Subscribers and Double_Opt_In data extensions in ExactTarget prod & sandbox - and - add these fields to basket dev, stage & prod. ** Note: The slugs for these newsletters do not follow the naming convention and cannot be easily updated on the form endpoints, so we should proceed with this caveat. Also need to make sure that current "marketplace" signup form does NOT show for non-OS users (shows for small screen - need user agent sniffing?): Bug 874932 Additional details: https://docs.google.com/a/mozilla.com/presentation/d/1SOZb6Jg7fFWOggwF76UpGKwXWEgdnQhTdO_GYxy_tVc/edit#slide=id.g3ebced12b_07
One exception: when updating subscription flags from Email Preference Center - basket should *NOT* bundle these subscription flags.
More complicating factors: For Firefox OS Owner (FIREFOX_OS_USER firefox-os) - those who signup for the newsletter during the Firefox OS first run experience - there should *NOT* be a double opt-in process triggered. These users should be added directly to the Master_Subscribers data extension with their additional flag information (because you can sign up for all languages in the OS first run experience and we don't want to lose those folks). Currently Marketplace Firefox OS (MARKETPLACE marketplace) is a double opt-in process; however, if signing up for the newsletter behind a persona login, double-opt in will not need to be required. NOTE: Jess to talk to Marketplace team about opt-in form implementation for OS vs. Android vs. Desktop and how they will be grouped together (OS + Firefox OS news, Android/Desktop both going to Firefox & You with *both* flags checked): Bug 874932 - Add a newsletter signup form (Firefox Marketplace - Firefox OS) Bug 1048522 - add newsletter signup to about:apps page (Firefox Marketplace - Desktop)
Blocks: 1093687
Timeline: Testing - Nov 11 Prod - Nov 13 Then DEG can do the backend work in Bug 1093687 by Nov 17th (work on 14th & 17th), for Nov 18th newsletter send.
The above PR just adds the concept of newsletter groups, and allows you to set them up in the admin. All of the linking of groups to newsletters is left to Jess and Ben.
Exciting! Question: can "group-id" = one of the current newsletters in the "list,of,newsletters" ? Ie: group-id = "marketplace" & list of newsletters = "marketplace,firefox-os-news,firefox-os,mozilla-general"
As discussed on IRC, short answer is "yes".
Chatted with pmac on IRC: The "group-id" is replaced with the string of newsletters in "list,of,newsletters" - as long as "marketplace" is listed in the list of newsletters that it needs to be associated with - it will update correctly in ET. Example (hypotetical): Step 1) associate group "mozilla-and-you" with "firefox-os" and "hacks" Step 2) subscribe to "mozilla-and-you" Step 3) you'd get flags for only "firefox-os" and "hacks" if you also want "mozilla-and-you" you'd have to make sure you add that newsletter to the group so Step 1) associate group "mozilla-and-you" with "firefox-os" and "hacks" and "mozilla-and-you" Step 2) subscribe to "mozilla-and-you" Step 3) you'd get flags for "firefox-os" and "hacks" and "mozilla-and-you" Basket just goes through the list of newsletters requested, removes names of groups, and replaces them with the list of their newsletters. Testing will be critical to ensure that double opt-in and welcome email pieces work as they should for the end-user. Need to avoid: multiple welcome emails and confirm emails now that we're grouping. Need to check and uncheck boxes for double-opt-in and info for welcome emails to get the right combination.
Blocks: 1087579
Timeline: Nov 12 (Wed) - Testing on dev Nov 13 (Thurs) - Testing on stage begins Nov 19 (Wed) - Basket testing complete and push to prod with "Group-ids" disabled.* Nov 24 - BNiolet/Jess turn on basket groupings & test DEG can start work after basket push is live & confirmed to be working (Nov 24), to be completed by Dec 4th (1 week) *Pmac to add in disable feature for the group-id setting in basket admin Rbillings - are you around this week and next to help test by chance?
Flags: needinfo?(rbillings)
Commits pushed to master at https://github.com/mozilla/basket https://github.com/mozilla/basket/commit/603926feb60b474b191684584f347e331a085c35 Bug 1093185: Add groups of newsletters for subscription. https://github.com/mozilla/basket/commit/c224ea5ede54da6d245a6edca8e943bd2adb53b0 Merge pull request #123 from pmclanahan/add-newsletter-groups-1093185 Bug 1093185: Add groups of newsletters for subscription.
This is now on Dev. Test at will.
I need more info on what needs testing, what is the priority, and how much time is required for it. That being said I can make some time.
Flags: needinfo?(rbillings)
Testing deets: Need to spot-check on dev, then full test on stage. ** Pmac - there’s a new basket feature piece for scenario 3.3. It may make sense to break that particular feature out into a different bug and proceed with this bug as-is and turn off the double opt-in piece for the Marketplace/OS Newsletter until this is accommodated for. See bottom of comment. ** ------------ Timeline: Nov 18 - Jess spot-check on dev Nov 18 - migrate to stage & begin full testing (Jess, Rebecca & Ben) Nov 19/20 - migrate to prod, but do NOT turn on new flags in basket - spot-check that signups are untouched by prod changes and email preference center is in tact Nov 24 - turn on extra fields passing through and full prod testing ------------ To test: Scenario 1: Main Firefox & You signup form 1) Go go mozilla.org/newsletter 2) Signup in EN, HTML with unique email address 3) Make note of email address 4) Check email inbox for confirm email (make sure it arrived in right lang + email format) 5) Click on confirmation link 6) Make note of TOKEN in mozilla.org/newsletter/confirm/TOKEN 7) Receive Firefox & You welcome email (generic - not Marketplace nor Firefox OS specific) 8) Go to mozilla.org/newsletter/existing/TOKEN 9) Make sure all these are checked as Y/subscribe: Firefox & You (MOZILLA_AND_YOU) - and all interest areas: - Desktop (FIREFOX_DESKTOP) - Mozilla (general) (MOZILLA_GENERAL) - Android (ABOUT_MOBILE) - Marketplace Desktop (MARKETPLACE_DESKTOP) - Marketplace Android (MARKETPLACE_ANDROID) - Firefox OS launches (FIREFOX_OS) 10) Look up subscriber in Double_Opt_In data extension to make sure all flags and date fields are set correctly. (Subscriber will not be in Master_Subscribers until the nightly join query runs.) 11) Look up subscriber in Master_Subscribers data extension to make sure the new subscriber is NOT in Master_Subscribers yet (i.e. the double opt-in setting worked in basket). * Bonus Step 12) Wait till the next day (after the nightly join query runs) - or manually run Double_Opt_In_Join query - THEN, check Master_Subscribers for subscriber and make sure all flags are set appropriately. ------------ Scenario 2: Firefox & You signup form on mozilla.org/firefox/os Repeat steps above and make sure that generic Firefox & You welcome is triggered, NOT a special Firefox OS - Firefox & You version (internal trigger name: “OS_welcome”). ------------ Scenario 3: Blocked by Bug 1097152 Will have to test for Marketplace signup form, for correct platform + newsletter subscription and interest flags when it is launched in Bug 1097152. Pmac, is there a way we (me, Ben, Rebecca) could test this (easily) using an API? Or do we need to wait until this form is on a dev server? Scenario 3.1 - Sign up on Marketplace form via desktop or Android 1) Go go <link of Marketplace signup form> 2) Signup in EN, HTML with unique email address 3) Make note of email address 4) Check email inbox for confirm email (make sure it arrived in right lang + email format) 5) Click on confirmation link 6) Make note of TOKEN in mozilla.org/newsletter/confirm/TOKEN 7) Receive Firefox & You welcome email (generic - not Marketplace nor Firefox OS specific) 8) Go to mozilla.org/newsletter/existing/TOKEN 9) Make sure all these are checked as Y/subscribe: Firefox & You (MOZILLA_AND_YOU) - and all interest areas: - Desktop (FIREFOX_DESKTOP) - Mozilla (general) (MOZILLA_GENERAL) - Android (ABOUT_MOBILE) - Marketplace Desktop (MARKETPLACE_DESKTOP) - Marketplace Android (MARKETPLACE_ANDROID) - Firefox OS launches (FIREFOX_OS) 10) Look up subscriber in Double_Opt_In data extension to make sure all flags and date fields are set correctly. (Subscriber will not be in Master_Subscribers until the nightly join query runs.) 11) Look up subscriber in Master_Subscribers data extension to make sure the new subscriber is NOT in Master_Subscribers yet (i.e. the double opt-in setting worked in basket). * Bonus Step 12) Wait till the next day (after the nightly join query runs) - or manually run Double_Opt_In_Join query - THEN, check Master_Subscribers for subscriber and make sure all flags are set appropriately. Scenario 3.2 - Sign up on Marketplace form via a Firefox OS device 1) Go go <link of Marketplace signup form> 2) Signup in EN, HTML with unique email address 3) Make note of email address 4) Check email inbox for confirm email (make sure “Firefox OS” branded confirm email arrived in right lang + email format) 5) Click on confirmation link 6) Make note of TOKEN in mozilla.org/newsletter/confirm/TOKEN 7) Receive Firefox OS newsletter branded welcome email 8) Go to mozilla.org/newsletter/existing/TOKEN 9) Make sure all these are checked as Y/subscribe: Firefox OS News (FIREFOX_OS_NEWS) - and all interest areas: Firefox OS (FIREFOX_OS_USER) Firefox OS (MARKETPLACE) Mozilla (general) (MOZILLA_GENERAL) 10) Look up subscriber in Double_Opt_In data extension to make sure all flags and date fields are set correctly. (Subscriber will not be in Master_Subscribers until the nightly join query runs.) 11) Look up subscriber in Master_Subscribers data extension to make sure the new subscriber is NOT in Master_Subscribers yet (i.e. the double opt-in setting worked in basket). * Bonus Step 12) Wait till the next day (after the nightly join query runs) - or manually run Double_Opt_In_Join query - THEN, check Master_Subscribers for subscriber and make sure all flags are set appropriately. ** Scenario 3.3 - Double Opt-in and Firefox OS first run ** The incoming “firefox-os” slug should bypass the double opt-in flag fields, so that we get all incoming signups from the Firefox OS first-run signups *without* triggering the double opt-in process. 1) Using a Firefox OS phone, go through first-run experience 2) Signup for “About:OS news” with unique email address (lang will be lang of Firefox OS, HTML will be sent by default (it passes through a blank format)) 3) Make note of email address 4) Check email inbox for welcome email (make sure “Firefox OS” branded confirm email arrived in right lang + email format = H) 5) In welcome email, click on manage preferences link to go to: mozilla.org/newsletter/confirm/TOKEN 6) Make sure all these are checked as Y/subscribe: Firefox OS News (FIREFOX_OS_NEWS) - and all interest areas: Firefox OS (FIREFOX_OS_USER) Firefox OS (MARKETPLACE) Mozilla (general) (MOZILLA_GENERAL) 7) Look up subscriber in Double_Opt_In data extension to make sure subscriber is NOT there. (This signup form should by-pass the double opt-in process). 8) Look up subscriber in Master_Subscribers data extension to make sure the new subscriber IS in Master_Subscribers. (This signup form should by-pass the double opt-in process.)
Blocks: 1100728
Verified scenarios 1 & 2 on dev using both html & text.
Excellent! Thank you Rbillings! Pmac, can you subscribe rbillings to these 2 lists via the API so we can test on dev scenario 3? for slug: "marketplace" = rbillings+marketplace@moz... for slug: "firefox-os" = rbillings+firefox-os@moz... Once we confirm how these work on dev, we're ready to move to stage. Thanks!
Done.
Thanks pmac! Rbillings has verified that this works for testing Scenario 3.2. Scenario 3.1 will be the same as Scenarios 1 & 2 when it's implemented, so the basket mechanics work - we'll just have to test the form when it's live there (OS device vs. signups on Android/Desktop). One thing that blocks this from going to stage and then live: Bug 1100728 - Bypass double opt-in newsletter requirement for Firefox OS first-run users The problem is that we want the double opt-in piece to work for 'marketplace' group signups from an OS device, but NOT for 'firefox-os' group signups from a Firefox OS device - and they have the same list of newsletters in their group (all currently set to double opt-in). Checking with marketplace team to see if the current signup form is live for marketplace - if it is, we're blocked. If it isn't, we have time to get this bug feature piece out the door now (and we'll turn off the double opt-in requirement for 'marketplace' and 'firefox-os' for the Firefox OS Newsletter groups), and get Bug 1100728 implemented before we turn on the double opt-in pieces for the Firefox OS Newsletter.
Update: we're implementing double opt-in for Firefox OS newsletter as well as Firefox & You to make sure that we stay legally compliant around the world (and provide an awesome Mozilla user-centric experience). Updated Scenario 3.3 to test - Sign up on Firefox OS first run device 1) Using a Firefox OS phone, go through first-run experience 2) Signup for “About:OS news” with unique email address (lang will be lang of Firefox OS, HTML will be sent by default (it passes through a blank format)) 3) Make note of email address 4) Check email inbox for confirm email (make sure “Firefox OS” branded confirm email arrived in right lang + email format) ** NOTE: this will only work for languages: EN, ES, PT, DE, FR, ID, RU, HU and PL 5) Click on confirmation link 6) Make note of TOKEN in mozilla.org/newsletter/confirm/TOKEN 7) Receive Firefox OS newsletter branded welcome email **This step will error for now on stage & prod - we have no Firefox OS newsletter welcome setup for ANY languages. This will be fixed soon.** 8) Go to mozilla.org/newsletter/existing/TOKEN 9) Make sure all these are checked as Y/subscribe: Firefox OS News (FIREFOX_OS_NEWS) - and all interest areas: Firefox OS (FIREFOX_OS_USER) Firefox OS (MARKETPLACE) Mozilla (general) (MOZILLA_GENERAL) 10) Look up subscriber in Double_Opt_In data extension to make sure all flags and date fields are set correctly. (Subscriber will not be in Master_Subscribers until the nightly join query runs.) 11) Look up subscriber in Master_Subscribers data extension to make sure the new subscriber is NOT in Master_Subscribers yet (i.e. the double opt-in setting worked in basket). * Bonus Step 12) Wait till the next day (after the nightly join query runs) - or manually run Double_Opt_In_Join query - THEN, check Master_Subscribers for subscriber and make sure all flags are set appropriately. I'm going to look at this fresh first thing tomorrow on dev to make sure we're ready to go to stage. We should be able to push to stage by mid-day. Potentially can do a prod push in the afternoon if all goes well. If not, the plan will be to push to prod Monday am. Sound good?
Blocks: 1097152
Okay - I think we’re ready for stage. Once the basket code is on stage, I’ll have to set up some things in basket stage and ET Prod before testing can begin. Pmac - let us know when this is on stage. Updated timeframe: Nov 20 - stage migration & setup Nov 21 - testing! Nov 24 - final checks and push to prod ------------ Scenario 0: Main Firefox & You signup form with group ID deactivated 1) Go go mozilla.org/newsletter 2) Signup in EN, HTML with unique email address 3) Make note of email address 4) Check email inbox for confirm email (make sure it arrived in right lang + email format) 5) Click on confirmation link 6) Make note of TOKEN in mozilla.org/newsletter/confirm/TOKEN 7) Receive Firefox & You welcome email (generic - not Marketplace nor Firefox OS specific) 8) Go to mozilla.org/newsletter/existing/TOKEN 9) Make sure all ONLY this one field is checked as Y/subscribe: Firefox & You (MOZILLA_AND_YOU) 10) Look up subscriber in Double_Opt_In data extension to make sure all flags and date fields are set correctly. (Subscriber will not be in Master_Subscribers until the nightly join query runs.) 11) Look up subscriber in Master_Subscribers data extension to make sure the new subscriber is NOT in Master_Subscribers yet (i.e. the double opt-in setting worked in basket). * Bonus Step 12) Wait till the next day (after the nightly join query runs) - or manually run Double_Opt_In_Join query - THEN, check Master_Subscribers for subscriber and make sure all flags are set appropriately. ------------ Scenario 1: Main Firefox & You signup form 1) Go go mozilla.org/newsletter 2) Signup in EN, HTML with unique email address 3) Make note of email address 4) Check email inbox for confirm email (make sure it arrived in right lang + email format) 5) Click on confirmation link 6) Make note of TOKEN in mozilla.org/newsletter/confirm/TOKEN 7) Receive Firefox & You welcome email (generic - not Marketplace nor Firefox OS specific) 8) Go to mozilla.org/newsletter/existing/TOKEN 9) Make sure all these are checked as Y/subscribe: Firefox & You (MOZILLA_AND_YOU) - and all interest areas: - Desktop (FIREFOX_DESKTOP) - Mozilla (general) (MOZILLA_GENERAL) - Android (ABOUT_MOBILE) - Marketplace Desktop (MARKETPLACE_DESKTOP) - Marketplace Android (MARKETPLACE_ANDROID) - Firefox OS launches (FIREFOX_OS) 10) Look up subscriber in Double_Opt_In data extension to make sure all flags and date fields are set correctly. (Subscriber will not be in Master_Subscribers until the nightly join query runs.) 11) Look up subscriber in Master_Subscribers data extension to make sure the new subscriber is NOT in Master_Subscribers yet (i.e. the double opt-in setting worked in basket). * Bonus Step 12) Wait till the next day (after the nightly join query runs) - or manually run Double_Opt_In_Join query - THEN, check Master_Subscribers for subscriber and make sure all flags are set appropriately. ------------ Scenario 2: Firefox & You signup form on mozilla.org/firefox/os Repeat steps above and make sure that generic Firefox & You welcome is triggered, NOT a special Firefox OS - Firefox & You version (internal trigger name: “OS_welcome”). ------------ Scenario 3: “marketplace” signup form ID pass through (for Marketplace signup form Bug 1097152 when signing up on a Firefox OS device) 1) Send Pmac a unique email address(es) to subscribe to “marketplace” ID via API (EN & HTML, ES & Text) 2) Once API call has been made, check email inbox for confirm email (make sure “Firefox OS” branded confirm email arrived in right lang + email format) 3) Click on confirmation link 4) Make note of TOKEN in mozilla.org/newsletter/confirm/TOKEN 5) Receive Firefox OS newsletter branded welcome email 6) Go to mozilla.org/newsletter/existing/TOKEN 7) Make sure all these are checked as Y/subscribe: Firefox OS News (FIREFOX_OS_NEWS) - and all interest areas: Firefox OS (FIREFOX_OS_USER) Firefox OS (MARKETPLACE) Mozilla (general) (MOZILLA_GENERAL) 8) Look up subscriber in Double_Opt_In data extension to make sure all flags and date fields are set correctly. (Subscriber will not be in Master_Subscribers until the nightly join query runs.) 9) Look up subscriber in Master_Subscribers data extension to make sure the new subscriber is NOT in Master_Subscribers yet (i.e. the double opt-in setting worked in basket). * Bonus Step 10) Wait till the next day (after the nightly join query runs) - or manually run Double_Opt_In_Join query - THEN, check Master_Subscribers for subscriber and make sure all flags are set appropriately. ------------ Scenario 4 - Sign up on Firefox OS first run device ** will have to ask Pmac to pass through subscriber via API for “firefox-os” until this is on prod** 1) Using a Firefox OS phone, go through first-run experience 2) Signup for “About:OS news” with unique email address (lang will be lang of Firefox OS, HTML will be sent by default (it passes through a blank format)) 3) Make note of email address 4) Check email inbox for confirm email (make sure “Firefox OS” branded confirm email arrived in right lang + email format) ** NOTE: this will only work for languages: EN, ES, PT, DE, FR, ID, RU, HU and PL 5) Click on confirmation link 6) Make note of TOKEN in mozilla.org/newsletter/confirm/TOKEN 7) Receive Firefox OS newsletter branded welcome email **This step will error for now on stage & prod - we have no Firefox OS newsletter welcome setup for ANY languages. This will be fixed soon.** 8) Go to mozilla.org/newsletter/existing/TOKEN 9) Make sure all these are checked as Y/subscribe: Firefox OS News (FIREFOX_OS_NEWS) - and all interest areas: Firefox OS (FIREFOX_OS_USER) Firefox OS (MARKETPLACE) Mozilla (general) (MOZILLA_GENERAL) 10) Look up subscriber in Double_Opt_In data extension to make sure all flags and date fields are set correctly. (Subscriber will not be in Master_Subscribers until the nightly join query runs.) 11) Look up subscriber in Master_Subscribers data extension to make sure the new subscriber is NOT in Master_Subscribers yet (i.e. the double opt-in setting worked in basket). * Bonus Step 12) Wait till the next day (after the nightly join query runs) - or manually run Double_Opt_In_Join query - THEN, check Master_Subscribers for subscriber and make sure all flags are set appropriately.
Flags: needinfo?(pmac)
Depends on: 1102389
Stage push is done. Test at will.
Flags: needinfo?(pmac)
OKAY! Everything is set up on stage and ready for testing. Rbillings - let us know when you've tested Scenario 0 and then we'll turn on the active piece that turns on the extra subscriptions/interests/flags. Thanks!
Flags: needinfo?(rbillings)
2 related Bugs found on stage: 1) No welcome email is sent on stage for "mozilla-and-you" because it's passing through the interest "os" which previously had it's own unique welcome email (even thought it was related to Firefox & You). 2) No welcome email is sent on stage when signing up for the Firefox OS news because it's passing through the interest "marketplace" which previously had it's own unique welcome email. Both of these slugs should now follow the master rules set up in the basket admin - no special cases needed for unique welcome emails anymore as we've consolidated the signup experience + interests.
Flags: needinfo?(rbillings)
Sweet! Thanks pmac! Let us know when this is on stage and ready to resume testing.
Flags: needinfo?(pmac)
Aaand pmac on IRC has said it's ready for testing!
Flags: needinfo?(pmac)
We're good on stage! Proceed to prod! \o/
On prod and testing went well! Thanks Pmac and rbillings! \o/
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified & released to the wild.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: