1093483 - Remove NFC_GECKO_ERROR_NOT_ENABLED error from Nfc.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

If an app calls NFC API (power API excluded, like startPoll, stopPoll or powerOff) when NFC HW is not enabled, this API should throw, right now we treat it as onerror in DOMRequest.

Comment 1

[Dimi Lee [:dimi]]

Attachment: Patch v1

In this patch I treat |enable| as discovery mode because in listen mode NFC API should not be allowed.

Comment 2

[Dimi Lee [:dimi]]

In child process we will check |isLost| attribute to determine if tag/peer API is callable.
So check is enable in Nfc.js is not necessary

Comment 3

[Dimi Lee [:dimi]]

Attachment: Patch v2

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

need to rebase since Bug 1085296 is landed.

Comment 5

[Dimi Lee [:dimi]]

Attachment: Patch v3

rebase to latest code

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Try link? :)

Comment 7

[Dimi Lee [:dimi]]

try link : https://tbpl.mozilla.org/?tree=Try&rev=f6c8af7ddb18

Comment 8

[Dimi Lee [:dimi]]

Attachment: patch v4

rebase to latest code again.

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

https://hg.mozilla.org/integration/b2g-inbound/rev/5bbffe503f7b

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5bbffe503f7b