1095322 - Child process should know current rf state of NFC HW

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Right now only parent process knows the current power level of NFC HW. So if some app calls NFC API(like read/writeNDEF) we need one round-trip IPCs to notify the error situation.

We'd like to make this information also available on child side.

Comment 1

[Dimi Lee [:dimi]]

Attachment: Patch v1

Comment 2

[Dimi Lee [:dimi]]

Discussed with yoshi, next patch will include following:
1.move some definition from nfc_const to idl
2.use DOMEvent instead of listener

Comment 3

[Dimi Lee [:dimi]]

Attachment: Patch v2

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8525194 [details] [diff] [review]
Patch v2

Review of attachment 8525194 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/nfc/nsINfcContentHelper.idl
@@ +69,5 @@
> +   *
> +   * @param rfState
> +   *        RF state received from parent process
> +   */
> +

nit, extra line.

Comment 5

[Dimi Lee [:dimi]]

Attachment: Patch v3

- Fix nits
- rebase

Comment 6

[Dimi Lee [:dimi]]

Attachment: Patch v4

try run : https://tbpl.mozilla.org/?tree=Try&rev=2338b3085c50

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/6d9283ac2ea4

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6d9283ac2ea4