Closed Bug 1095322 Opened 5 years ago Closed 5 years ago

Child process should know current rf state of NFC HW

Categories

(Firefox OS Graveyard :: NFC, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: allstars.chh, Assigned: dimi)

References

Details

(Whiteboard: [p=3])

Attachments

(1 file, 3 obsolete files)

Right now only parent process knows the current power level of NFC HW. So if some app calls NFC API(like read/writeNDEF) we need one round-trip IPCs to notify the error situation.

We'd like to make this information also available on child side.
Assignee: nobody → dlee
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #8520538 - Flags: review?(allstars.chh)
Attachment #8520538 - Flags: review?(allstars.chh)
Discussed with yoshi, next patch will include following:
1.move some definition from nfc_const to idl
2.use DOMEvent instead of listener
Summary: Child process should know current power level of NFC HW → Child process should know current rf state of NFC HW
Attached patch Patch v2 (obsolete) — Splinter Review
Attachment #8525194 - Flags: review?(allstars.chh)
Attachment #8520538 - Attachment is obsolete: true
Comment on attachment 8525194 [details] [diff] [review]
Patch v2

Review of attachment 8525194 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/nfc/nsINfcContentHelper.idl
@@ +69,5 @@
> +   *
> +   * @param rfState
> +   *        RF state received from parent process
> +   */
> +

nit, extra line.
Attachment #8525194 - Flags: review?(allstars.chh) → review+
Attached patch Patch v3 (obsolete) — Splinter Review
- Fix nits
- rebase
Attachment #8525194 - Attachment is obsolete: true
Attachment #8526589 - Flags: review+
Attached patch Patch v4Splinter Review
try run : https://tbpl.mozilla.org/?tree=Try&rev=2338b3085c50
Attachment #8526589 - Attachment is obsolete: true
Attachment #8528178 - Flags: review+
No longer blocks: 1093483
Keywords: checkin-needed
Whiteboard: [p=3]
https://hg.mozilla.org/mozilla-central/rev/6d9283ac2ea4
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.