Closed Bug 1093517 Opened 9 years ago Closed 9 years ago

remove impl for connect and close of MozNFCTag.

Categories

(Firefox OS Graveyard :: NFC, defect)

Product:
Firefox OS Graveyard
Component:
NFC
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox36 wontfix, firefox37 wontfix, firefox38 fixed, b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S4 (23jan)
Tracking Flags:
Tracking Status
firefox36 --- wontfix
firefox37 --- wontfix
firefox38 --- fixed
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

Details

(Whiteboard: [p=1])

Attachments

(2 files)

Patch.
13.50 KB, patch
dimi
: review+
bajaj
: approval-mozilla-b2g37+
Details | Diff | Splinter Review
nfcd Pull Request
59 bytes, text/x-github-pull-request
dimi
: review+
Details | Review 
This is a follow-up bug for Bug 963541,
now we plan to do the connect to different RF interface in nfcd side, so we'd like to remove the remaining implementation of tag.connect and close.
Assignee: nobody → allstars.chh
Attachment #8549422 - Flags: review?(dlee) → review+
Attachment #8549423 - Flags: review?(dlee) → review+
Comment on attachment 8549422 [details] [diff] [review]
Patch.

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
Bug 1109456

User impact if declined: 
Increasing dead code size.
Those code will not be run at all, we kept this because we thought Bug 1109456 will need them, but given that Bug 1109456 is landed and didn't use those API, we should remove them to prevent increasing code size.

Testing completed:
Manually.

Risk to taking this patch (and alternatives if risky): 
No.

String or UUID changes made by this patch:
uuid in nsINfcContentHelper.idl is changed, however this is an internal interface.
Attachment #8549422 - Flags: approval-mozilla-b2g37?
https://hg.mozilla.org/mozilla-central/rev/181a72bbc0d1
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Attachment #8549422 - Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
You need to log in before you can comment on or make changes to this bug.