1093517 - remove impl for connect and close of MozNFCTag.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

This is a follow-up bug for Bug 963541,
now we plan to do the connect to different RF interface in nfcd side, so we'd like to remove the remaining implementation of tag.connect and close.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: nfcd Pull Request

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/181a72bbc0d1

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

nfcd: https://github.com/mozilla-b2g/platform_system_nfcd/commit/0c557e136bb615923aad0f5c69da4e869523efc5

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8549422 [details] [diff] [review]
Patch.

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
Bug 1109456

User impact if declined: 
Increasing dead code size.
Those code will not be run at all, we kept this because we thought Bug 1109456 will need them, but given that Bug 1109456 is landed and didn't use those API, we should remove them to prevent increasing code size.

Testing completed:
Manually.

Risk to taking this patch (and alternatives if risky): 
No.

String or UUID changes made by this patch:
uuid in nsINfcContentHelper.idl is changed, however this is an internal interface.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/181a72bbc0d1

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/platform_system_nfcd/commit/89fa29016f90f8aa111f6ee8dbfe11e6c2db5e80

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/016ef62fa791