Closed
Bug 1131508
Opened 10 years ago
Closed 10 years ago
Remove ConnectResponse and CloseResponse from NfcContentHelper
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(firefox36 wontfix, firefox37 wontfix, firefox38 fixed, b2g-v2.2 fixed, b2g-master fixed)
RESOLVED
FIXED
2.2 S6 (20feb)
People
(Reporter: allstars.chh, Assigned: allstars.chh)
References
Details
(Whiteboard: [p=1])
Attachments
(1 file)
|
963 bytes,
patch
|
dimi
:
review+
bajaj
:
approval-mozilla-b2g37+
|
Details | Diff | Splinter Review |
In Bug 1093517 I removed connect/close however I forgot to remove the IPC messages for them.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8561993 -
Flags: review?(dlee)
|
||
Updated•10 years ago
|
Attachment #8561993 -
Flags: review?(dlee) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
Whiteboard: [p=1]
Target Milestone: --- → 2.2 S6 (20feb)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8561993 [details] [diff] [review]
Patch.
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
Bug 1093517
User impact if declined:
No, but the messages are not used anymore, so I'd like to request to uplift this to help simplify uplifting in the future.
Testing completed:
Manually.
Risk to taking this patch (and alternatives if risky):
No.
String or UUID changes made by this patch:
No
Attachment #8561993 -
Flags: approval-mozilla-b2g37?
|
||
Comment 4•10 years ago
|
||
|
||
Updated•10 years ago
|
Attachment #8561993 -
Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
|
|
||
Comment 5•10 years ago
|
||
status-b2g-v2.2:
--- → fixed
status-b2g-master:
--- → fixed
status-firefox36:
--- → wontfix
status-firefox37:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•