Closed Bug 1131508 Opened 8 years ago Closed 8 years ago

Remove ConnectResponse and CloseResponse from NfcContentHelper

Categories

(Firefox OS Graveyard :: NFC, defect)

Product:
Firefox OS Graveyard
Component:
NFC
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox36 wontfix, firefox37 wontfix, firefox38 fixed, b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S6 (20feb)
Tracking Flags:
Tracking Status
firefox36 --- wontfix
firefox37 --- wontfix
firefox38 --- fixed
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

Details

(Whiteboard: [p=1])

Attachments

(1 file)

Patch.
963 bytes, patch
dimi
: review+
bajaj
: approval-mozilla-b2g37+
Details | Diff | Splinter Review 
In Bug 1093517 I removed connect/close however I forgot to remove the IPC messages for them.
Attachment #8561993 - Flags: review?(dlee) → review+
Comment on attachment 8561993 [details] [diff] [review]
Patch.

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
Bug 1093517

User impact if declined: 
No, but the messages are not used anymore, so I'd like to request to uplift this to help simplify uplifting in the future.

Testing completed:
Manually.

Risk to taking this patch (and alternatives if risky): 
No.

String or UUID changes made by this patch:
No
Attachment #8561993 - Flags: approval-mozilla-b2g37?
https://hg.mozilla.org/mozilla-central/rev/c0c67875d400
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Attachment #8561993 - Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
You need to log in before you can comment on or make changes to this bug.