Closed Bug 1093871 Opened 5 years ago Closed 5 years ago

Telemetry probe for number of items in reading list

Categories

(Firefox for Android Graveyard :: Reading List, defect)

35 Branch
All
Android
defect
Not set

Tracking

(firefox34 fixed, firefox35 fixed, firefox36 fixed)

RESOLVED FIXED
Firefox 36
Tracking Status
firefox34 --- fixed
firefox35 --- fixed
firefox36 --- fixed

People

(Reporter: Margaret, Assigned: Margaret)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Assignee: nobody → margaret.leibovic
I'm uncertain about the histogram values. What do you think? Will people have more than 500 reading list items?
Attachment #8519101 - Flags: review?(rnewman)
Comment on attachment 8519101 [details] [diff] [review]
Telemetry probe for number of items in reading list

Review of attachment 8519101 [details] [diff] [review]:
-----------------------------------------------------------------

Perhaps bump 500 to 1000; this is an exponential histogram, so we can easily accommodate, and it's nice to know what our really top-end users will eventually hit.

Bump the number of buckets according to how much granularity you want at the low end. If we care about 0-1, 1-3, 4-10, then we might want more than ten buckets. Try it and see how you feel.
Attachment #8519101 - Flags: review?(rnewman) → review+
(In reply to Richard Newman [:rnewman] from comment #2)

> Perhaps bump 500 to 1000; this is an exponential histogram, so we can easily
> accommodate, and it's nice to know what our really top-end users will
> eventually hit.

Okay, 1000 sounds good. I would be *really* surprised if a user has over 500 items in their reading list, but users do surprising things sometimes :)

> Bump the number of buckets according to how much granularity you want at the
> low end. If we care about 0-1, 1-3, 4-10, then we might want more than ten
> buckets. Try it and see how you feel.

I don't think we really care about too much granularity. I mostly want to inform our decisions about how to manage the cache, particularly how to fetch content in the background after items are added to the list.
https://hg.mozilla.org/mozilla-central/rev/986d09aa7749
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Comment on attachment 8519101 [details] [diff] [review]
Telemetry probe for number of items in reading list

Approval Request Comment
[Feature/regressing bug #]: none, but we're working on reading list improvements for Fx36, so this will help inform our decisions
[User impact if declined]: we can't tell how much people use the reading list feature
[Describe test coverage new/current, TBPL]: tested locally, landed on m-c
[Risks and why]: low-risk, adds a telemetry probe
[String/UUID change made/needed]: none
Attachment #8519101 - Flags: approval-mozilla-beta?
Attachment #8519101 - Flags: approval-mozilla-aurora?
Comment on attachment 8519101 [details] [diff] [review]
Telemetry probe for number of items in reading list

Low risk addition of new Telemetry probe.

Beta+
Aurora+
Attachment #8519101 - Flags: approval-mozilla-beta?
Attachment #8519101 - Flags: approval-mozilla-beta+
Attachment #8519101 - Flags: approval-mozilla-aurora?
Attachment #8519101 - Flags: approval-mozilla-aurora+
Component: Reader View → Reading List
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.