[Stingray][Settings] implement option menu

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: johnhu, Assigned: johnhu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 attachment)

Option menu is used by landing app.
Created attachment 8523683 [details] [review]
option menu and landing app

dwi2,

I had finished my patch. Please review it.

In this patch, I had done the followings:
1. move the SettingsCache to tv_shared and use it in smart-settings
2. add option menu js and css
3. finish the landing app part
Attachment #8523683 - Flags: review?(tzhuang)
Comment on attachment 8523683 [details] [review]
option menu and landing app

It looks good to me. Thanks
Attachment #8523683 - Flags: review?(tzhuang) → review+
merged to master:
https://github.com/mozilla-b2g/gaia/commit/ca6bd531b17ee87360ac397777059ce935479024

gaia-try is all green but with one intermittent error which gets green once retry:
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=4efed88e4fe3
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.