1095017 - Impossible to change the device name with the new in-content preferences

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Filed with today's Nightly, but has been there for a while.

Steps to reproduce:

* Select Nightly -> Preferences, go to the Sync tab.
* Change the device name
* Close the preferences tab
* Select Nightly -> Preferences, go to the Sync tab.

Expected: Device name has changed

Actual: Device name has not changed

Changing via about:config works. Seems to be primarily a UI issue.

Comment 1

[Richard Newman [:rnewman]]

I seem to recall that Ryan (maybe Mark?) hit this recently.

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Yeah Ryan hit it when I was standing next to him and I promised to file a bug :-)

Comment 3

[Mark Hammond [:markh] [:mhammond]]

(In reply to Richard Newman [:rnewman] from comment #1)
> I seem to recall that Ryan (maybe Mark?) hit this recently.

I hit this for a couple of other fields in bug 1091320.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

I can repro this, but we won't block on it.

Comment 5

[:Gijs (out for now; he/him)]

This is because we pass the wrong param in sync.js .

Comment 6

[:Gijs (out for now; he/him)]

Attachment: pass the element instead of the pane object to gSyncUtils.changeName,

Comment 7

[:Gijs (out for now; he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/cb689f6c881e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cb689f6c881e

Comment 9

[:Gijs (out for now; he/him)]

Comment on attachment 8572619 [details] [diff] [review]
pass the element instead of the pane object to gSyncUtils.changeName,

Approval Request Comment
[Feature/regressing bug #]: bug 1016300
[User impact if declined]: broken preference field in in-content prefs
[Describe test coverage new/current, TreeHerder]: nope :-(
[Risks and why]: very low, very simple change that fixes only the event handler that deals with this preference field
[String/UUID change made/needed]: nope

Comment 10

[:Gijs (out for now; he/him)]

(FWIW, 37 is only affected until the in-content prefs are turned off for LATE_BETA - so the last few betas + release won't be affected - but I would prefer to get as much testing as possible)

Comment 11

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8572619 [details] [diff] [review]
pass the element instead of the pane object to gSyncUtils.changeName,

In-content prefs will be disabled in Beta 4 so there's no need to take this fix on m-b. Beta-

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0fcfefef9a16

Comment 13

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Nightly 39.0a1 (buildID: 20150317030206) and latest Aurora 38.0a2 (buildID: 20150316004007).