1095504 - Marketplace closes itself after using the email activation link from Zimbra

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[Mark Striemer [:mstriemer]]

When you click "Activate now" (not cmd+click, not copy/paste, just click) then you can do the FxA preverified migration flow. Once the use lands on Marketplace the window closes.

This seems like magic. But I think Zimbra is opening the link with `window.open` instead of setting `target="_blank"` on the link. This means `window.opener` [1] is defined and we assume that the window was opened by us. When we're opened in a popup we send the data back to the main window and then close it [2].

We should check that we are the owner of `window.opener` before we follow that code path.

[1] https://github.com/mozilla/fireplace/blob/master/src/media/js/views/fxa_authorize.js#L7
[2] https://github.com/mozilla/fireplace/blob/master/src/media/js/views/fxa_authorize.js#L19

Comment 1

[Mark Striemer [:mstriemer]]

We might not be able to check if we own `window.opener` if it is opened by the app. It might work in the iframe app but the fully packaged app might have issues.

Comment 2

[Andy McKay]

Marking as P2 because it affects Zimbra, but it all still works, just confusing.

Comment 3

[Allen Short [:ashort]]

https://github.com/washort/fireplace/commit/095c0c849a

Comment 5

[krupa raj[:krupa]]

verified fixed. User ends up at https://www.dropbox.com/s/gp0n1qc8xheev1z/Screenshot%202014-11-18%2010.32.11.png?dl=0