1096437 - No 'close multiple tabs' warning for a single non-private window

Status: RESOLVED WORKSFORME

(Firefox :: Session Restore, defect)

Description

[Ben]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141027150301

Steps to reproduce:

Check 'Warn me when closing multiple tabs'.  Open a single normal window.  Open multiple tabs.  Close window (with X or Alt+F4).


Actual results:

Window closes immediately.


Expected results:

'You are about to close [#] tabs. Are you sure you want to continue?' warning should be displayed.

Note that this bug seems distinct from Bug 1096350 as that one extended at least as far back as 27.0.1 and this does not.

It should not be assumed that warnings (that the user has chosen to display) are no longer relevant now that sessions can be restored.  Sessions, especially complex ones, are typically *not* restored exactly as they were, and load time / download size can be significant. Also, the session is vulnerable while being saved (ie to the user logging out, unaware that their 'closed' browser is still busy) and the whole time up until the successful restore (ie to being overwritten).  In addition, the increasing use of touchscreens means more scope for inaccuracy - and the X to close is right above the 'Open menu' button.  So I hope you're not going to trot out the old 'intended behaviour' line!

Comment 1

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Hi Ben,

I have tested your issue on latest Firefox release (43.0.2) and latest Nightly (46.0a1) and I could not reproduce it. When I closed a normal window with multiple tabs the warning appeared : “You are about to close [#] tabs. Are you sure you want to continue?”

Firefox: 46.0a1, Build ID: 20151227030239, User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:46.0) Gecko/20100101 Firefox/46.0  
Firefox: 43.0.2, Build ID: 20151221130713, User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:43.0) Gecko/20100101 Firefox/43.0

Can you please test this on the latest Firefox release (43.0.2) or latest Nightly (46.0a1, https://nightly.mozilla.org/) and tell me if this still reproduces for you ? When doing this please use a new fresh Firefox profile, maybe also in safe mode (https://support.mozilla.org/en-US/kb/troubleshoot-and-diagnose-firefox-problems). Sometimes this kind of issues could appear when using custom settings, themes or some addons. 

Thanks,
Cosmin.

Comment 2

[Ben]

This is still happening in Fx 43.0.4.  I have discovered that it only manifests itself if ‘When Firefox starts’ is set to ‘Show my windows and tabs from last time’ (Options > General).  It *does* happen with a fresh profile.

Comment 3

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Hi Ben,

I have tested again this issue using the new information provided and I managed to reproduce it. If I set the browser like you mentioned in comment #2, when I close Firefox the warning does not appear. But I think this is how the browser was implemented. When I restarted Firefox the opened tabs are restore exactly as they were.

I don't see a point to show a warning when the tabs are restored after. I personally use that setting because I want to quickly close the browser (no other confirmations needed) when I'm in a rush and I want to keep my last tabs for when I return. Even the text that I wrote on a page text box is kept when the session is restored (even after restarting the PC).

However, what we can do on this, is to assign a component to involve the development on this and see what is their opinion. 

Thanks,
Cosmin.

Comment 4

[Graham Perrin]

Is this still an issue? 

> Check 'Warn me when closing multiple tabs'.  Open a single normal window.  Open multiple tabs.  Close window (with X or Alt+F4).

For what it's worth, that does work as expected (I _am_ warned) with Waterfox 56.2.2 in safe mode on FreeBSD-CURRENT (Waterfox 56.0 was based on Firefox 56.0.2).

Comment 5

[Matthias Versen [:Matti]]

It's expected that you do not get a warning if you have session restore active.
see bug 348471 for the report that changed the behavior.