1096603 - [Flatfish] [FxA] [FTE] Register/ Log in screen during setup is blank

Status: VERIFIED FIXED

(Firefox OS Graveyard :: FxA, defect)

Comment 1

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Latest 20141111 version from vendor. Upon set up of device, if you choose to register/ sign in for FxA, you are given a blank white screen. There is now way out. You must manually turn the device off and then skip the step in the Setup in order to complete setup.

Comment 2

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Attachment: 2014-11-10-15-13-31.png

Screenshot of the issue.

Comment 4

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:

This is also happening on Flame v2.2, see bug 1097182 for information.  This fails smoketest and is a functional regression of a core feature.

Requesting a window.

Comment 5

[Marcia Knous [:marcia]]

Please attach a logcat to the bug with Gaia debug traces turned on.

Comment 6

[Oliver Nelson [:oliverthor]]

Attachment: logcat_20141111_fxa.txt

Adding logcat (w/ Gaia Debug Traces) of running into the issue.
1) Open 'Settings' app
2) Open 'Developer' tab
3) Enable Gaia Debug Traces, return to 'Settings'
4) Open 'Firefox Accounts' tab
5) Tap 'Create Account or Sign in'
6) Observe broken UI

Comment 7

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

B2g-inbound Regression Window

Last Working 
Environmental Variables:
Device: Flame 2.2
BuildID: 20141110015706
Gaia: 59063be9cab6997540c927584c2ff3ceaaeff924
Gecko: 0e01c44e8abd
Gonk: Could not pull gonk.  Did you shallow Flash?
Version: 36.0a1 (2.2) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

First Broken 
Environmental Variables:
Device: Flame 2.2
BuildID: 20141110030358
Gaia: 1ae19a508443600933c3991e5f2ec69766bd01f3
Gecko: 5082fb7509bc
Gonk: Could not pull gonk.  Did you shallow Flash?
Version: 36.0a1 (2.2) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Last Working gaia / First Broken gecko - Issue does NOT occur
Gaia: 59063be9cab6997540c927584c2ff3ceaaeff924
Gecko: 5082fb7509bc

First Broken gaia / Last Working gecko - Issue DOES occur
Gaia: 1ae19a508443600933c3991e5f2ec69766bd01f3
Gecko: 0e01c44e8abd

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/59063be9cab6997540c927584c2ff3ceaaeff924...1ae19a508443600933c3991e5f2ec69766bd01f3

Comment 8

[Joshua Mitchell (Inactive)]

Likely broken by Bug 1095714 - can you take a look Kevin?

Comment 9

[Kevin Grandon :kgrandon]

I would say that bug 941969 is the much more likely bug to regress in the pushlog, as I believe that may have broken flatfish before?

Comment 10

[Kevin Grandon :kgrandon]

George - any thoughts here?

Comment 11

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Thanks to ni me. 
When I dump the message, I found System is not defined in fxa aggregated js. I believe the error has existed for quite a while.

Perhaps you can help me to do the review? 
Thanks.

Comment 12

[Kevin Grandon :kgrandon]

Comment on attachment 8521572 [details] [review]
PR to master

I don't have a flatfish to test on right now, but this looks fine to me and makes sense. Thanks!

Comment 13

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/be8b0151d2f9a4c41fc63952128e0b723cd1161d

Comment 14

[Oliver Nelson [:oliverthor]]

Verified fixed in 2.2 KK Master Branch on flame devices
Repro Rate: 2/2
Results: FireFox account can be created and viewed in Settings.

Environmental Variables:
----------------------------------------------
Device: Flame 2.2 (Shallow Flash)
BuildID: 20141113040205
Gaia: be8b0151d2f9a4c41fc63952128e0b723cd1161d
Gecko: ab137ddd3746
Gonk: v188 (Shallow Flash)
Version: 36.0a1 (2.2)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36

Comment 15

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

This doesn't seem to be fixed in Flatfish. Bug 1098159 was opened yesterday about the issue first reported here. 

Currently testing with build from vendor: 
20141115
Software: Boot2Gecko 2.2.0.0-prerelease
Firmware Revision: flatfish_20141115-0115
Build #: 20141115
Platform Version: 36.0a1
Build ID: 20141115012414
Update channel: default
Git Commit Info: 2014-1-14 14:56:02 (ccda8433)

Comment 16

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Reopening per comment 15. Can QA take another look at the latest vendor build on flatfish?

Comment 18

[Joshua Mitchell (Inactive)]

(In reply to Jared Hirsch [:_6a68] [NEEDINFO pls] from comment #16)
> Reopening per comment 15. Can QA take another look at the latest vendor
> build on flatfish?

Kirkland QA does not have a Flatfish - one of the other labs needs to pick up this request.

Comment 20

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Doh!

I bet this is broken again because bug 1080905 renamed system.js to service.js, but this patch landed with the old name at almost the exact same time.

I'll attach a quick fix.

Comment 21

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Github PR 26164

Hey George - Looks like the system.js -> service.js refactor landed with just slightly bad timing for this bug ^_^

kgrandon is out at a conference, do you mind taking a look?

I don't have a flatfish, so I can't confirm this fixes the problem, but it certainly seems like it should.

Thanks,

Jared

Comment 22

[Kevin Grandon :kgrandon]

Comment on attachment 8523343 [details] [review]
Github PR 26164

Sorry about the breakage. I feel fine R+ing this since I did the original work to migrate.

Comment 24

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Thanks, Kevin!

Gip failed to start[1], just retriggered it. I'll merge this fix once it goes green.

[1] https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=c5c56faa7c93

Comment 26

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Master: https://github.com/mozilla-b2g/gaia/commit/315216dc490bdc56d46ee8f3f514a485b962dde0

Resetting the v2.2 status to 'fixed' so that it can get another round of verification.

Comment 28

[(not reading bugmail) Nick Desaulniers [:\n]]

We were seeing this on 2.0.

Comment 29

[Seth Miko [:SMiko]]

Verified fixed on Flame 2.2 (319mb/shallow flash) and Flame 2.0 (319mb/shallow flash)

Actual result: 
Login page populates. The user can create and sign in to FxA accounts. 

Device: Flame 2.2 (319mb/shallow flash)
BuildID: 20141118040205
Gaia: 4aee256937afe9db2520752650685ba61ce6097d
Gecko: 7913c9392c5f
Version: 36.0a1 (2.2) 
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Device: Flame 2.0 (319mb/shallow flash)
BuildID: 20141118000207
Gaia: 1ede2666f1e6c1b3fd3b282011caf0cbc59544b0
Gecko: 2bea026d4f86
Version: 32.0 (2.0) 
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 30

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

(In reply to Nick Desaulniers [:\n] from comment #28)
> We were seeing this on 2.0.

Hmm. The bug here seems to have been caused by a refactoring that wasn't uplifted to 2.1 or 2.0, so I'm not sure how it could have been fixed.

Nick, I think a separate bug might be warranted. I'll reopen bug 1100651 and we'll have QA try to reproduce there.

Comment 31

[Peter Bylenga [:PBylenga]]

Removing the flag for 2.0 here then.

Comment 32

[(not reading bugmail) Nick Desaulniers [:\n]]

Jared, this is specifically about creating a FxA for the very first time on device.  I'm not sure #1100651 is?

Comment 33

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

In the latest 2.2 build for Flatfish, this issue no longer occurs.

Environmental Variables:
Flatfish 2.2
BuildID: 20141119014546
Gaia: 0da467aba9ecf354b905f9cc08dfa1a4169659e4
Gecko: 0ce3a6540d11bf82e48dd15c802899a0e93b6486
Version: 36.0a1 (2.2)

Comment 34

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

(In reply to Nick Desaulniers [:\n] from comment #32)
> Jared, this is specifically about creating a FxA for the very first time on
> device.  I'm not sure #1100651 is?

Hi Nick,

This particular bug only occurs on 2.2; the patch that caused the regression was never uplifted to 2.0. If you saw this bug on 2.0, as you mentioned in comment 28, then it must have been a different bug with a different root cause. (After looking at bug 1100651 a bit, I actually think it was observed on 2.2, but Harald must have thought he was on 2.0. See my comments there for more details.)

Cheers,

Jared

Comment 37

[bhavana bajaj [:bajaj]]

Clearing the blocking nom for 2.2? as this is already fixed/verified on that branch per the status flag