browser_newtab_drag_drop.js is failing in runbydir mode on win8 x64

RESOLVED FIXED in Firefox 60

Status

()

defect
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: jmaher, Unassigned)

Tracking

unspecified
Firefox 60
x86_64
Windows 8
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

I believe this is the last bug to file for run-by-dir:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=97d345074e72&searchQuery=mochitest-browser-chrome

04:28:37 INFO - 670 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_drag_drop.js | Test timed out - expected PASS
04:28:37 INFO - [Parent 2332] WARNING: NS_ENSURE_TRUE(mMutable) failed: file c:\builds\moz2_slave\try-w64-d-00000000000000000000\build\netwerk\base\src\nsSimpleURI.cpp, line 265
04:28:37 INFO - [Parent 2332] WARNING: NS_ENSURE_SUCCESS(EnsureScriptEnvironment(), nullptr) failed with result 0x80040111: file c:\builds\moz2_slave\try-w64-d-00000000000000000000\build\docshell\base\nsDocShell.cpp, line 4451
04:28:37 INFO - JavaScript error: chrome://mochitests/content/browser/browser/base/content/test/newtab/head.js, line 578: TypeError: win is null
04:28:37 INFO - [Parent 2332] WARNING: NS_ENSURE_SUCCESS(EnsureScriptEnvironment(), nullptr) failed with result 0x80040111: file c:\builds\moz2_slave\try-w64-d-00000000000000000000\build\docshell\base\nsDocShell.cpp, line 4451
04:28:37 INFO - JavaScript error: chrome://mochitests/content/browser/browser/base/content/test/newtab/head.js, line 578: TypeError: win is null
04:28:37 INFO - [Parent 2332] WARNING: NS_ENSURE_SUCCESS(EnsureScriptEnvironment(), nullptr) failed with result 0x80040111: file c:\builds\moz2_slave\try-w64-d-00000000000000000000\build\docshell\base\nsDocShell.cpp, line 4451
04:28:37 INFO - JavaScript error: chrome://mochitests/content/browser/browser/base/content/test/newtab/head.js, line 578: TypeError: win is null
04:28:37 INFO - [Parent 2332] WARNING: NS_ENSURE_SUCCESS(EnsureScriptEnvironment(), nullptr) failed with result 0x80040111: file c:\builds\moz2_slave\try-w64-d-00000000000000000000\build\docshell\base\nsDocShell.cpp, line 4451
04:28:37 INFO - JavaScript error: chrome://mochitests/content/browser/browser/base/content/test/newtab/head.js, line 578: TypeError: win is null
04:28:37 INFO - 671 INFO TEST-OK | chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_drag_drop.js | took 90260ms
04

and 
04:29:49 WARNING - TEST-UNEXPECTED-FAIL | browser/base/content/test/newtab/browser_newtab_drag_drop.js | leaked 2 window(s) until shutdown [url = about:newtab]


I suspect the leak is a side effect of the first issue in the log.  Looking at dxr, here is the culprit:
http://dxr.mozilla.org/mozilla-central/source/browser/base/content/test/newtab/head.js#577

I am not sure why --run-by-dir would cause this to fail.  This is run in the middle of the overall test suite, so it most likely isn't related to an issue of waiting for the browser to initialize- maybe this is actually a test that is affected by a previous test in a different directory.
this has been disabled on trunk for win debug.

ttaubert, is there something I could do here to help debug or maybe fix this?

I noticed the refactor to the referenced head.js file, the original error is now here:
http://dxr.mozilla.org/mozilla-central/source/browser/base/content/test/newtab/head.js#605

To kick off the investigation a bit, here is a new try run:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=92104e6a9523

we will see if this yields similar information!
data has come in and on win8 debug we see this fail a couple of times:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=92104e6a9523

detailed view of a specific failure:
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3230420&repo=try

It appears we make it this far:
http://dxr.mozilla.org/mozilla-central/source/browser/base/content/test/newtab/browser_newtab_drag_drop.js#41

we continue to get the javascript error for win=null as referenced above in comment 1.

ttaubert, you seem to be the most active name on this test case, any thoughts?
Flags: needinfo?(ttaubert)
No immediate idea, no. The drag&drop testing code is quite fragile unfortunately. I unfortunately have no win8/64 environment to see if I can reproduce it. If we can't fix it in time I would suggest disabling it only for win8 if that's the only thing blocking you from landing --run-by-dir.
Flags: needinfo?(ttaubert)
Test was removed in bug 1433133 https://hg.mozilla.org/mozilla-central/rev/fc80dd3e4fae
Status: NEW → RESOLVED
Closed: 2 years ago
Depends on: 1433133
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.