1057512 - tracking bug to get --run-by-dir enabled for browser-chrome on trunk

Status: RESOLVED FIXED

(Testing :: General, defect)

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

this is determined based on recent patches landed and a try run last night:
https://tbpl.mozilla.org/?tree=Try&rev=0b5eb184c71d

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Here is where we are from this morning:
https://tbpl.mozilla.org/?tree=Try&rev=4d45ec919503

something to note- I have removed --quiet from the mozharness configs for additional debugging and I suspect this is causing the mozAudio crash to not occur.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: turn on --run-by-dir for bc* (1.0)

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

for reference, here is a try push:
https://tbpl.mozilla.org/?tree=Try&rev=7bed29518c49

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 8486445 [details] [diff] [review]
turn on --run-by-dir for bc* (1.0)

Review of attachment 8486445 [details] [diff] [review]:
-----------------------------------------------------------------

Such a small patch at the end of all that work. :)

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

thanks for the quick review:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b0ae11d2441

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Backed out for introducing some new intermittent failures and making bug 632290 perma-fail.
https://hg.mozilla.org/integration/mozilla-inbound/rev/12bf2f10d6a1

https://tbpl.mozilla.org/php/getParsedLog.php?id=47704766&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=47706227&tree=Mozilla-Inbound

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

https://tbpl.mozilla.org/?tree=Try&rev=6d8041d9592d

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

https://tbpl.mozilla.org/?tree=Try&rev=aa8d5c647bb6

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

https://tbpl.mozilla.org/?tree=Try&rev=ad0cbe532208

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

https://tbpl.mozilla.org/?tree=Try&rev=ff0c9b173dab

Comment 12

[Joel Maher ( :jmaher ) (UTC -8)]

https://tbpl.mozilla.org/?tree=Try&rev=e96ca06f36ef

Comment 13

[Joel Maher ( :jmaher ) (UTC -8)]

https://tbpl.mozilla.org/?tree=Try&rev=2ced696ea247

Comment 14

[Joel Maher ( :jmaher ) (UTC -8)]

https://tbpl.mozilla.org/?tree=Try&rev=7cf246496afc

Comment 15

[Joel Maher ( :jmaher ) (UTC -8)]

https://tbpl.mozilla.org/?tree=Try&rev=799c9a5f18c4

Comment 16

[Joel Maher ( :jmaher ) (UTC -8)]

https://tbpl.mozilla.org/?tree=Try&rev=d149cba9370d

Comment 17

[Joel Maher ( :jmaher ) (UTC -8)]

https://tbpl.mozilla.org/?tree=Try&rev=de7c9ecdd551

Comment 18

[Joel Maher ( :jmaher ) (UTC -8)]

https://tbpl.mozilla.org/?tree=Try&rev=7e88422f7150

Comment 19

[Joel Maher ( :jmaher ) (UTC -8)]

https://tbpl.mozilla.org/?tree=Try&rev=4caab98691e6

Comment 20

[Joel Maher ( :jmaher ) (UTC -8)]

https://tbpl.mozilla.org/?tree=Try&rev=24074e9f7d38

Comment 21

[Joel Maher ( :jmaher ) (UTC -8)]

https://tbpl.mozilla.org/?tree=Try&rev=6a1e35de2467

Comment 22

[Joel Maher ( :jmaher ) (UTC -8)]

https://tbpl.mozilla.org/?tree=Try&rev=988934230757

Comment 23

[Joel Maher ( :jmaher ) (UTC -8)]

https://tbpl.mozilla.org/?tree=Try&rev=d2e93c17d379

Comment 24

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: turn on --run-by-dir for bc* (2.0)

ok, this time I have 3 tests to disable (with bugs annotated), and not doing this for e10s.

Comment 25

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8523900 [details] [diff] [review]
turn on --run-by-dir for bc* (2.0)

Review of attachment 8523900 [details] [diff] [review]:
-----------------------------------------------------------------

Why not. Please land ASAP so we can be on the lookout for regressions as quickly as possible.

Comment 26

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c007f1136acd

Comment 27

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c007f1136acd

Comment 28

[Joel Maher ( :jmaher ) (UTC -8)]

I want to get this done for e10s as well

Comment 29

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: enable run-by-dir for bc* e10s (3.0)

Now that we have browser-chrome using --run-by-dir, it is time to enable this for the e10s variation.

A try server run with this going and 1 test disabled:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=9f790db1d3af

The test is documented in https://bugzilla.mozilla.org/show_bug.cgi?id=1101482 and in comment 4 (https://bugzilla.mozilla.org/show_bug.cgi?id=1101482#c4), :gijs is fine with disabling this test for e10s browser-chrome.

Comment 30

[Dan Minor [:dminor]]

Comment on attachment 8525413 [details] [diff] [review]
enable run-by-dir for bc* e10s (3.0)

Review of attachment 8525413 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

::: testing/mochitest/runtests.py
@@ +1711,5 @@
>  
>      self.setTestRoot(options)
>  
>      # Until we have all green, this only runs on bc* jobs (not dt* jobs)
>      # skipping on e10s jobs as we have a few extra failures

please update comment

Comment 31

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/01539198e454

Comment 32

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/01539198e454

Comment 33

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: enable run-by-dir for dt* (4.0)

ok, this should be the last patch in a long series, but we are finally there.  In bug 1102188 we solve the solo test issue blocking us from running on dt* jobs.

Here is a try server run:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=e24b4a171489

Comment 34

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/188d22215166

Comment 35

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/34594cb8b2e4

Comment 36

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/188d22215166
https://hg.mozilla.org/mozilla-central/rev/34594cb8b2e4

Comment 37

[Carsten Book [:Tomcat]]

sorry joel had to this out for permanent memory leaks like https://treeherder.mozilla.org/ui/logviewer.html#?job_id=663470&repo=mozilla-central

Comment 38

[Joel Maher ( :jmaher ) (UTC -8)]

got it, this is on osx 10.8 debug (go figure, the unique failure count on 10.8 grows by 1, thanks to no default testing on try server).

This leak is in the browser/devtools/scratchpad/test directory.