Closed Bug 1057512 Opened 5 years ago Closed 4 years ago

tracking bug to get --run-by-dir enabled for browser-chrome on trunk

Categories

(Testing :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla36

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(3 files, 1 obsolete file)

No description provided.
this is determined based on recent patches landed and a try run last night:
https://tbpl.mozilla.org/?tree=Try&rev=0b5eb184c71d
Depends on: 1058695
Here is where we are from this morning:
https://tbpl.mozilla.org/?tree=Try&rev=4d45ec919503

something to note- I have removed --quiet from the mozharness configs for additional debugging and I suspect this is causing the mozAudio crash to not occur.
No longer depends on: 1041594
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8486445 - Flags: review?(ted)
for reference, here is a try push:
https://tbpl.mozilla.org/?tree=Try&rev=7bed29518c49
Comment on attachment 8486445 [details] [diff] [review]
turn on --run-by-dir for bc* (1.0)

Review of attachment 8486445 [details] [diff] [review]:
-----------------------------------------------------------------

Such a small patch at the end of all that work. :)
Attachment #8486445 - Flags: review?(ted) → review+
Depends on: 1082130
Depends on: 1082133
Depends on: 1092587
Depends on: 1095717
Depends on: 1095723
Depends on: 1096285
No longer depends on: 963075
No longer depends on: 1058695
Depends on: 1097056
Depends on: 1098640
Depends on: 1100301
ok, this time I have 3 tests to disable (with bugs annotated), and not doing this for e10s.
Attachment #8486445 - Attachment is obsolete: true
Attachment #8523900 - Flags: review?(ryanvm)
Comment on attachment 8523900 [details] [diff] [review]
turn on --run-by-dir for bc* (2.0)

Review of attachment 8523900 [details] [diff] [review]:
-----------------------------------------------------------------

Why not. Please land ASAP so we can be on the lookout for regressions as quickly as possible.
Attachment #8523900 - Flags: review?(ryanvm) → review+
https://hg.mozilla.org/mozilla-central/rev/c007f1136acd
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Depends on: 1101482
I want to get this done for e10s as well
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Now that we have browser-chrome using --run-by-dir, it is time to enable this for the e10s variation.

A try server run with this going and 1 test disabled:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=9f790db1d3af

The test is documented in https://bugzilla.mozilla.org/show_bug.cgi?id=1101482 and in comment 4 (https://bugzilla.mozilla.org/show_bug.cgi?id=1101482#c4), :gijs is fine with disabling this test for e10s browser-chrome.
Attachment #8525413 - Flags: review?(dminor)
Comment on attachment 8525413 [details] [diff] [review]
enable run-by-dir for bc* e10s (3.0)

Review of attachment 8525413 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

::: testing/mochitest/runtests.py
@@ +1711,5 @@
>  
>      self.setTestRoot(options)
>  
>      # Until we have all green, this only runs on bc* jobs (not dt* jobs)
>      # skipping on e10s jobs as we have a few extra failures

please update comment
Attachment #8525413 - Flags: review?(dminor) → review+
https://hg.mozilla.org/mozilla-central/rev/01539198e454
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Depends on: 1102188
ok, this should be the last patch in a long series, but we are finally there.  In bug 1102188 we solve the solo test issue blocking us from running on dt* jobs.

Here is a try server run:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=e24b4a171489
Attachment #8525979 - Flags: review?(dminor)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8525979 - Flags: review?(dminor) → review+
https://hg.mozilla.org/mozilla-central/rev/188d22215166
https://hg.mozilla.org/mozilla-central/rev/34594cb8b2e4
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
sorry joel had to this out for permanent memory leaks like https://treeherder.mozilla.org/ui/logviewer.html#?job_id=663470&repo=mozilla-central
Status: RESOLVED → REOPENED
Flags: needinfo?(jmaher)
Resolution: FIXED → ---
got it, this is on osx 10.8 debug (go figure, the unique failure count on 10.8 grows by 1, thanks to no default testing on try server).

This leak is in the browser/devtools/scratchpad/test directory.
Flags: needinfo?(jmaher)
Depends on: 1101287
Status: REOPENED → RESOLVED
Closed: 5 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.