Update curve shape to account for vertical break

VERIFIED FIXED in Firefox 34

Status

()

defect
VERIFIED FIXED
5 years ago
4 years ago

People

(Reporter: antlam, Assigned: lucasr)

Tracking

unspecified
Firefox 36
All
Android
Points:
---

Firefox Tracking Flags

(firefox33 unaffected, firefox34+ verified, firefox35 verified, firefox36 verified)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Landing improvements in bug 1010739 were great in that it saved space, looked more modern like Australis, matched the updated URL bar, was more functional in dividing up the space, and also saved some more space.

But with that, came this vertical break in the curve that looked awkward at times and wasn't as smooth as the Australis curve. 

To keep the essence of the Australis curve and to adopt to Mobile limitations, we've come up with this update that smoothes out that break quite a bit while not actually taking up more space horizontally.

I think its important that we keep improving on the toolbar as a whole to look at what else we could make better (even just considering all the new devices coming out) and not stall on this iteration alone.

See screenshot for comparison.
(Assignee)

Updated

5 years ago
Attachment #8521727 - Flags: review?(mark.finkle)
Attachment #8521727 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 3

5 years ago
Comment on attachment 8521727 [details] [diff] [review]
Make tab curve slightly smoother (r=mfinkle)

Approval Request Comment
[Feature/regressing bug #]: Bug 1052004
[User impact if declined]: The visual refresh done in Fx34 includes a change to the tab curve shape. UX folks decided to tweak the new curve very slightly to make it more consistent with what we have on desktop.
[Describe test coverage new/current, TBPL]: Local testing, screenshot posted by antlam demonstrate the visual change.
[Risks and why]: None, this is just a 1dp tweak on the tab curve shape.
[String/UUID change made/needed]: n/a
Attachment #8521727 - Flags: approval-mozilla-beta?
Attachment #8521727 - Flags: approval-mozilla-aurora?
(Reporter)

Comment 4

5 years ago
Maybe a dumb question but just in case, this changes the curves on the new Tablet UI too right?
Comment on attachment 8521727 [details] [diff] [review]
Make tab curve slightly smoother (r=mfinkle)

I know this is a simple change but we're at the end of the Beta cycle and this is a very subtle change that I think we can live with in 34. Let's ship this change in 35.
Attachment #8521727 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
(Assignee)

Comment 6

5 years ago
(In reply to Anthony Lam (:antlam) from comment #4)
> Maybe a dumb question but just in case, this changes the curves on the new
> Tablet UI too right?

Yep.
(Reporter)

Comment 7

5 years ago
(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #5)
> Comment on attachment 8521727 [details] [diff] [review]
> Make tab curve slightly smoother (r=mfinkle)
> 
> I know this is a simple change but we're at the end of the Beta cycle and
> this is a very subtle change that I think we can live with in 34. Let's ship
> this change in 35.

Hey Lawrence! 

I know this is a subtle change but on the device this actually addresses the issue (the vertical break) and feels very significant. Since that curve is quite important at the moment as a visual element, we need to get this in before it hits general since those are the majority of our users, we don't want them to jump from the current UI to this, then to this updated one again in 6 weeks if we know we're going to change it.

Is there anyway we can get this in?
Flags: needinfo?(lmandel)
Hey all --

I know (based on irc conversations) that this may seem minor, but here's my take on it:

(a) this is our most identifiable brand-related element in the UI
(b) it's not just that we want to make some slight revisions -- it looks actively _broken_ right now, which leads to larger user questions of "did this update work right?"
(c) seems like a small low-risk change -- but I can't really quantify the risk - I just don't know

(and yes, I acknowledge that many people may not notice, though to people who watch UI it's glaring)

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/815ef0c18a56
Assignee: nobody → lucasr.at.mozilla
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Attachment #8521727 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8521727 [details] [diff] [review]
Make tab curve slightly smoother (r=mfinkle)

I spoke with Madhava at length about this. I certainly can't claim to be an UX expert and, given that we're going to add some time to the 34 schedule, I think it's best that we defer to the experts and accept this relatively safe patch. This will be included in Beta10.
Flags: needinfo?(lmandel)
Attachment #8521727 - Flags: approval-mozilla-beta- → approval-mozilla-beta+
Verified fixed on Firefox for Android 34 Beta 10 using Alcatel One Touch (Android 4.1.2)
(Reporter)

Comment 14

5 years ago
Hey Lawrence!

Probably a dumb question but needed to make sure. Will this change (new UI) make it to General users next week (of Nov 24th), with this fix?
Flags: needinfo?(lmandel)
(In reply to Anthony Lam (:antlam) from comment #14)
> Hey Lawrence!
> 
> Probably a dumb question but needed to make sure. Will this change (new UI)
> make it to General users next week (of Nov 24th), with this fix?

This fix will ship to the release channel in Firefox 34, scheduled to release on Dec 1, 2014. The fix is already available on 34 Beta.
Flags: needinfo?(lmandel)
(Reporter)

Comment 16

5 years ago
Thanks Lawrence!

Comment 17

4 years ago
Verified fixed on Firefox for Android 35 Beta 2 and Aurora 36.0a2(2014-12-12) on Alcatel One Touch (Android 4.1.2)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.