Closed
Bug 1098874
Opened 10 years ago
Closed 10 years ago
Better handling when requiring a reboot
Categories
(Firefox :: Installer, defect)
Tracking
()
RESOLVED
FIXED
Firefox 36
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
Attachments
(1 file, 1 obsolete file)
7.92 KB,
patch
|
bbondy
:
review+
lsblakk
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta-
lsblakk
:
approval-mozilla-esr31-
|
Details | Diff | Splinter Review |
Per bug 1038560 comment #2 and bug 1038560 comment #3 the reboot required code should be rewritten to better handle the non admin case.
Assignee | ||
Comment 2•10 years ago
|
||
This limits the cases to only when files can't be renamed.
Attachment #8524223 -
Flags: review?(netzen)
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8524223 -
Attachment is obsolete: true
Attachment #8524223 -
Flags: review?(netzen)
Attachment #8524246 -
Flags: review?(netzen)
Updated•10 years ago
|
Attachment #8524246 -
Flags: review?(netzen) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Pushed to fx-team https://hg.mozilla.org/integration/fx-team/rev/4cfd2bff3cc5
Target Milestone: --- → Firefox 36
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4cfd2bff3cc5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
status-firefox33:
--- → wontfix
status-firefox34:
--- → affected
status-firefox35:
--- → affected
status-firefox36:
--- → fixed
status-firefox37:
--- → unaffected
status-firefox-esr31:
--- → affected
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8524246 [details] [diff] [review] patch rev2 I would like to get this landed for at least Firefox 35. [Approval Request Comment] If this is not a sec:{high,crit} bug, please state case for ESR consideration: Files that prevent install are added to the installation directory when they shouldn't for non-admin users. User impact if declined: Installation won't be possible. Fix Landed on Version: Firefox 36 Risk to taking this patch (and alternatives if risky): Small. String or UUID changes made by this patch: None
Attachment #8524246 -
Flags: approval-mozilla-esr31?
Attachment #8524246 -
Flags: approval-mozilla-beta?
Attachment #8524246 -
Flags: approval-mozilla-aurora?
Comment 7•9 years ago
|
||
Comment on attachment 8524246 [details] [diff] [review] patch rev2 It's too late to take this change in Firefox 34 and ESR 31.3. We can consider this change for Firefox 35 and ESR 31.4.
Attachment #8524246 -
Flags: approval-mozilla-beta? → approval-mozilla-beta-
Comment 8•9 years ago
|
||
Comment on attachment 8524246 [details] [diff] [review] patch rev2 Taking this for Aurora (35). It doesn't meet ESR criteria and it's not clear there's much value here vs. waiting for 38.0ESR so unless there's a strong case for this from ESR deployers, let's wait.
Attachment #8524246 -
Flags: approval-mozilla-esr31?
Attachment #8524246 -
Flags: approval-mozilla-esr31-
Attachment #8524246 -
Flags: approval-mozilla-aurora?
Attachment #8524246 -
Flags: approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•