Closed Bug 1098874 Opened 10 years ago Closed 10 years ago

Better handling when requiring a reboot

Categories

(Firefox :: Installer, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 36
Tracking Status
firefox33 --- wontfix
firefox34 --- wontfix
firefox35 --- fixed
firefox36 --- fixed
firefox37 --- unaffected
firefox-esr31 --- wontfix

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

Attachments

(1 file, 1 obsolete file)

Per bug 1038560 comment #2 and bug 1038560 comment #3 the reboot required code should be rewritten to better handle the non admin case.
Attached patch patch rev1 (obsolete) — Splinter Review
This limits the cases to only when files can't be renamed.
Attachment #8524223 - Flags: review?(netzen)
Attached patch patch rev2Splinter Review
Attachment #8524223 - Attachment is obsolete: true
Attachment #8524223 - Flags: review?(netzen)
Attachment #8524246 - Flags: review?(netzen)
Attachment #8524246 - Flags: review?(netzen) → review+
Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/4cfd2bff3cc5
Target Milestone: --- → Firefox 36
https://hg.mozilla.org/mozilla-central/rev/4cfd2bff3cc5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 8524246 [details] [diff] [review]
patch rev2

I would like to get this landed for at least Firefox 35.

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: Files that prevent install are added to the installation directory when they shouldn't for non-admin users.
User impact if declined: Installation won't be possible.
Fix Landed on Version: Firefox 36
Risk to taking this patch (and alternatives if risky): Small.
String or UUID changes made by this patch: None
Attachment #8524246 - Flags: approval-mozilla-esr31?
Attachment #8524246 - Flags: approval-mozilla-beta?
Attachment #8524246 - Flags: approval-mozilla-aurora?
Comment on attachment 8524246 [details] [diff] [review]
patch rev2

It's too late to take this change in Firefox 34 and ESR 31.3. We can consider this change for Firefox 35 and ESR 31.4.
Attachment #8524246 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Comment on attachment 8524246 [details] [diff] [review]
patch rev2

Taking this for Aurora (35). It doesn't meet ESR criteria and it's not clear there's much value here vs. waiting for 38.0ESR so unless there's a strong case for this from ESR deployers, let's wait.
Attachment #8524246 - Flags: approval-mozilla-esr31?
Attachment #8524246 - Flags: approval-mozilla-esr31-
Attachment #8524246 - Flags: approval-mozilla-aurora?
Attachment #8524246 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.