1099861 - There are some resource path mixing ://gre/modules and ://modules

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

Attachment: resource_path_fix.diff

Those paths should be unified ://gre/modules if the module is not in comm-central.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8523408 [details] [diff] [review]
resource_path_fix.diff

https://treeherder.mozilla.org/ui/#/jobs?repo=try-comm-central&revision=6b977e577ce1

There are lots of failures but all of those are not caused by this change.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Phillipp, Patrick, could you please check this change is harmless in chat/im and calendar.

Comment 3

[Patrick Cloke [:clokep]]

Comment on attachment 8523408 [details] [diff] [review]
resource_path_fix.diff

Review of attachment 8523408 [details] [diff] [review]:
-----------------------------------------------------------------

This change looks fine. I'd prefer if the gre modules are listed above the /// modules for the chat changes, but this isn't a requirement.

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8523408 [details] [diff] [review]
resource_path_fix.diff

Review of attachment 8523408 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp pending there is a green try-run for calendar tests on the dependent bug.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

(In reply to Philipp Kewisch [:Fallen] from comment #4)
> Comment on attachment 8523408 [details] [diff] [review]
> resource_path_fix.diff
> 
> Review of attachment 8523408 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=philipp pending there is a green try-run for calendar tests on the
> dependent bug.

Which one exactly?

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

I was thinking of bug 1099852, but if you want to do a separate run for this bug thats fine with me too. Mac will be broken for calendar, but as long as the other platforms are ok go ahead.

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Attachment: Add bug#

carrying over review+.

(In reply to Philipp Kewisch [:Fallen] from comment #6)
> I was thinking of bug 1099852, but if you want to do a separate run for this
> bug thats fine with me too. Mac will be broken for calendar, but as long as
> the other platforms are ok go ahead.

Ah, that bug is still in-progress. And it will be hard way...

Anyway thanks for the reviewing.

Comment 8

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/97d2ec8ebdde