Closed Bug 1099861 Opened 6 years ago Closed 6 years ago

There are some resource path mixing ://gre/modules and ://modules

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(thunderbird36 fixed)

RESOLVED FIXED
Thunderbird 36.0
Tracking Status
thunderbird36 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch resource_path_fix.diff (obsolete) — Splinter Review
Those paths should be unified ://gre/modules if the module is not in comm-central.
Comment on attachment 8523408 [details] [diff] [review]
resource_path_fix.diff

https://treeherder.mozilla.org/ui/#/jobs?repo=try-comm-central&revision=6b977e577ce1

There are lots of failures but all of those are not caused by this change.
Attachment #8523408 - Flags: review?(mkmelin+mozilla)
Attachment #8523408 - Flags: review?(philipp)
Attachment #8523408 - Flags: review?(clokep)
Phillipp, Patrick, could you please check this change is harmless in chat/im and calendar.
Attachment #8523408 - Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 8523408 [details] [diff] [review]
resource_path_fix.diff

Review of attachment 8523408 [details] [diff] [review]:
-----------------------------------------------------------------

This change looks fine. I'd prefer if the gre modules are listed above the /// modules for the chat changes, but this isn't a requirement.
Attachment #8523408 - Flags: review?(clokep) → review+
Comment on attachment 8523408 [details] [diff] [review]
resource_path_fix.diff

Review of attachment 8523408 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp pending there is a green try-run for calendar tests on the dependent bug.
Attachment #8523408 - Flags: review?(philipp) → review+
(In reply to Philipp Kewisch [:Fallen] from comment #4)
> Comment on attachment 8523408 [details] [diff] [review]
> resource_path_fix.diff
> 
> Review of attachment 8523408 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=philipp pending there is a green try-run for calendar tests on the
> dependent bug.

Which one exactly?
I was thinking of bug 1099852, but if you want to do a separate run for this bug thats fine with me too. Mac will be broken for calendar, but as long as the other platforms are ok go ahead.
Attached patch Add bug#Splinter Review
carrying over review+.

(In reply to Philipp Kewisch [:Fallen] from comment #6)
> I was thinking of bug 1099852, but if you want to do a separate run for this
> bug thats fine with me too. Mac will be broken for calendar, but as long as
> the other platforms are ok go ahead.

Ah, that bug is still in-progress. And it will be hard way...

Anyway thanks for the reviewing.
Assignee: nobody → hiikezoe
Attachment #8523408 - Attachment is obsolete: true
Attachment #8526612 - Flags: review+
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 36.0
You need to log in before you can comment on or make changes to this bug.