Create test to verify status bar icons appear when home screen is scrolled

RESOLVED FIXED

Status

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: gmealer, Assigned: luis)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

By request from FxOS QA: create a test for the status bar icons to catch situations like bug 1095685 where they don't show.
QA Whiteboard: [fxosqa-auto-s4]
QA Whiteboard: [fxosqa-auto-s4] → [fxosqa-auto-from-s4] [fxosqa-auto-s5]
QA Whiteboard: [fxosqa-auto-from-s4] [fxosqa-auto-s5] → [fxosqa-auto-from-s4] [fxosqa-auto-from-s5] [fxosqa-auto-s6]
QA Whiteboard: [fxosqa-auto-from-s4] [fxosqa-auto-from-s5] [fxosqa-auto-s6] → [fxosqa-auto-from-s4] [fxosqa-auto-from-s5] [fxosqa-auto-from-s6] [fxosqa-auto-s7]
Dropping this until more capacity opens up.
Assignee: gmealer → nobody
QA Whiteboard: [fxosqa-auto-from-s4] [fxosqa-auto-from-s5] [fxosqa-auto-from-s6] [fxosqa-auto-s7] → [fxosqa-auto-from-s4] [fxosqa-auto-from-s5] [fxosqa-auto-from-s6] [fxosqa-auto-dropped-s7]
Assignee

Comment 2

4 years ago
I would like to work on this one, thxs
Luso, thanks for working on this! I think this might be already covered by our imagecompare tests, right No-Jun?
But I guess a Gaia UI test for this, wouldn't hurt either.

I guess we would then need a test under:
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/homescreen/
Flags: needinfo?(npark)
QA Contact: luis
Just ask questions if you need help. For a more direct response, you can find me on IRC (:mwargers).
Assignee: nobody → luis
QA Contact: luis → martijn.martijn
Actually, imagecompare crops the status bar area because it contains the clock, which makes the image comparison fail since it's continuously changing. I think we do need gaia UI test to verify something like this.
Flags: needinfo?(npark)
Assignee

Comment 7

4 years ago
(In reply to Martijn Wargers [:mwargers] (QA) from comment #4)
> Just ask questions if you need help. For a more direct response, you can
> find me on IRC (:mwargers).

Hi Martijn, Could you have a look to the attachment? I'm not pretty sure if is this test what we are looking for, thanks
Assignee

Updated

4 years ago
Attachment #8631617 - Flags: review?(bebe)
Assignee

Updated

4 years ago
Status: NEW → ASSIGNED
Flags: needinfo?(martijn.martijn)
Comment on attachment 8631617 [details] [review]
[gaia] lusob:Bug-1100411-status-bar-icons > mozilla-b2g:master

Luso, sorry about the delay! It happens that I sometimes miss questions in Bugzilla comments. If you needinfo-? me, this won't happen.
I think this test looks good (apart from a very minor nit), but No-Jun also should take a look.
Perhaps the smooth_scroll stuff should be used to mimick a manual scoll to the bottom of the homescreen?
Flags: needinfo?(martijn.martijn)
Attachment #8631617 - Flags: review?(npark)
Attachment #8631617 - Flags: review?(bebe)
Attachment #8631617 - Flags: review+
Comment on attachment 8631617 [details] [review]
[gaia] lusob:Bug-1100411-status-bar-icons > mozilla-b2g:master

other than a minor nit, LGTM.
Attachment #8631617 - Flags: review?(npark) → review+
Luso, I forgot, you need to add this test as an entry in the manifest.ini file: http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/homescreen/manifest.ini#35

Could you do that?
We decided this is a smoketest blocker if it would fail, so please also add "smoketest = true" to it, ok? Thanks.

After you've done that and fixed the small nit, we can merge the pull request.
Flags: needinfo?(luis)
Assignee

Comment 11

4 years ago
(In reply to Martijn Wargers [:mwargers] (QA) from comment #10)
> Luso, I forgot, you need to add this test as an entry in the manifest.ini
> file:
> http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/
> functional/homescreen/manifest.ini#35
> 
> Could you do that?
> We decided this is a smoketest blocker if it would fail, so please also add
> "smoketest = true" to it, ok? Thanks.
> 
> After you've done that and fixed the small nit, we can merge the pull
> request.

Ok Martijn, I think it's ready right now
Flags: needinfo?(luis)
Merged: https://github.com/mozilla-b2g/gaia/commit/52f3ea58df38e5427f6afeb636bc6ad01d24022f

Thanks for fixing, Luso!
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Depends on: 1194167
You need to log in before you can comment on or make changes to this bug.