1100411 - Create test to verify status bar icons appear when home screen is scrolled

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

By request from FxOS QA: create a test for the status bar icons to catch situations like bug 1095685 where they don't show.

Comment 1

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Dropping this until more capacity opens up.

Comment 2

[lusob]

I would like to work on this one, thxs

Comment 3

[Martijn Wargers (dead)]

Luso, thanks for working on this! I think this might be already covered by our imagecompare tests, right No-Jun?
But I guess a Gaia UI test for this, wouldn't hurt either.

I guess we would then need a test under:
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/homescreen/

Comment 4

[Martijn Wargers (dead)]

Just ask questions if you need help. For a more direct response, you can find me on IRC (:mwargers).

Comment 5

[No-Jun Park [:njpark]]

Actually, imagecompare crops the status bar area because it contains the clock, which makes the image comparison fail since it's continuously changing. I think we do need gaia UI test to verify something like this.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] lusob:Bug-1100411-status-bar-icons > mozilla-b2g:master

Comment 7

[lusob]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #4)
> Just ask questions if you need help. For a more direct response, you can
> find me on IRC (:mwargers).

Hi Martijn, Could you have a look to the attachment? I'm not pretty sure if is this test what we are looking for, thanks

Comment 8

[Martijn Wargers (dead)]

Comment on attachment 8631617 [details] [review]
[gaia] lusob:Bug-1100411-status-bar-icons > mozilla-b2g:master

Luso, sorry about the delay! It happens that I sometimes miss questions in Bugzilla comments. If you needinfo-? me, this won't happen.
I think this test looks good (apart from a very minor nit), but No-Jun also should take a look.
Perhaps the smooth_scroll stuff should be used to mimick a manual scoll to the bottom of the homescreen?

Comment 9

[No-Jun Park [:njpark]]

Comment on attachment 8631617 [details] [review]
[gaia] lusob:Bug-1100411-status-bar-icons > mozilla-b2g:master

other than a minor nit, LGTM.

Comment 10

[Martijn Wargers (dead)]

Luso, I forgot, you need to add this test as an entry in the manifest.ini file: http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/homescreen/manifest.ini#35

Could you do that?
We decided this is a smoketest blocker if it would fail, so please also add "smoketest = true" to it, ok? Thanks.

After you've done that and fixed the small nit, we can merge the pull request.

Comment 11

[lusob]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #10)
> Luso, I forgot, you need to add this test as an entry in the manifest.ini
> file:
> http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/
> functional/homescreen/manifest.ini#35
> 
> Could you do that?
> We decided this is a smoketest blocker if it would fail, so please also add
> "smoketest = true" to it, ok? Thanks.
> 
> After you've done that and fixed the small nit, we can merge the pull
> request.

Ok Martijn, I think it's ready right now

Comment 12

[Martijn Wargers (dead)]

Merged: https://github.com/mozilla-b2g/gaia/commit/52f3ea58df38e5427f6afeb636bc6ad01d24022f

Thanks for fixing, Luso!