Closed Bug 1100534 Opened 10 years ago Closed 10 years ago

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/folder-display/test-columns.js | test-columns.js::test_persist_columns_gloda_collection

Categories

(Thunderbird :: Folder and Message Lists, defect)

Product:
Thunderbird
Component:
Folder and Message Lists
Version:
35 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird36 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 36.0
Tracking Flags:
Tracking Status
thunderbird36 --- fixed

People

(Reporter: mkmelin, Assigned: hiro)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 2 obsolete files)

Check the updated state on each column change v2
2.52 KB, patch
hiro
: review+
Details | Diff | Splinter Review 
Related/dupes: bug 977253, bug 726770. Filing this now as I don't know if it really is the same.

https://tbpl.mozilla.org/php/getParsedLog.php?id=52773346&tree=Thunderbird-Trunk&full=1#error0
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/folder-display/test-columns.js | test-columns.js::test_persist_columns_gloda_collection
TEST-START | /builds/slave/test/build/mozmill/folder-display/test-columns.js | test_reset_columns_gloda_collection
Test Failure: Found visible column 'locationCol' but was expecting 'accountCol'!
desired list: threadCol,flaggedCol,subjectCol,senderCol,dateCol,accountCol
 actual list: threadCol,flaggedCol,subjectCol,senderCol,dateCol,locationCol
(In reply to Magnus Melin from comment #0)
> Related/dupes: bug 977253, bug 726770. Filing this now as I don't know if it
> really is the same.

This failure is definitely different from those bugs.

The first appearance is on the second run of:
https://treeherder.mozilla.org/ui/#/jobs?repo=comm-central&revision=47be95d387af
The first run of mozmill tests did not fail on this test.

So it's a regression of some changes in mozilla-central.
After 1081038, the callback (gFolderDisplay.hintColumnsChanged) of MutationObserver has been slightly shifted. So we have to wait for being the callback surely invoked before opening another tab.
I think the previous patch will fix the failure on the try but this patch is more robust.
Attachment #8525734 - Attachment is obsolete: true
Comment on attachment 8525753 [details] [diff] [review]
Check the updated state on each column change

Try server results seem good.
Attachment #8525753 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8525753 [details] [diff] [review]
Check the updated state on each column change

Review of attachment 8525753 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/test/mozmill/folder-display/test-columns.js
@@ +466,5 @@
>  function FakeCollection() {
>    this.items = [];
>  }
>  
> +function plan_for_columns_state_updated() {

should probably be named plan_for_columns_state_update (without the d)

@@ +472,5 @@
> +}
> +
> +function wait_for_columns_state_updated() {
> +  const STATE_PREF = "mailnews.database.global.views.global";
> +  function columns_state_updated() {

in js strict mode this will cause a complaint. you should be able to use the
let columns_state_updated = function() form though
Attachment #8525753 - Flags: review?(mkmelin+mozilla) → review+
Carrying over review +.

(In reply to Magnus Melin from comment #52)
> Review of attachment 8525753 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mail/test/mozmill/folder-display/test-columns.js
> @@ +466,5 @@
> >  function FakeCollection() {
> >    this.items = [];
> >  }
> >  
> > +function plan_for_columns_state_updated() {
> 
> should probably be named plan_for_columns_state_update (without the d)

I really appreciate this kinds of collection because you know my English skill is really awful.

> @@ +472,5 @@
> > +}
> > +
> > +function wait_for_columns_state_updated() {
> > +  const STATE_PREF = "mailnews.database.global.views.global";
> > +  function columns_state_updated() {
> 
> in js strict mode this will cause a complaint. you should be able to use the
> let columns_state_updated = function() form though

Thanks again! I did not know it.

I did a try run again for the safety.
https://treeherder.mozilla.org/ui/#/jobs?repo=try-comm-central&revision=6aea1757c08c
Assignee: nobody → hiikezoe
Attachment #8525753 - Attachment is obsolete: true
Attachment #8526456 - Flags: review+
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 36.0
Thanks :)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: