Closed Bug 1102188 Opened 5 years ago Closed 5 years ago

browser_devtools_api.js fails when run as a standalone directory

Categories

(DevTools :: Framework, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 36

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(1 file, 1 obsolete file)

We have a promise rejection that we fail to handle while running /browser/devtools/framework/test as a directory (done in automation with --run-by-dir):
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=cd46f76e9763&searchQuery=devtools

Luckily fixing this one issue gives us a lot of green and the ability to change the way we run tests in automation to use run-by-dir:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=e24b4a171489

This is easy to reproduce locally and it is easy to fix by just adding:
thisTestLeaksUncaughtRejectionsAndShouldBeFixed("TypeError: this.doc is undefined");
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8525969 - Flags: review?(dteller)
Comment on attachment 8525969 [details] [diff] [review]
add whitelist for this.doc is undefined (1.0)

Review of attachment 8525969 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/framework/test/browser_devtools_api.js
@@ +3,5 @@
>  
>  ///////////////////
>  //
>  // Whitelisting this test.
>  // As part of bug 1077403, the leaking uncaught rejection should be fixed.

Could you take the opportunity to make `rejection` a plural? :)
Attachment #8525969 - Flags: review?(dteller) → review+
carry forward r+, just updated the comment to be more accurate!
Attachment #8525969 - Attachment is obsolete: true
Attachment #8525974 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/a772383cc756
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.