1102188 - browser_devtools_api.js fails when run as a standalone directory

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

We have a promise rejection that we fail to handle while running /browser/devtools/framework/test as a directory (done in automation with --run-by-dir):
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=cd46f76e9763&searchQuery=devtools

Luckily fixing this one issue gives us a lot of green and the ability to change the way we run tests in automation to use run-by-dir:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=e24b4a171489

This is easy to reproduce locally and it is easy to fix by just adding:
thisTestLeaksUncaughtRejectionsAndShouldBeFixed("TypeError: this.doc is undefined");

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add whitelist for this.doc is undefined (1.0)

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8525969 [details] [diff] [review]
add whitelist for this.doc is undefined (1.0)

Review of attachment 8525969 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/framework/test/browser_devtools_api.js
@@ +3,5 @@
>  
>  ///////////////////
>  //
>  // Whitelisting this test.
>  // As part of bug 1077403, the leaking uncaught rejection should be fixed.

Could you take the opportunity to make `rejection` a plural? :)

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add whitelist for this.doc is undefined (1.1)

carry forward r+, just updated the comment to be more accurate!

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a772383cc756

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a772383cc756