Closed Bug 1102671 Opened 10 years ago Closed 10 years ago

[Telephony] Should set hangUpLocal on calls when we use hangUpForground and hangUpBackground

Categories

(Firefox OS Graveyard :: RIL, defect)

Product:
Firefox OS Graveyard
Component:
RIL
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.0M+, b2g-v2.0M fixed, b2g-v2.2 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g 2.0M+
Tracking Flags:
Tracking Status
b2g-v2.0M --- fixed
b2g-v2.2 --- fixed

People

(Reporter: aknow, Assigned: aknow)

References

Details

Attachments

(2 files, 1 obsolete file)

Set hangUpLocal correctly
1.89 KB, patch
hsinyi
: review+
Details | Diff | Splinter Review
(2.0m) Set hangUpLocal correctly. r=hsinyi
2.10 KB, patch
aknow
: review+
Details | Diff | Splinter Review
No description provided.
Summary: [Telephony] Should also set hangUpLocal on calls when we use hangUpForground and hangUpBackground → [Telephony] Should set hangUpLocal on calls when we use hangUpForground, hangUpBackground, and udub
Summary: [Telephony] Should set hangUpLocal on calls when we use hangUpForground, hangUpBackground, and udub → [Telephony] Should set hangUpLocal on calls when we use hangUpForground and hangUpBackground
Patch is rebased on Bug 1093014
Attachment #8527493 - Flags: review?(htsai)
Attachment #8527493 - Flags: review?(htsai) → review+
https://hg.mozilla.org/mozilla-central/rev/d65ddae6f151
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attached patch (2.0m) Set hangUpLocal correctly (obsolete) — — Splinter Review
Attachment #8539915 - Flags: review+
Attachment #8539915 - Attachment is obsolete: true
Attachment #8539916 - Flags: review+
Blocks: 1108966
Blocks: Woodduck
blocking-b2g: --- → 2.0M?
HI Kai-Zhen, Can you help to land on 2.0M? Thanks!
blocking-b2g: 2.0M? → 2.0M+
Flags: needinfo?(kli)
Does this need to land on v2.1? If so, please request b2g34 approval on the patch.
Flags: needinfo?(szchen)
Hi Josh, Do we need this for v2.1 as well?
Flags: needinfo?(szchen) → needinfo?(jocheng)
If the calls are hungup by user, the disconnected cause for them should be "normal call clearing". That means there will be no error prompt shown on the screen. However, there are some corner cases we didn't handed well and this patch fixed the issue. Without this fix, sometimes, when user hangup the conference call, the phone may display an incorrect error prompt.
Hi Bhavana, I think this is severe issue fix in 2.0M and 2.1. I think we should also fix this in 2.1 or maybe 2.0. If you agree, bug 1089534 is also needed to work with this one. Please help to make the decision. Thanks!
Flags: needinfo?(jocheng) → needinfo?(bbajaj)
looks like a huge change to me, so unless we have partners filing bugs against this or qa reporting it, i'd not uplift
Flags: needinfo?(bbajaj)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: