1102965 - [SIM PIN] SIM PIN dialog is not shown on startup when Lock Screen is off

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Alberto Pastor [:albertopq]]

On a Screen lock disabled device:

STR:

1.- Restart the phone via the Sleep menu


Expected:

The SIM PIN dialog is shown

Actual:

SIM PIN dialog is not shown

The cardstatechange events are not handled properly on restart. In case of the lockscreen, we try to show the dialog again on every unlock, so the problem is solved, but in case that is not enabled, we need to properly handle those events.

Comment 1

[Alberto Pastor [:albertopq]]

I forgot to mention that you need to apply this, for reproing 100% of times -> https://bug1090859.bugzilla.mozilla.org/attachment.cgi?id=8524631

Comment 2

[Alberto Pastor [:albertopq]]

Attachment: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26482

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8529135 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26482

Thanks, I think it's my regression; better having unit test next time. Much better this time!

Comment 4

[Alberto Pastor [:albertopq]]

Unit tests included ;)

master:https://github.com/mozilla-b2g/gaia/commit/874575b01cb7d7c9d79400406df4c499e59eac9f

Comment 5

[sarsenyev]

Verified the issue is fixed on 2.2 Flame

SIM PIN dialog appears for two SIM cards after rebooting when the screen is unlocked

"Flame 2.2

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141202040207
Gaia: 725685831f5336cf007e36d9a812aad689604695
Gecko: 2c9781c3e9b5
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
==================================================================
2.1 is still affected.
Only one SIM PIN dialog appears on two SIM cards

"Flame 2.1 

Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141202001201
Gaia: ccb49abe412c978a4045f0c75abff534372716c4
Gecko: 18fb67530b22
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
===================================================================  
Adding "verifyme" for 2.1 patch uplift

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Should this be blocking v2.1 given that bug 1090859 was?

Comment 7

[Alberto Pastor [:albertopq]]

I'll create a 2.1 patch that includes this on Bug 1090859 (as neither of these bugs can be applied directly on the 2.1 codebase)

Comment 9

[Sue]

Attachment: verify_v2.1.MP4

This issue has been verified pass on Flame v2.1
STR:
Prerequisite:Insert a SIM card with PIN.
1. Restart the phone via the Sleep menu.
**The SIM PIN dialog is shown.
See attachment:verify_v2.1.MP4
Rate:0/5

Flame 2.1 build:
Gaia-Rev        d98bbe9d2bfdb53e80dc1ab1572bd05938a85526
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/c694578ff69e
Build-ID        20150128001258
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150128.034753
FW-Date         Wed Jan 28 03:48:03 EST 2015
Bootloader      L1TC000118D0