Closed Bug 1103094 Opened 5 years ago Closed 4 years ago

Start profiling subprocesses if the parent process is already profiling

Categories

(Core :: Gecko Profiler, defect, P3)

x86
All
defect

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
e10s + ---
firefox45 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 5 obsolete files)

When subprocesses are started, they should start profiling if the parent process is already profiling.
Blocks: 1182595
Assignee: nobody → mconley
Bug 1103094 - Add accessor for nsIProfilerStartParams to nsIProfiler. r?BenWa
Blocks: 1193838
Comment on attachment 8645982 [details]
MozReview Request: Bug 1103094 - Add accessor for nsIProfilerStartParams to nsIProfiler. r?BenWa

Bug 1103094 - Add accessor for nsIProfilerStartParams to nsIProfiler. r?BenWa
Bug 1103094 - Start profiling subprocesses if the parent process is already profiling. r?BenWa
Bug 1193838 - Make ProfileGatherer exist during the lifetime of a GeckoSampler. r?BenWa
Bug 1193838 - Expose ProfileGatherer as an nsISupports through nsIProfiler for process parent actors. r?BenWa

We need to let ContentParent and PluginModuleParent get a reference to the ProfileGatherer
during the window of time that we're profiling so that if they start to die (the actor is
starting to go away), they have a gatherer they can send their last profile data to.
Bug 1193838 - Allow ProfileGatherer to gather profiles from exiting processes. r?BenWa
Add some instrumentation and logging
Make talos use async profile dumping stuff
we have a patch for review, but no action in the last 4+ weeks, :mconley, what is the next step here?
Flags: needinfo?(mconley)
The goal to work on this got pushed off to this quarter, so I should hopefully be able to drive this through in the next week or so.
Flags: needinfo?(mconley)
Priority: -- → P3
Attachment #8645982 - Flags: review?(bgirard)
Comment on attachment 8645982 [details]
MozReview Request: Bug 1103094 - Add accessor for nsIProfilerStartParams to nsIProfiler. r?BenWa

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/15569/diff/2-3/
Attachment #8669886 - Flags: review?(bgirard)
Comment on attachment 8669886 [details]
MozReview Request: Bug 1103094 - Start profiling subprocesses if the parent process is already profiling. r?BenWa

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/21279/diff/1-2/
Attachment #8669887 - Attachment is obsolete: true
Attachment #8669888 - Attachment is obsolete: true
Attachment #8669889 - Attachment is obsolete: true
Attachment #8669890 - Attachment is obsolete: true
Attachment #8669891 - Attachment is obsolete: true
Sorry it's kinda taken me forever to get back to this[1]. Also, BenWa, if you know of some other way I can do this Vector <-> Array conversion, please let me know. (I seem to recall us using Vectors to be more portable for non-Mozilla things).
Attachment #8645982 - Flags: review?(bgirard) → review+
Comment on attachment 8645982 [details]
MozReview Request: Bug 1103094 - Add accessor for nsIProfilerStartParams to nsIProfiler. r?BenWa

https://reviewboard.mozilla.org/r/15569/#review23747

::: tools/profiler/gecko/nsIProfiler.idl:63
(Diff revision 3)
> +  readonly attribute nsIProfilerStartParams startParams;

Is it worth describing what happens if the profiling isn't started? Maybe, maybe not? I'll leave that decission up to you.

Looks like we'd hit a NS_WARN if the profiler isn't running and return a trivial 0/0/empty/empty object.
Attachment #8669886 - Flags: review?(bgirard) → review+
Comment on attachment 8669886 [details]
MozReview Request: Bug 1103094 - Start profiling subprocesses if the parent process is already profiling. r?BenWa

https://reviewboard.mozilla.org/r/21279/#review23749

Love it, cleans up the code too!
https://reviewboard.mozilla.org/r/15569/#review23747

> Is it worth describing what happens if the profiling isn't started? Maybe, maybe not? I'll leave that decission up to you.
> 
> Looks like we'd hit a NS_WARN if the profiler isn't running and return a trivial 0/0/empty/empty object.

Even better - I'll just return set the incoming outparam to nullptr in that case. Thanks!
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd8dc51c5a5c7fa98101cc2e1486177a36739968
Bug 1103094 - Add accessor for nsIProfilerStartParams to nsIProfiler. r=BenWa

https://hg.mozilla.org/integration/mozilla-inbound/rev/f04beafaf860912b22022d0b787134646cf9c3f1
Bug 1103094 - Start profiling subprocesses if the parent process is already profiling. r=BenWa
Depends on: 1228489
https://hg.mozilla.org/mozilla-central/rev/fd8dc51c5a5c
https://hg.mozilla.org/mozilla-central/rev/f04beafaf860
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.