110320 - QuickSearch: results don't sort correctly until re-sort (Date, Subj, possible others)

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[laurel]

Using nov15 commercial trunk build

The search toolbar (a.k.a. QuickSearch) in the 3-pane window is supposed to show
search results in the same sort as the thread pane was in prior to sort. After
results are displayed, the use can change sort.

In the current build the type of sort is preserved when initially displaying
results, but the results are not always sorted appropriately.  I noticed this
consistently with both Subject and Date sorts. Haven't yet tried all sorts.

1.  Select a large mail folder or newsgroup and sort by date with the newest
messages at the top of the pane.
2.  Type a short string in the QuickSearch text field which will yield many
results over various dates.
    Result:  messages are displayed in date sort, but the newest messages are at
the bottom of the results thread pane.  Still the ascending/descending arrow on
the column heading is in the same direction as was in thread pane prior to sort.
3.  Select a large mail folder or newsgroup and sort by Subject (either
ascending or descending).
2.  Type a short string in the QuickSearch text field which will yield many
results over various subjects.
    Result:  messages are displayed in subject sort, but many messages are out
of alphabetical order.  Not all are misplaced, but many within the list. Once
you re-sort the results by subject the messages will sort correctly.

Comment 1

[laurel]

Status sort behaves similarly to Subj -- status sort before search, search
results are displayed in a pseudo status sort where some results are not in order.

Comment 2

[Navin Gupta]

I am not sorting the QS results.  I just add it to the view as we 
are notified of search hits. I can make it to sort after search is over.

Comment 3

[laurel]

*** Bug 112186 has been marked as a duplicate of this bug. ***

Comment 4

[Len Trigg]

I've noticed that when a sort is performed, the sort order is actually
incorrect. Not sure whether to open a separate bug or just report here.

1. Sort msgs by date
2. Perform a quick search

(For me the results appear sorted but in the reverse direction. This bug seems
to indicate sorting doesn't happen at all. Perhaps it's just because I'm sorting
by date)

3. Click on date column to sort in reverse direction.

Expected results:
Sorting should be in the same direction indicated by the sort indicator.

Actual results:
Sorting is in the opposite direction indicated by the sort indicator.

Comment 5

[laurel]

*** Bug 116402 has been marked as a duplicate of this bug. ***

Comment 6

[laurel]

*** Bug 118021 has been marked as a duplicate of this bug. ***

Comment 7

[laurel]

*** Bug 119784 has been marked as a duplicate of this bug. ***

Comment 8

[Navin Gupta]

Attachment: proposed fix

sort the results after search is over.

Comment 9

[Navin Gupta]

cc bienvenu for review.

Comment 10

[David :Bienvenu]

Comment on attachment 64911 [details] [diff] [review]
proposed fix

r=bienvenu

Comment 11

[Navin Gupta]

fix checked in.

Comment 12

[laurel]

OK using jan29 commercial trunk: win98, linux rh6.2
OK using jan28 commercial trunk: Mac OS X.2

Varied sorts checked. Basically working -- results are sorted according to the
previous/folder view's sort as soon as the search is completed.  When search is
still in progress,  results are added to view but not sorted.

Note:  as according to spec, search results not threaded.  So if folder view
threaded, when search completes it is a default date sort.

Any further issues with search sort will be logged separately.

Comment 13

[laurel]

*** Bug 122474 has been marked as a duplicate of this bug. ***

Comment 14

[laurel]

*** Bug 122852 has been marked as a duplicate of this bug. ***