Closed Bug 1103203 Opened 5 years ago Closed 5 years ago

Remove visitLink from toolkit/content/globalOverlay.js

Categories

(Toolkit :: General, defect)

defect
Not set
Points:
1

Tracking

()

RESOLVED FIXED
mozilla36
Iteration:
36.3

People

(Reporter: Gijs, Assigned: Gijs)

Details

Attachments

(1 file)

As best I can tell it is unused in m-c, c-c, and add-ons:

https://mxr.mozilla.org/mozilla-central/search?string=visitLink
https://mxr.mozilla.org/comm-central/search?string=visitLink
https://mxr.mozilla.org/addons/search?string=visitLink

and it does have a weird window.opener chain thing going on. Let's kill it with fire.
Attached patch rm visitLink,Splinter Review
Attachment #8527048 - Flags: review?(jaws)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8527048 [details] [diff] [review]
rm visitLink,

Review of attachment 8527048 [details] [diff] [review]:
-----------------------------------------------------------------

CVS Blame points to bug 170499 introducing this function to globalOverlay.js (although the linked patch shows it still in aboutDialog.xul). Then bug 349841 and bug 350205 followed (in order) to add to the function. Everything seems to be focused on usage for the About dialog and Thunderbird. The About dialog now uses <label class="text-link" href="" /> which has its behavior defined by http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/text.xml?rev=e947cee33a92#292
Attachment #8527048 - Flags: review?(jaws) → review+
https://hg.mozilla.org/integration/fx-team/rev/313043e41d71

Marco, can this be added to the spreadsheet? Thanks!
Iteration: --- → 36.3
Points: --- → 1
Flags: qe-verify-
Flags: needinfo?(mmucci)
Flags: in-testsuite-
Flags: firefox-backlog+
Whiteboard: [fixed-in-fx-team]
Added to IT 36.3
Flags: needinfo?(mmucci)
https://hg.mozilla.org/mozilla-central/rev/313043e41d71
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.