1103203 - Remove visitLink from toolkit/content/globalOverlay.js

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[:Gijs (he/him)]

As best I can tell it is unused in m-c, c-c, and add-ons:

https://mxr.mozilla.org/mozilla-central/search?string=visitLink
https://mxr.mozilla.org/comm-central/search?string=visitLink
https://mxr.mozilla.org/addons/search?string=visitLink

and it does have a weird window.opener chain thing going on. Let's kill it with fire.

Comment 1

[:Gijs (he/him)]

Attachment: rm visitLink,

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8527048 [details] [diff] [review]
rm visitLink,

Review of attachment 8527048 [details] [diff] [review]:
-----------------------------------------------------------------

CVS Blame points to bug 170499 introducing this function to globalOverlay.js (although the linked patch shows it still in aboutDialog.xul). Then bug 349841 and bug 350205 followed (in order) to add to the function. Everything seems to be focused on usage for the About dialog and Thunderbird. The About dialog now uses <label class="text-link" href="" /> which has its behavior defined by http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/text.xml?rev=e947cee33a92#292

Comment 3

[:Gijs (he/him)]

https://hg.mozilla.org/integration/fx-team/rev/313043e41d71

Marco, can this be added to the spreadsheet? Thanks!

Comment 4

[Marco Mucci [:MarcoM]]

Added to IT 36.3

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/313043e41d71