1103834 - [FFOS2.0][Woodduck][FDN]The PIN2 code interface is not friendly when edit dddelete FDN contacts.

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Vendcom, defect, P2)

Description

[sync-1]

REPRODUCING PROCEDURES:
 1.Insert a SIM that support FDN function
 2.Enter Settings -> call settings -> Fxed dialling numbers -> Enable fixed dialing number -> ko1
 3.Authorized number -> add/edit/delete FDN number
 4.Input a wrong PIN2 code -> ko1
 
 
  EXPECTED BEHAVIOUR:
 1.MS should inform user when PIN2 code is wrong.
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:100%
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

hi mozilla:
   I tend to add a alert when user input wrong pin2.

Comment 2

[Josh Cheng [:josh]]

Hi Gary,
Could you please help to check the problem? Thanks!

Comment 3

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Hi all,
   I think it is UX design, in current design we will show "The PIN2 code is incorrect" with red color.
   We won't change our UX desgin in this phase, in my opinion if you really think it is not friendly please fix it on your local branch.
   Thanks.

Comment 4

[sync-1]

hi mozilla:
    In this interface(add/edit/delete FDN number) ,if you input wrong pin2.there is any tips to tell user and the MP back to "Authorized number" interface.It doesn't show "The PIN2 code is incorrect" with red color.

Comment 5

[sync-1]

hi mozilla:
    目前我测试当删除一个FDN number时，界面会弹出PIN2码的输入界面，输入pin2码错误时会执行gaia/app/settings/js/simcard_dialog.js中的updateFdnContact（）方法，执行req.onerror = function onerror(e) 中的判断var wrongPin2 = /IncorrectPassword/.test(req.error.name);
 但是获取的wrongPin2一直是false而且req.error.name的值是GenericFailure。（在高通平台返回值是IncorrectPassword）.

Comment 6

[sync-1]

hi mozilla:
  are there any news about this PR?

Comment 7

[Peipei Cheng (needinfo if you need my action)]

Gary, could you please help with comment 5?

Comment 8

[alvin.ding]

hi Josh:
    there are any news about this pr?

Comment 9

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Hi all,
   I found this issue only can be reproduced on v2.0m + woodduck , it doesn't occurs on flame with v2.0m.
   It means gecko might return wrong information to gaia,  according our logical gecko should return  'req.error.name' which contains `IncorrectPassword` string, seems 'req.error.name' doesn't match `IncorrectPassword` in woodduck device.
   So I think it should be gecko issue, can you help to find someone check with it?
   Thanks.

Comment 10

[sync-1]

hi mozilla:
    are there any news about this PR?

Comment 11

[Josh Cheng [:josh]]

Hi Shawn,
Can you help to check comment 9? Thanks!

Comment 12

[shawn ku [:sku]]

Hi Partner:
 Please help provide log for me to check.

Comment 13

[sync-1]

hi mozilla:
   
 在flame上能够返回正常的值“IncorrectPassword”，然后根据这个值会停留在输入界面并通知用户输入错误。但是在v2.0m + woodduck上会直接返回到上一界面，不会通知用户输入错误，查看信息此时返回的值是“GenericFailure”。
   
 目前需要在用户输入错误后提示用户输入错误，而不是返回上一界面不提示任何信息。

Comment 14

[sync-1]

Created an attachment (id=1093197)
 log

Comment 15

[sync-1]

Created an attachment (id=1093197)
 log

Comment 16

[sync-1]

Attachment: log

Created an attachment (id=1093197)
 log

Comment 17

[shawn ku [:sku]]

Same as comment 13, Generic failure was returned.

This should ask rild/modem to check why not IncorrectPassword (3), but GenericFailure (2) was returned.


I/Gecko   (  165): RIL Worker: [0] Solicited response for request type 28, token 489, error 2
I/Gecko   (  165): RIL Worker: [0] Handling parcel as REQUEST_SIM_IO
I/Gecko   (  165): -*- RadioInterface[0]: Received message from worker: {"requestId":"id{83ffe847-134e-4d5c-99bd-c5881baf96c0}","contactType":"fdn","contact":{"alphaId":"hvc","number":"*99#","contactId":"898601149231009231167","pbrIndex":0,"recordId":7},"pin2":"1258","rilMessageClientId":0,"rilMessageToken":91,"rilMessageType":"updateICCContact","errorMsg":"GenericFailure"}

Comment 18

[sync-1]

hi mozilla:
    any update so far?

Comment 19

[woodduck]

Hi Wenquan, Please check comment 17. Thanks.

Comment 20

[woodduck]

Dear friend, please help to provide the radio log for me, thanks!

Comment 21

[sync-1]

hi mozilla:
    I hava upload log

Comment 22

[sync-1]

Created an attachment (id=1101198)
 log

Comment 23

[sync-1]

Created an attachment (id=1101198)
 log

Comment 24

[sync-1]

Attachment: log

Created an attachment (id=1101198)
 log

Comment 25

[Josh Cheng [:josh]]

Hi WenQuan,
Please check log provided per comment 24. Thanks!

Comment 26

[woodduck]

I have fixed this issue and will release the patch to TCL, thanks!

Comment 27

[Josh Cheng [:josh]]

Per comment 26. Close.