[FFOS2.0][Woodduck][FDN]The PIN2 code interface is not friendly when edit dddelete FDN contacts.

RESOLVED WORKSFORME

Status

Firefox OS
Vendcom
P2
normal
RESOLVED WORKSFORME
3 years ago
3 years ago

People

(Reporter: sync-1, Assigned: wenquan.zhong)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [POVB])

Attachments

(2 attachments)

log
40.99 KB, text/plain
Details
log
439.19 KB, text/plain
Details
(Reporter)

Description

3 years ago
REPRODUCING PROCEDURES:
 1.Insert a SIM that support FDN function
 2.Enter Settings -> call settings -> Fxed dialling numbers -> Enable fixed dialing number -> ko1
 3.Authorized number -> add/edit/delete FDN number
 4.Input a wrong PIN2 code -> ko1
 
 
  EXPECTED BEHAVIOUR:
 1.MS should inform user when PIN2 code is wrong.
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:100%
 
  For FT PR, Please list reference mobile's behavior:
(Reporter)

Comment 1

3 years ago
hi mozilla:
   I tend to add a alert when user input wrong pin2.

Comment 2

3 years ago
Hi Gary,
Could you please help to check the problem? Thanks!
Blocks: 1054172
Flags: needinfo?(gchen)
Hi all,
   I think it is UX design, in current design we will show "The PIN2 code is incorrect" with red color.
   We won't change our UX desgin in this phase, in my opinion if you really think it is not friendly please fix it on your local branch.
   Thanks.
Flags: needinfo?(gchen)
(Reporter)

Comment 4

3 years ago
hi mozilla:
    In this interface(add/edit/delete FDN number) ,if you input wrong pin2.there is any tips to tell user and the MP back to "Authorized number" interface.It doesn't show "The PIN2 code is incorrect" with red color.
(Reporter)

Comment 5

3 years ago
hi mozilla:
    目前我测试当删除一个FDN number时,界面会弹出PIN2码的输入界面,输入pin2码错误时会执行gaia/app/settings/js/simcard_dialog.js中的updateFdnContact()方法,执行req.onerror = function onerror(e) 中的判断var wrongPin2 = /IncorrectPassword/.test(req.error.name);
 但是获取的wrongPin2一直是false而且req.error.name的值是GenericFailure。(在高通平台返回值是IncorrectPassword).
(Reporter)

Comment 6

3 years ago
hi mozilla:
  are there any news about this PR?
Gary, could you please help with comment 5?
Flags: needinfo?(gchen)

Updated

3 years ago
Blocks: 1107999
blocking-b2g: --- → 2.0M?

Comment 8

3 years ago
hi Josh:
    there are any news about this pr?
Hi all,
   I found this issue only can be reproduced on v2.0m + woodduck , it doesn't occurs on flame with v2.0m.
   It means gecko might return wrong information to gaia,  according our logical gecko should return  'req.error.name' which contains `IncorrectPassword` string, seems 'req.error.name' doesn't match `IncorrectPassword` in woodduck device.
   So I think it should be gecko issue, can you help to find someone check with it?
   Thanks.
Flags: needinfo?(gchen) → needinfo?(chen.ding)
(Reporter)

Comment 10

3 years ago
hi mozilla:
    are there any news about this PR?

Comment 11

3 years ago
Hi Shawn,
Can you help to check comment 9? Thanks!
Flags: needinfo?(chen.ding) → needinfo?(sku)

Comment 12

3 years ago
Hi Partner:
 Please help provide log for me to check.
Flags: needinfo?(sync-1)
(Reporter)

Comment 13

3 years ago
hi mozilla:
   
 在flame上能够返回正常的值“IncorrectPassword”,然后根据这个值会停留在输入界面并通知用户输入错误。但是在v2.0m + woodduck上会直接返回到上一界面,不会通知用户输入错误,查看信息此时返回的值是“GenericFailure”。
   
 目前需要在用户输入错误后提示用户输入错误,而不是返回上一界面不提示任何信息。
(Reporter)

Comment 14

3 years ago
Created an attachment (id=1093197)
 log
(Reporter)

Comment 15

3 years ago
Created an attachment (id=1093197)
 log
(Reporter)

Comment 16

3 years ago
Created attachment 8542110 [details]
log

Created an attachment (id=1093197)
 log

Comment 17

3 years ago
Same as comment 13, Generic failure was returned.

This should ask rild/modem to check why not IncorrectPassword (3), but GenericFailure (2) was returned.


I/Gecko   (  165): RIL Worker: [0] Solicited response for request type 28, token 489, error 2
I/Gecko   (  165): RIL Worker: [0] Handling parcel as REQUEST_SIM_IO
I/Gecko   (  165): -*- RadioInterface[0]: Received message from worker: {"requestId":"id{83ffe847-134e-4d5c-99bd-c5881baf96c0}","contactType":"fdn","contact":{"alphaId":"hvc","number":"*99#","contactId":"898601149231009231167","pbrIndex":0,"recordId":7},"pin2":"1258","rilMessageClientId":0,"rilMessageToken":91,"rilMessageType":"updateICCContact","errorMsg":"GenericFailure"}
Flags: needinfo?(sku) → needinfo?(wudduc)
Whiteboard: [POVB]

Updated

3 years ago
Flags: needinfo?(chien-hao.li)
(Reporter)

Comment 18

3 years ago
hi mozilla:
    any update so far?

Updated

3 years ago
Flags: needinfo?(wudduc)
Flags: needinfo?(wenquan.zhong)
Flags: needinfo?(chien-hao.li)

Comment 19

3 years ago
Hi Wenquan, Please check comment 17. Thanks.

Comment 20

3 years ago
Dear friend, please help to provide the radio log for me, thanks!
Flags: needinfo?(wenquan.zhong)
(Reporter)

Comment 21

3 years ago
hi mozilla:
    I hava upload log
(Reporter)

Comment 22

3 years ago
Created an attachment (id=1101198)
 log
(Reporter)

Comment 23

3 years ago
Created an attachment (id=1101198)
 log
(Reporter)

Comment 24

3 years ago
Created attachment 8544328 [details]
log

Created an attachment (id=1101198)
 log

Comment 25

3 years ago
Hi WenQuan,
Please check log provided per comment 24. Thanks!
blocking-b2g: 2.0M? → 2.0M+
Flags: needinfo?(sync-1) → needinfo?(wenquan.zhong)

Updated

3 years ago
Assignee: nobody → wenquan.zhong
status-b2g-v2.0M: --- → affected

Comment 26

3 years ago
I have fixed this issue and will release the patch to TCL, thanks!
Flags: needinfo?(wenquan.zhong)

Comment 27

3 years ago
Per comment 26. Close.
Status: NEW → RESOLVED
blocking-b2g: 2.0M+ → ---
Last Resolved: 3 years ago
status-b2g-v2.0M: affected → ---
Component: Gaia::Settings → Vendcom
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.