1104036 - With RTL UI, click and drag in the address bar moves the window instead of selecting text

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Simon Montagu :smontagu]

STR: use a right-to-left localization of Firefox, or set intl.uidirection.en to "rtl" in about:config, or use the ForceRTL add-on.

Click in the address bar and try to select text by dragging the mouse.

Expected results: text is selected
Actual results: the window moves with the mouse.

Comment 1

[Ada [:adalucinet]]

Still reproducible with latest Nightly (build ID: 20150105030202) on Mac OS X 10.9.5 and 'intl.uidirection.en' pref set to 'rtl'.

Regression range:
(m-c)
Last good revision: 426497473505 (2014-09-18)
First bad revision: c8e325eee9e1 (2014-09-19)
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=426497473505&tochange=c8e325eee9e1 

(m-i)
Last good revision: 426497473505
First bad revision: 14e633eeb251
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=426497473505&tochange=14e633eeb251

Comment 2

[Simon Montagu :smontagu]

Could this have been caused by bug 944836?

Comment 3

[Markus Stange [:mstange]]

Yes.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Bug 944836 is in 35, this seems like a bad regression for RTL users.

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Is it possible to do a backout of bug 944836 if there was a dot release for 35?  If that was low-risk, we could consider this as a ride-along and save RLT users from many weeks of this behaviour.

Comment 6

[Markus Stange [:mstange]]

(In reply to Lukas Blakk [:lsblakk] use ?needinfo from comment #5)
> Is it possible to do a backout of bug 944836 if there was a dot release for
> 35?  If that was low-risk, we could consider this as a ride-along and save
> RLT users from many weeks of this behaviour.

Yes, I'll prepare a backout patch and request approval. Bug 1122942 (not being able to drag the window when a non-default theme is used) is another regression that bug 944836 caused, and which the backout would fix.

Comment 7

[Markus Stange [:mstange]]

Attachment: back out bug 944836

Approval Request Comment
[Feature/regressing bug #]:
bug 944836

[User impact if declined]:
selecting text in the URL bar moves the window for RTL users + users of custom themes can't drag the window until the themes are updated (bug 1122942)

[Describe test coverage new/current, TreeHerder]:
not much, mostly manual testing

[Risks and why]: hopefully fairly low - there were no problems reverting the patches, this backout also removes the changes that were made on top of bug 944836 (namely, bug 1070038 and bug 1072391, both regression fixes).

[String/UUID change made/needed]: none. I'm leaving the nsIWidget change that we've already shipped in, it just becomes a no-op method.


I'll be testing this as thoroughly as I can over the next hour. I've also started a complete try run at https://treeherder.mozilla.org/#/jobs?repo=try&revision=83a9962e4390 .

Comment 8

[Markus Stange [:mstange]]

I've done extensive testing now and can confirm that the backout fixes all reported regressions. I haven't found any other problems.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Markus, do you have plans for 36 ? Thanks

Comment 10

[Markus Stange [:mstange]]

I'm going to try my hand at fixing this bug today, and if I fail or the fix ends up looking too risky, I'm going to prepare a backout patch for 36 as well.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

ok, thanks for the super fast answer. I am going to track it for 37 & 38 just in case :)

Comment 12

[Markus Stange [:mstange]]

Attachment: patch

In RTL mode, the urlbar <textbox> has a scaleX(-1) transform applied to it, so we ignore the -moz-window-dragging:drag set on it.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

roc, sorry about the ping but we would like to take this patch in 35.0.1. Thanks

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Sorry, I made a confusion in comment #13.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/18ebe6e21ff9

Comment 16

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial issue using Nightly from 19 Sept, verified that the issue does not reproduce using Firefox 35.0.1 on Mac OS X 10.9.5.

Comment 17

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/301bf68c9566

Comment 18

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/301bf68c9566

Comment 19

[Markus Stange [:mstange]]

Comment on attachment 8552735 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 944836
[User impact if declined]: Users of right-to-left language Firefox builds can't select text in the address bar
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: low to medium, but any potential breakage should be contained to window dragging problems
[String/UUID change made/needed]: none

Comment 20

[Markus Stange [:mstange]]

Attachment: patch for beta

The other patch doesn't apply cleanly to beta, but it's just a context mismatch, nothing about the patch itself needs to be changed.

Approval Request Comment: see comment 19

Comment 21

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8552735 [details] [diff] [review]
patch

We shipped this fix in 35.0.1. We need to get the fix in 36 and 37 as well. Aurora+

Comment 22

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8554682 [details] [diff] [review]
patch for beta

Beta+

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/24376efc40fb
https://hg.mozilla.org/releases/mozilla-beta/rev/b57b609d03a7