With RTL UI, click and drag in the address bar moves the window instead of selecting text

RESOLVED FIXED in Firefox 35

Status

()

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: smontagu, Assigned: mstange)

Tracking

({regression, rtl})

unspecified
Firefox 38
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox35+ verified, firefox36+ fixed, firefox37+ fixed, firefox38+ fixed, relnote-firefox 35+)

Details

Attachments

(3 attachments)

Reporter

Description

5 years ago
STR: use a right-to-left localization of Firefox, or set intl.uidirection.en to "rtl" in about:config, or use the ForceRTL add-on.

Click in the address bar and try to select text by dragging the mouse.

Expected results: text is selected
Actual results: the window moves with the mouse.

Comment 1

5 years ago
Still reproducible with latest Nightly (build ID: 20150105030202) on Mac OS X 10.9.5 and 'intl.uidirection.en' pref set to 'rtl'.

Regression range:
(m-c)
Last good revision: 426497473505 (2014-09-18)
First bad revision: c8e325eee9e1 (2014-09-19)
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=426497473505&tochange=c8e325eee9e1 

(m-i)
Last good revision: 426497473505
First bad revision: 14e633eeb251
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=426497473505&tochange=14e633eeb251
Reporter

Comment 2

5 years ago
Could this have been caused by bug 944836?
Flags: needinfo?(mstange)
Assignee

Comment 3

5 years ago
Yes.
Assignee: nobody → mstange
Blocks: 944836
Flags: needinfo?(mstange)
Bug 944836 is in 35, this seems like a bad regression for RTL users.
Is it possible to do a backout of bug 944836 if there was a dot release for 35?  If that was low-risk, we could consider this as a ride-along and save RLT users from many weeks of this behaviour.
Flags: needinfo?(mstange)
Assignee

Comment 6

5 years ago
(In reply to Lukas Blakk [:lsblakk] use ?needinfo from comment #5)
> Is it possible to do a backout of bug 944836 if there was a dot release for
> 35?  If that was low-risk, we could consider this as a ride-along and save
> RLT users from many weeks of this behaviour.

Yes, I'll prepare a backout patch and request approval. Bug 1122942 (not being able to drag the window when a non-default theme is used) is another regression that bug 944836 caused, and which the backout would fix.
Flags: needinfo?(mstange)
Assignee

Comment 7

5 years ago
Approval Request Comment
[Feature/regressing bug #]:
bug 944836

[User impact if declined]:
selecting text in the URL bar moves the window for RTL users + users of custom themes can't drag the window until the themes are updated (bug 1122942)

[Describe test coverage new/current, TreeHerder]:
not much, mostly manual testing

[Risks and why]: hopefully fairly low - there were no problems reverting the patches, this backout also removes the changes that were made on top of bug 944836 (namely, bug 1070038 and bug 1072391, both regression fixes).

[String/UUID change made/needed]: none. I'm leaving the nsIWidget change that we've already shipped in, it just becomes a no-op method.


I'll be testing this as thoroughly as I can over the next hour. I've also started a complete try run at https://treeherder.mozilla.org/#/jobs?repo=try&revision=83a9962e4390 .
Attachment #8552040 - Flags: approval-mozilla-release?
Assignee

Comment 8

5 years ago
I've done extensive testing now and can confirm that the backout fixes all reported regressions. I haven't found any other problems.
Attachment #8552040 - Flags: approval-mozilla-release? → approval-mozilla-release+
Markus, do you have plans for 36 ? Thanks
Flags: needinfo?(mstange)
Assignee

Comment 10

5 years ago
I'm going to try my hand at fixing this bug today, and if I fail or the fix ends up looking too risky, I'm going to prepare a backout patch for 36 as well.
Flags: needinfo?(mstange)
ok, thanks for the super fast answer. I am going to track it for 37 & 38 just in case :)
Assignee

Comment 12

5 years ago
Posted patch patchSplinter Review
In RTL mode, the urlbar <textbox> has a scaleX(-1) transform applied to it, so we ignore the -moz-window-dragging:drag set on it.
Attachment #8552735 - Flags: review?(roc)
roc, sorry about the ping but we would like to take this patch in 35.0.1. Thanks
Flags: needinfo?(roc)
Sorry, I made a confusion in comment #13.
Flags: needinfo?(roc)
Reproduced the initial issue using Nightly from 19 Sept, verified that the issue does not reproduce using Firefox 35.0.1 on Mac OS X 10.9.5.
https://hg.mozilla.org/mozilla-central/rev/301bf68c9566
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Assignee

Comment 19

4 years ago
Comment on attachment 8552735 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 944836
[User impact if declined]: Users of right-to-left language Firefox builds can't select text in the address bar
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: low to medium, but any potential breakage should be contained to window dragging problems
[String/UUID change made/needed]: none
Attachment #8552735 - Flags: approval-mozilla-aurora?
Assignee

Comment 20

4 years ago
The other patch doesn't apply cleanly to beta, but it's just a context mismatch, nothing about the patch itself needs to be changed.

Approval Request Comment: see comment 19
Attachment #8554682 - Flags: approval-mozilla-beta?
Comment on attachment 8552735 [details] [diff] [review]
patch

We shipped this fix in 35.0.1. We need to get the fix in 36 and 37 as well. Aurora+
Attachment #8552735 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8554682 [details] [diff] [review]
patch for beta

Beta+
Attachment #8554682 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.