Closed Bug 1104921 Opened 8 years ago Closed 8 years ago

UITour: Add Loop panel targets

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal
Points:
5

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 37
Iteration:
37.1
Tracking Flags:
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

Details

Attachments

(1 file, 2 obsolete files)

MozReview Request: Bug 1104921 - UITour: Add Loop panel targets. r=Unfocused
39 bytes, text/x-review-board-request
Unfocused
: review+
Details
Attached patch WIP to use regular UITour panels (obsolete) — — Splinter Review 
* New Room button
* List of active rooms
* Sign Up / Sign In

We won't auto-open the panel since that is quite a bit of work so this depends on bug 1080943. The conversation window target of the copy/email buttons will be handled in their own bug.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=99269e45cb74
Flags: qe-verify-
Flags: firefox-backlog+
Blocks: 1104927
Iteration: 36.3 → 37.1
Attached file MozReview Request: bz://1104921/MattN (obsolete) — 
/r/1089 - Bug 1104921 - UITour: Add Loop panel targets. r=Unfocused

Pull down this commit:

hg pull review -r aaf990a20a02f4863c8ebc7be48cfcfac5855b18
Attachment #8528515 - Attachment is obsolete: true
Comment on attachment 8531030 [details]
MozReview Request: bz://1104921/MattN

Try push: https://tbpl.mozilla.org/?tree=Try&rev=61b1ab06e702
Attachment #8531030 - Flags: feedback?(bmcbride)
https://reviewboard.mozilla.org/r/1087/#review649

::: browser/modules/UITour.jsm
(Diff revision 1)
> -    if (!this.isElementVisible(aAnchor.node))
> +    if (!this.isElementVisible(aAnchor.node)) // TODO

Still to-do?

::: browser/modules/UITour.jsm
(Diff revision 1)
> +      return aTarget.targetName.startsWith("loop-"); // TODO: separate convo window

Should reference a bug number here.
Attachment #8531030 - Flags: feedback?(bmcbride)
Attachment #8531030 - Flags: review+ → review?(bmcbride)
/r/1089 - Bug 1104921 - UITour: Add Loop panel targets. r=Unfocused

Pull down this commit:

hg pull review -r 53ff9adacb6e7085440d16e2d152a6f026e080dd
Attachment #8531030 - Flags: review?(bmcbride) → review+
https://reviewboard.mozilla.org/r/1087/#review661

::: browser/modules/UITour.jsm
(Diff revisions 1 - 2)
> +          return loopBrowser;

This is misleading - should explicitly return null.
Backed out for bc2 failures on some platforms:

https://hg.mozilla.org/integration/fx-team/rev/f3278982666a

120 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/modules/test/browser_UITour_loop.js | Timeout waiting for popup at anchor: Info panel should be anchored to the new room button -
status-firefox37: fixed → affected
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/ef884e9f38d4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Comment on attachment 8531030 [details]
MozReview Request: bz://1104921/MattN

[Triage Comment]


Needed for Fx35 Hello tour, no unusual risk. (And basically all the changes here are constrained to UITour.jsm)
Attachment #8531030 - Flags: approval-mozilla-beta+
Attachment #8531030 - Flags: approval-mozilla-aurora+
Attachment #8531030 - Attachment is obsolete: true
Attachment #8618722 - Flags: review+
You need to log in before you can comment on or make changes to this bug.