1104921 - UITour: Add Loop panel targets

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Matthew N. [:MattN]]

Attachment: WIP to use regular UITour panels

* New Room button
* List of active rooms
* Sign Up / Sign In

We won't auto-open the panel since that is quite a bit of work so this depends on bug 1080943. The conversation window target of the copy/email buttons will be handled in their own bug.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=99269e45cb74

Comment 1

[Matthew N. [:MattN]]

Attachment: MozReview Request: bz://1104921/MattN

Comment 2

[Matthew N. [:MattN]]

/r/1089 - Bug 1104921 - UITour: Add Loop panel targets. r=Unfocused

Pull down this commit:

hg pull review -r aaf990a20a02f4863c8ebc7be48cfcfac5855b18

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8531030 [details]
MozReview Request: bz://1104921/MattN

Try push: https://tbpl.mozilla.org/?tree=Try&rev=61b1ab06e702

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://reviewboard.mozilla.org/r/1087/#review649

::: browser/modules/UITour.jsm
(Diff revision 1)
> -    if (!this.isElementVisible(aAnchor.node))
> +    if (!this.isElementVisible(aAnchor.node)) // TODO

Still to-do?

::: browser/modules/UITour.jsm
(Diff revision 1)
> +      return aTarget.targetName.startsWith("loop-"); // TODO: separate convo window

Should reference a bug number here.

Comment 5

[Matthew N. [:MattN]]

(In reply to Matthew N. [:MattN] from comment #3)
> Try push: https://tbpl.mozilla.org/?tree=Try&rev=61b1ab06e702

Downloads builds here: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-61b1ab06e702/

Comment 6

[Matthew N. [:MattN]]

/r/1089 - Bug 1104921 - UITour: Add Loop panel targets. r=Unfocused

Pull down this commit:

hg pull review -r 53ff9adacb6e7085440d16e2d152a6f026e080dd

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://reviewboard.mozilla.org/r/1087/#review661

::: browser/modules/UITour.jsm
(Diff revisions 1 - 2)
> +          return loopBrowser;

This is misleading - should explicitly return null.

Comment 8

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/c9f946144a73

Comment 9

[Matthew N. [:MattN]]

Backed out for bc2 failures on some platforms:

https://hg.mozilla.org/integration/fx-team/rev/f3278982666a

120 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/modules/test/browser_UITour_loop.js | Timeout waiting for popup at anchor: Info panel should be anchored to the new room button -

Comment 10

[Matthew N. [:MattN]]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=20bed255718e

Comment 11

[Matthew N. [:MattN]]

Re-pushed: https://hg.mozilla.org/integration/fx-team/rev/ef884e9f38d4

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ef884e9f38d4

Comment 13

[Justin Dolske [:Dolske]]

Comment on attachment 8531030 [details]
MozReview Request: bz://1104921/MattN

[Triage Comment]


Needed for Fx35 Hello tour, no unusual risk. (And basically all the changes here are constrained to UITour.jsm)

Comment 14

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/400155de9bb8

Comment 15

[Matthew N. [:MattN]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4c185bb7218d

Comment 17

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1104921 - UITour: Add Loop panel targets. r=Unfocused