Closed Bug 1080943 Opened 5 years ago Closed 5 years ago

UITour: allow opening the Hello panel

Categories

(Firefox :: General, defect)

defect
Not set
Points:
5

Tracking

()

RESOLVED FIXED
Firefox 37
Iteration:
37.1
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: Dolske, Assigned: MattN)

References

Details

Attachments

(1 file, 1 obsolete file)

The tour page will need to open the Hello panel in two cases:

1) If we have a standalone whatsnew page, the first step would be to open the panel (to point out the New Room button)

2) If the user switches tabs, upon switching back to the tour tab the Hello panel should reopen.

In the normal case this wouldn't be needed, since the tour is launched from the panel and it can keep itself open.

API tbd. Maybe the page should just indicate when it wants the panel open/closed (state based), and UITour handles (re)opening it as needed?
Duplicate of this bug: 1055283
(Quoting Matthew N. [:MattN] from bug 1055283 comment #1)
> Alex and I were thinking of using showMenu("loop") for this.

(Quoting Alex Gibson [:agibson] from bug 1055283 comment #2)
> Also we need to make sure we can close it using hideMenu - thanks.
No longer blocks: 1098620
/r/889 - Bug 1080943 - WIP: UITour: allow opening the Hello panel and annotating inside it.

Pull down this commit:

hg pull review -r 72ce3f9b31f9026e22f0f34394e52c8f12d81571
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Iteration: --- → 36.3
Points: --- → 5
Flags: qe-verify-
Flags: firefox-backlog+
/r/889 - Bug 1080943 - WIP: UITour: allow opening the Hello panel and annotating inside it.

Pull down this commit:

hg pull review -r e0f4fe0c57e121afb74dbb77754746ce1774a819
Iteration: 36.3 → 37.1
/r/889 - Bug 1080943 - UITour: Allow opening the Hello panel. r=dolske

Pull down this commit:

hg pull review -r 6b2d0ca47589dd2970f6a2d720d7342be4640b0b
/r/889 - Bug 1080943 - UITour: Allow opening the Hello panel. r=dolske

Pull down this commit:

hg pull review -r 6b2d0ca47589dd2970f6a2d720d7342be4640b0b
Attachment #8526866 - Flags: review?(bmcbride) → review+
https://reviewboard.mozilla.org/r/887/#review601

::: browser/base/content/browser-loop.js
(Diff revision 3)
> +      let deferred = Promise.defer();

.defer() is obsolete - we shouldn't be adding any more uses of it. Use |new Promise| instead.
https://hg.mozilla.org/mozilla-central/rev/5994d92115ac
https://hg.mozilla.org/mozilla-central/rev/2bb476f9857a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Comment on attachment 8526866 [details]
MozReview Request: bz://1080943/MattN

[Triage Comment]

Needed for Fx35 Hello tour, no unusual risk.
Attachment #8526866 - Flags: approval-mozilla-beta+
Attachment #8526866 - Flags: approval-mozilla-aurora+
Attachment #8526866 - Attachment is obsolete: true
Attachment #8618400 - Flags: review+
You need to log in before you can comment on or make changes to this bug.