1105212 - [FFOS2.0][Woodduck][USSD]The USSD Notification message can't pop up in the communication interface.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Description

[sync-1]

Created an attachment (id=1041547)
 MTKLOG about case ussd04364
 
 DEFECT DESCRIPTION:
 >The USSD Notification message can't pop up in the communication interface.
 
  REPRODUCING PROCEDURES:
 Test in the lab
 
 1.Set up a communication.
 2.Receive a USSD Notification message in the communication interface,and the message display on the status bar.-->KO
 
  EXPECTED BEHAVIOUR:
 The USSD Notification message should pop up in the communication interface.
 
 Note:run the case:ussd04364 in the lab:MS receive 5 ussd notification message during the communication,and the second one can pop up,others can't,please refer to the attachment for the mtklog.
 
 >office number:0752-2639346
 
  ASSOCIATE SPECIFICATION:
  TEST PLAN REFERENCE:
  TOOLS AND PLATFORMS USED:
  USER IMPACT:
  REPRODUCING RATE:
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Attachment: MTKLOG about case ussd04364

Comment 2

[shawn ku [:sku]]

Hi Luke:
 looks like this issue was handled by you and chens. please help check first.
Thanks!!
Shawn

Comment 3

[Sherman Chen [:chens] (inactive)]

Hi reporter, 

Can you elaborate your reproduce steps? We need to clarify things before looking into it.
What is 'Set up a communication' in your step 1? And for step 2, is that means receive an USSD notification message when dialer app is opened and in foreground?

Comment 4

[sync-1]

(In reply to comment #2)
 > Is that means receive an USSD notification message when dialer app is not
 > opened or in background?
 
 Whatever the dialer app is opened or in background, the USSD notification
 message should pop up.

Comment 5

[Sherman Chen [:chens] (inactive)]

Attachment: wip - add dialer log

Hi reporter, 

This patch adds some logs to dialer app and can help us identifying the problem, can you test it again with this patch and share the logs? thanks.

Comment 6

[sync-1]

Created an attachment (id=1043014)
 mtklog_20141127_1455

Comment 7

[sync-1]

Created an attachment (id=1043014)
 mtklog_20141127_1455

Comment 8

[sync-1]

Attachment: mtklog_20141127_1455

Created an attachment (id=1043014)
 mtklog_20141127_1455

Comment 9

[sync-1]

(In reply to comment #4)
 > Comment from Mozilla:Hi reporter, 
 > This patch adds some logs to dialer app and can help us identifying the
 > problem, can you test it again with this patch and share the logs? thanks.
 
 The logs uploaded, see the attachment "mtklog_20141127_1455". Thanks.

Comment 10

[Sherman Chen [:chens] (inactive)]

Here's the result from log :

E GeckoConsole: Content JS LOG at app://communications.gaiamobile.org/dialer/js/dialer.js:696 in onUssdReceived: [Dialer] [dialer.js] dialer not visible and session ended
E GeckoConsole: Content JS LOG at app://communications.gaiamobile.org/dialer/js/mmi.js:363 in mm_sendNotification: [Dialer] [mmi.js] sendNotification()
E GeckoConsole: Content JS LOG at app://communications.gaiamobile.org/dialer/js/mmi.js:391 in mm_sendNotification/</</request.onsuccess/<: [Dialer] [mmi.js] Notification sent

And this is expected behavior by design [1]. If the dialer is not visible and the session ends with this message, it will show notification instead of bring dialer app up. Because it's not likely for user to interact with an already ended message session.

[1] https://github.com/mozilla-b2g/gaia/blob/v2.0m/apps/communications/dialer/js/dialer.js#L454-L464

Comment 12

[Sherman Chen [:chens] (inactive)]

I'm going to mark it as an invalid one, please reopen if you have any concern.

Comment 13

[sync-1]

(In reply to comment #10)
 
 > And this is expected behavior by design [1]. If the dialer is not visible 
 > and the session ends with this message, it will show notification 
 > instead of bring dialer app up. Because it's not likely for user 
 > to interact with an already ended message session.
 
 请关注下Note中所说的情况。

Comment 14

[sync-1]

The second one can pop up, others just display on the status bar. 
 The message can pop up after we click it, but it hide by the communication quickly that we can't see the message content.

Comment 15

[Sherman Chen [:chens] (inactive)]

Attachment: wip - add dialer and system log

Hi reporter, 

Can you test it again with this patch and share the logs? thanks.

Comment 16

[sync-1]

Created an attachment (id=1044156)
 mtklog_20141128_0955

Comment 17

[sync-1]

Created an attachment (id=1044156)
 mtklog_20141128_0955

Comment 18

[sync-1]

Attachment: mtklog_20141128_0955

Created an attachment (id=1044156)
 mtklog_20141128_0955

Comment 19

[sync-1]

(In reply to comment #15)
 > Comment from Mozilla:Hi reporter, 
 > Can you test it again with this patch and share the logs? thanks.
 
 The logs uploaded, see the attachment "mtklog_20141128_0955". Thanks.
 
 We had run the case two times. 
 First time, the second and third one can pop up.
 Second time, only the second one can pop up.

Comment 20

[Sherman Chen [:chens] (inactive)]

Hi reporter,

Can you elaborate how many USSD notification you sent and what's the problem you have? 
I've seen the log and can't see any issue in it.

Comment 21

[sync-1]

(In reply to comment #20)
 > Comment from Mozilla:Hi reporter,
 > Can you elaborate how many USSD notification you sent and what's the problem
 > you have? 
 > I've seen the log and can't see any issue in it.
 
 Note:run the case:ussd04364 in the lab:MS receive 5 ussd notification message
 during the communication,and the second one can pop up,others can't.
 
 The issue is that we can not see the usse notification message, because it will
 hide by communication quickly.
 
 This morning I also had make the video, please visit the link.
 
 http://pan.baidu.com/s/1mgxE14k
 
 oa8k

Comment 22

[Sherman Chen [:chens] (inactive)]

Videos in comment 21 are uploaded to Youtube [1][2]. From the video and logs, it's normal to show notification and USSD message, but we may need to discuss what is the expected behavior when receiving one or more USSD messages during phone call. And also I'm not sure if it's reasonable to receive multiple USSD messages. Gabriele, how do you think?

[1]: http://youtu.be/lEM3y1D57qQ
[2]: http://youtu.be/jHiyotIUc8w

Comment 23

[Gabriele Svelto [:gsvelto] (PTO)]

(In reply to Sherman Chen [:chens] from comment #22)
> Videos in comment 21 are uploaded to Youtube [1][2]. From the video and
> logs, it's normal to show notification and USSD message, but we may need to
> discuss what is the expected behavior when receiving one or more USSD
> messages during phone call. And also I'm not sure if it's reasonable to
> receive multiple USSD messages. Gabriele, how do you think?
> 
> [1]: http://youtu.be/lEM3y1D57qQ
> [2]: http://youtu.be/jHiyotIUc8w

The issue shown in the video where the message flashes for a second and then the callscreen hides it again should be fixed IMHO. As for receiving multiple unsolicited USSD messages the current behavior is the following:

- If you're in the dialer the messages is shown (IIRC) so if you have a few messages in rapid sequence some might be shown only very briefly.

- If you're outside of the dialer we'll post a notification for each message so the user is able to see them one by one by tapping on the notifications.

Comment 24

[sync-1]

(In reply to comment #18)
 > Comment from Mozilla:Hi reporter,
 > Can you elaborate how many USSD notification you sent and what's the problem
 > you have? 
 > I've seen the log and can't see any issue in it.
 
 Note:run the case:ussd04364 in the lab:MS receive 5 ussd notification message
 during the communication,and the second one can pop up,others can't.
 
 The issue is that we can not see the usse notification message, because it will hide by communication quickly.
 
 This morning I also had make the video, I will provide later.

Comment 25

[sync-1]

Hi Mozilla,
 
 Is there any update?

Comment 26

[Josh Cheng [:josh]]

Hi Reporter, 
You said you will provide video per comment 24. Can you provide it?

Comment 27

[Josh Cheng [:josh]]

Hi Chens,
any update? Thanks!

Comment 28

[ruihua.zhang]

(In reply to Josh Cheng [:josh] from comment #26)
> Hi Reporter, 
> You said you will provide video per comment 24. Can you provide it?

Comment 24 is an error synchronization between two bugzilla system. Please see the comment 21.

Comment 29

[Sherman Chen [:chens] (inactive)]

Attachment: WIP - Don't show callscreen when dialer goes foreground

Hi reporter, 

Can you try this patch and test again? It would be better if you provide the video during test. Thanks!

Comment 30

[sync-1]

(In reply to comment #29)
 > Comment from Mozilla:Hi reporter, 
 > Can you try this patch and test again? It would be better if you provide the
 > video during test. Thanks!
 
 Test result video:
 
 http://pan.baidu.com/s/1kTMJoBP
 
 sc3w
 
 
 Is there any possible, make MS auto back to the callscreen after we close the ussd message?

Comment 31

[Sherman Chen [:chens] (inactive)]

Attachment: WIP - Hide callscreen when USSD message comes

Hi reporter, 

Could you try this patch and see if this help?

Comment 32

[Sherman Chen [:chens] (inactive)]

(In reply to sync-1 from comment #30)
>  Test result video:
>  http://pan.baidu.com/s/1kTMJoBP 
>  sc3w

Test result video on youtube: http://youtu.be/asSARRP7osY

Comment 33

[sync-1]

(In reply to comment #31)
 > Comment from Mozilla:Hi reporter, 
 > Could you try this patch and see if this help?
 
 Only this patch or base on the last patch?

Comment 34

[Sherman Chen [:chens] (inactive)]

(In reply to sync-1 from comment #33)
>  Only this patch or base on the last patch?

Only this patch, can you try again and share video if possible?

Comment 35

[sync-1]

(In reply to comment #34)
 > Comment from Mozilla:(In reply to sync-1 from comment #33)
 > >  Only this patch or base on the last patch?
 > Only this patch, can you try again and share video if possible?
 
 OK, I will try this patch and share the video tomorrow.

Comment 36

[sync-1]

(In reply to comment #34)
 > Comment from Mozilla:(In reply to sync-1 from comment #33)
 > >  Only this patch or base on the last patch?
 > Only this patch, can you try again and share video if possible?
 
 
 One question, is this patch compatible the patch of bug 1105124?
 
 >  ****************************************************
 >     closeWindow: function mui_closeWindow() {
 >       window.postMessage({
 >         type: 'mmi-cancel'
 >       }, this.COMMS_APP_ORIGIN);
 >  +    this.resetResponse();
 >       this.mmiScreen.hidden = true;
 >     },
 >  ****************************************************

Comment 37

[Sherman Chen [:chens] (inactive)]

These two are different patches and has nothing to do with bug 1105124, what's your concern?

Comment 38

[sync-1]

(In reply to comment #37)
 > Comment from Mozilla:These two are different patches and has nothing to do with
 > bug 1105124, what's your concern?
 
 I just want to make sure that the patch of bug 1105124 will not affect the test. Because patch of bug 1105124 had merged into our codebase.

Comment 39

[Sherman Chen [:chens] (inactive)]

As described in comment 37 these are two different things, bug 1105124 won't have any impact.

Comment 40

[sync-1]

(In reply to comment #34)
 > Comment from Mozilla:(In reply to sync-1 from comment #33)
 > >  Only this patch or base on the last patch?
 > Only this patch, can you try again and share video if possible?
 
 Test result video on baidupan:
 
 http://pan.baidu.com/s/1kTMJpHI
 pv49
 
 It's seems regression, the VAL suggestion to use the last patch firstly and you can make some optimization on later version. What do you think?

Comment 41

[Sherman Chen [:chens] (inactive)]

I can't access the link, could you check again? 

And I don't get what 'regression' means. Could you explain this? does these two patches solve the issue?

Comment 42

[sync-1]

(In reply to comment #41)
 > Comment from Mozilla:I can't access the link, could you check again? 
 > And I don't get what 'regression' means. Could you explain this? does these two
 > patches solve the issue?
 
 Sorry, I means that the message flashes for a second and then the callscreen hides it again on this patch (attachment 8534208 [details] [review]). So we suggest to use the last patch (attachment 8534083 [details] [review]) firstly.

Comment 43

[Sherman Chen [:chens] (inactive)]

OK, but I'm still not able to access the link you shared in comment 40. It give 404 error and could you check the link? I would like to see how it works.

Comment 44

[sync-1]

 http://pan.baidu.com/s/1kTMJpHl
 pv49

Comment 45

[sync-1]

I will merge the last patch (attachment 8534083 [details] [review]) into our codebase. Is there any update? Thanks!

Comment 46

[Sherman Chen [:chens] (inactive)]

Nothing new updates, but I'm going to ask for review or feedback from module owner.

Comment 47

[Sherman Chen [:chens] (inactive)]

Comment on attachment 8534083 [details] [review]
WIP - Don't show callscreen when dialer goes foreground

Hi Alive, 

Current situation is we are not able to see USSD message during phone call because callscreen will block it, and we can't hide callscreen either. How do you think if we don't show callscreen when launching dialer app during phone call? Is there any side effect we don't show it?

Comment 48

[Josh Cheng [:josh]]

Hi Chens,
Can you provide an ETA date? Thanks!

Comment 49

[Sherman Chen [:chens] (inactive)]

Can't say an exact date because we are still waiting for module owner's review to see if there's side effect to do this.

Comment 50

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8534083 [details] [review]
WIP - Don't show callscreen when dialer goes foreground

Sorry for late.

Comment 51

[(inactive after 6/18) Alive Kuo [:alive]]

I don't think this affects v2.1 & v2.2, could you please check again?

Comment 52

[Sherman Chen [:chens] (inactive)]

Thanks Alive :) 
2.0m: https://github.com/mozilla-b2g/gaia/commit/ece2b19fe5bc73dbee1974df0d670b89032f3e6d

Clearing Josh's ni, it doesn't affect 2.1 and 2.2.

Comment 53

[sync-1]

Dear Dengwei,
 
 这个问题已解决，对应的内部PR，测试部已经验证通过并关闭了，请关闭此PR，谢谢！