1105537 - Add strings in preparation for upcoming Loop improvements

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

There's a few improvements we want in 36, that we need a few strings for. We'll add them now to make sure they get in, and follow up with the patches soon after.

Comment 1

[Mark Banner (:standard8)]

Attachment: Add string in prepartion for upcoming Loop improvements.

This adds the necessary strings for the bugs this blocks. There's an additional string for "Phone" as the decision hasn't quite been made for now which we want to go for.

Comment 2

[Mark Banner (:standard8)]

Attachment: Add string in prepartion for upcoming Loop improvements.

With improvements to contact import failure messages.

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8529340 [details] [diff] [review]
Add string in prepartion for upcoming Loop improvements.

Review of attachment 8529340 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/loop/loop.properties
@@ +315,5 @@
>  rooms_list_delete_tooltip=Delete conversation
>  rooms_list_deleteConfirmation_label=Are you sure?
>  rooms_list_no_current_conversations=No current conversations
>  rooms_name_this_room_label=Name this conversation
> +rooms_name_this_room_tooltip=Click to edit room name

I guess we didn't go with "Click to rename" because this includes when you are naming for the first time?

I personally prefer including "the": 
  Click to edit the room name

@@ +325,5 @@
>  rooms_room_full_call_to_action_nonFx_label=Download {{brandShortname}} to start your own
>  rooms_room_full_call_to_action_label=Learn more about {{clientShortname}} »
>  rooms_room_joined_label=Someone has joined the conversation!
>  rooms_room_join_label=Join the conversation
> +rooms_signout_alert=This will close any open conversations

Without seeing the context the "This" here feels weird to me. Also, I think it should be "all" instead of "any". Do we also close non-FxA rooms? The following seems better (though again, I don't know the full context):

Open conversations will be closed

Comment 4

[Mark Banner (:standard8)]

Attachment: Add string in prepartion for upcoming Loop improvements.

Updated for feedback.

Comment 5

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/30de9d876213

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/30de9d876213

Comment 7

[Francesco Lodolo [:flod]]

Comment on attachment 8529359 [details] [diff] [review]
Add string in prepartion for upcoming Loop improvements.

Review of attachment 8529359 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/loop/loop.properties
@@ +305,5 @@
>  rooms_list_delete_tooltip=Delete conversation
>  rooms_list_deleteConfirmation_label=Are you sure?
>  rooms_list_no_current_conversations=No current conversations
>  rooms_name_this_room_label=Name this conversation
> +rooms_name_this_room_tooltip=Click to edit the room name

This doesn't look right, considering that all other strings talk about "conversations", not "rooms".

Comment 8

[Francesco Lodolo [:flod]]

Mark, slipped through the cracks or expected?

Comment 9

[Mark Banner (:standard8)]

Thanks, that had slipped through the cracks. Landed a new string:

https://hg.mozilla.org/integration/fx-team/rev/c9b224de1af0

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c9b224de1af0