If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add strings in preparation for upcoming Loop improvements

RESOLVED FIXED in Firefox 36

Status

Hello (Loop)
Client
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla36
Points:
1
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox35 affected, firefox36 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

3 years ago
There's a few improvements we want in 36, that we need a few strings for. We'll add them now to make sure they get in, and follow up with the patches soon after.
(Assignee)

Comment 1

3 years ago
Created attachment 8529340 [details] [diff] [review]
Add string in prepartion for upcoming Loop improvements.

This adds the necessary strings for the bugs this blocks. There's an additional string for "Phone" as the decision hasn't quite been made for now which we want to go for.
Attachment #8529340 - Flags: review?(jaws)
(Assignee)

Comment 2

3 years ago
Created attachment 8529352 [details] [diff] [review]
Add string in prepartion for upcoming Loop improvements.

With improvements to contact import failure messages.
Attachment #8529340 - Attachment is obsolete: true
Attachment #8529340 - Flags: review?(jaws)
Attachment #8529352 - Flags: review?(MattN+bmo)
Comment on attachment 8529340 [details] [diff] [review]
Add string in prepartion for upcoming Loop improvements.

Review of attachment 8529340 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/loop/loop.properties
@@ +315,5 @@
>  rooms_list_delete_tooltip=Delete conversation
>  rooms_list_deleteConfirmation_label=Are you sure?
>  rooms_list_no_current_conversations=No current conversations
>  rooms_name_this_room_label=Name this conversation
> +rooms_name_this_room_tooltip=Click to edit room name

I guess we didn't go with "Click to rename" because this includes when you are naming for the first time?

I personally prefer including "the": 
  Click to edit the room name

@@ +325,5 @@
>  rooms_room_full_call_to_action_nonFx_label=Download {{brandShortname}} to start your own
>  rooms_room_full_call_to_action_label=Learn more about {{clientShortname}} ยป
>  rooms_room_joined_label=Someone has joined the conversation!
>  rooms_room_join_label=Join the conversation
> +rooms_signout_alert=This will close any open conversations

Without seeing the context the "This" here feels weird to me. Also, I think it should be "all" instead of "any". Do we also close non-FxA rooms? The following seems better (though again, I don't know the full context):

Open conversations will be closed
Attachment #8529340 - Attachment is obsolete: false
Attachment #8529340 - Flags: feedback+
Attachment #8529340 - Attachment is obsolete: true
(Assignee)

Comment 4

3 years ago
Created attachment 8529359 [details] [diff] [review]
Add string in prepartion for upcoming Loop improvements.

Updated for feedback.
Attachment #8529352 - Attachment is obsolete: true
Attachment #8529352 - Flags: review?(MattN+bmo)
Attachment #8529359 - Flags: review?(MattN+bmo)
Attachment #8529359 - Flags: review?(MattN+bmo) → review+
(Assignee)

Comment 5

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/30de9d876213
Iteration: --- → 37.1
Points: --- → 1
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → mozilla36
backlog: --- → Fx35+
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/30de9d876213
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Comment on attachment 8529359 [details] [diff] [review]
Add string in prepartion for upcoming Loop improvements.

Review of attachment 8529359 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/loop/loop.properties
@@ +305,5 @@
>  rooms_list_delete_tooltip=Delete conversation
>  rooms_list_deleteConfirmation_label=Are you sure?
>  rooms_list_no_current_conversations=No current conversations
>  rooms_name_this_room_label=Name this conversation
> +rooms_name_this_room_tooltip=Click to edit the room name

This doesn't look right, considering that all other strings talk about "conversations", not "rooms".
Mark, slipped through the cracks or expected?
Flags: needinfo?(standard8)
(Assignee)

Comment 9

3 years ago
Thanks, that had slipped through the cracks. Landed a new string:

https://hg.mozilla.org/integration/fx-team/rev/c9b224de1af0
Flags: needinfo?(standard8)
https://hg.mozilla.org/mozilla-central/rev/c9b224de1af0
status-firefox35: --- → affected
status-firefox36: --- → fixed
Flags: qe-verify-
(Assignee)

Updated

3 years ago
Blocks: 1122471
You need to log in before you can comment on or make changes to this bug.