1105696 - (status-bar-rtl) [RTL] Rocketbar doesn't work on RTL languages

Status: VERIFIED DUPLICATE of bug 1033917

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Alberto Pastor [:albertopq]]

STR:

1.- Set up the phone with a RTL language
2.- Open Settings
3.- Click on the rocketbar

Expected:

The rocketbar should open

Actual

Does nothing

Comment 1

[Alberto Pastor [:albertopq]]

Attachment: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26609

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8531685 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26609

I think we need to check a different element. Re-flag me when ready.

Comment 3

[Alberto Pastor [:albertopq]]

Comment on attachment 8531685 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26609

Thanks!

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8531685 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26609

Seems good to me. Thanks!

Comment 5

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/f7960774b873997a1178ce46855f6605addff020

Comment 6

[Alberto Pastor [:albertopq]]

backout: https://github.com/mozilla-b2g/gaia/commit/350ab351653d77de9030c520aea1108966c1f1d0

Comment 7

[Jeremiah Lee]

I see Rocketbar working on Flame 2.2, but the "hitbox" stays on default left side (area where Rocketbar was located before RTL). Tapping area to left of Rocketbar (not on search box) will open rocketbar.

Comment 8

[bhavana bajaj [:bajaj]]

NI : Alberto, not sure why this was backed out, if its close to getting done, can we please get this re-landed on master and uplifted on 2.2 as well ? Thanks!

Comment 9

[Alberto Pastor [:albertopq]]

Now that RTL is a priority again, I'll take it next. Should be done this week. Thanks!

Comment 10

[Alberto Pastor [:albertopq]]

It seems that this has been already fixed by 1033917. I tested it in both master and 2.2 and is working fine.

Comment 11

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15555/

Comment 12

[Lancy(Leave from Mozilla)]

Per comment 10 and my own verification, this bug is fixed now, Click on the rocketbar in Settings, rocketbar is opened and the hit text is right-aligned.
so I mark it as “VERIFIED DUPLICATE”.

Device information:
Flame KK v2.2 build ID:20150730032503
Flame KK V2.5 build ID: 20150730150205
N5 v2.2 build ID:20150730032503
N5 v2.5 build ID:20150730150205