1120641 - Add tests for the default search engine header added to the search suggestions popup

Status: RESOLVED FIXED

(Firefox :: Search, task, P4)

Comment 1

[Florian Quèze [:florian]]

I'm not sure if the headers here are the line at the top of the search panel with the current default engine, or the line saying "Search for <keyword> with:" (or maybe both?), but if it's the later, we added tests in bug 1110767.

Comment 2

[Dave Townsend [:mossop]]

You defined it in bug 1107178 comment 2 ;)

Sounds like we just need a test for the default search engine header now.

Comment 3

[Chris]

I'd be interested in taking a look into this, it looks like we need to test that the icon URI matches what is stored in the default engine's icon URI, and that the message is properly displayed as "<Engine Name> Search.

Is it possible to have a search engine that doesn't have an icon?  And if so, then what icon URI is displayed instead?  Also is it possible for a search engine to be an empty string?

Comment 4

[Florian Quèze [:florian]]

(In reply to Chris from comment #3)
> I'd be interested in taking a look into this, it looks like we need to test
> that the icon URI matches what is stored in the default engine's icon URI,
> and that the message is properly displayed as "<Engine Name> Search.

We should probably also check that clicking that header starts a search.

> Is it possible to have a search engine that doesn't have an icon?

Yes. In that case a generic search icon is displayed instead.

> Also is it possible for a search engine to be an empty string?

I hope it's not, but I've never checked.

Comment 5

[Chris]

> > Also is it possible for a search engine to be an empty string?
>
> I hope it's not, but I've never checked.

It might be better to add a test for this case here: http://mxr.mozilla.org/mozilla-central/source/toolkit/components/search/tests/xpcshell/ as part of a possible followup bug if we can verify that adding an engine with an empty name is invalid behavior (It looks like it is).

Comment 6

[Mark Banner (:standard8)]

Bug 1904014 is adding a test that tests the header in the popup.

Comment 7

[Mark Banner (:standard8)]

Fixed by bug 1904014.