1108187 - Temporarily remove Hello button from private browsing windows whilst we decide how to handle private browsing mode

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect)

Description

[antispam]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.71 Safari/537.36

Steps to reproduce:

1. open a Private Browsing window and close all your other firefox windows

2. use Firefox Hello widget to send someone a link to call you

3. they call you

4. you hear a ringing sound but see no way to answer their call

(I was in private browsing mode by accident and this was my first time trying Firefox Hello, so it was particularly confusing for me!  Tested on Linux.)



Expected results:

Considering https://bugzilla.mozilla.org/show_bug.cgi?id=1005019 , I don't know what *should* happen exactly.  Either you should be able to answer the call, or Firefox should tell you at some point in this process that you screwed up.

Comment 1

[antispam]

actual user agent: Mozilla/5.0 (X11; Linux x86_64; rv:34.0) Gecko/20100101 Firefox/34.0

Comment 2

[u279076]

Thanks for the bug report. I think we'll need a resolution to bug 1005019 before evaluating this report. If you have any specific thoughts on how Hello should work in Private Browsing, please add a comment to bug 1005019.

Comment 3

[Mark Banner (:standard8)]

I just tested this locally, to clarify: The incoming window is displayed in a non-private browsing window - its just not the one that's the focus, as you'd expect from the STRs in comment 0.

As already commented, bug 1005019 is likely needed before we can resolve this.

Comment 4

[antispam]

Mark Banner: Correct... if you *have* any non-private browsing windows!

Comment 5

[:shell escalante]

backlog for PM discussion pending bug 1005019

Comment 6

[Paul Silaghi, QA [:pauly]]

(In reply to antispam from comment #4)
> Mark Banner: Correct... if you *have* any non-private browsing windows!
Nothing shows up if you don't have a non-private window open.
Console log: "Failed to open a chat window - no host window could be found."

Comment 7

[Adam Roach [:abr]]

(In reply to Paul Silaghi, QA [:pauly] from comment #6)
> (In reply to antispam from comment #4)
> > Mark Banner: Correct... if you *have* any non-private browsing windows!
> Nothing shows up if you don't have a non-private window open.
> Console log: "Failed to open a chat window - no host window could be found."

This brings to mind -- the handling here should take Bug 1031439 into account: there will almost certainly be some commonality between handling when all windows are closed and handling when all non-private windows are closed.

Comment 8

[Mark Banner (:standard8)]

Attachment: Hide Loop's toolbar button in private browsing mode as Loop doesn't work fully in it yet.

We discussed this a bit yesterday, and decided that we should - for now at least - hide the Loop button in private browsing mode. This is because it doesn't work properly, i.e. it doesn't open the chat window.

Whilst we could open a chat window in a private browsing window/mode, there's concerns about how Loop and private browsing relate which we haven't resolved yet - bug 1005019 will take a look at resolving those.

In the meantime, users are hitting this, and for other bugs I need to make adjustments to how the chat window opening works, so disabling the button is the best intermediate thing I think we can do.

Here's a simple patch to do that along with a test.

Comment 9

[Mike de Boer [:mikedeboer]]

Comment on attachment 8572525 [details] [diff] [review]
Hide Loop's toolbar button in private browsing mode as Loop doesn't work fully in it yet.

Review of attachment 8572525 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the unit test removed.

Since you're only using the `showInPrivateBrowsing` flag, we can rely on the CustomizableUI test coverage here. I'm sorry for 'nullifying' your effort here :/

Comment 10

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/7d5778f86884

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7d5778f86884

Comment 12

[Mark Banner (:standard8)]

[Tracking Requested - why for this release]: Moving tracking from bug 1123132 as that's just about to be duped here.

This is a confusing issue for users and we haven't fully resolved what to do in private browsing mode, so we're disabling it for now in private browsing to remove the confusion.

Comment 14

[Mark Banner (:standard8)]

Comment on attachment 8572525 [details] [diff] [review]
Hide Loop's toolbar button in private browsing mode as Loop doesn't work fully in it yet.

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello
[User impact if declined]: Users are getting confused as to why the Hello button is available in private browsing mode, but then it doesn't work.
[Describe test coverage new/current, TreeHerder]: Using existing flag for the button that's already tested and has been used.
[Risks and why]: Low, see user impact
[String/UUID change made/needed]: None

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8572525 [details] [diff] [review]
Hide Loop's toolbar button in private browsing mode as Loop doesn't work fully in it yet.

Approving this for aurora and beta. We are planning to ship 37 with the button disabled.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/998bbb1255f7

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d6b0db94153e

Comment 18

[Lawrence Mandel [:lmandel] (use needinfo)]

Note that this bug missed 37 Beta 3. IT will be included in 37 Beta 4.

Comment 19

[Lawrence Mandel [:lmandel] (use needinfo)]

Tracking as this is a poor UX and want to be alerted if this bug is reopened for any reason.

Comment 20

[Vasilica Tamas, QA [:vtamas]]

I understand from the above comments that the purpose of this bug is to remove the Hello Button out of Private Window toolbar. 

I verified this and the Hello Button is not displayed in Private Window on Firefox 40.0a1 (2015-04-02), Firefox 39.0a2 (2015-04-03), Firefox 38 Beta 1 (20150330154247) and Firefox 37.0.1 (20150402191859) using Windows 8.1 32-bit and Ubuntu 14.04 32-bit.

If I am right, Mark, can you please update the summary in order to reflect the purpose of this bug?

Comment 21

[Mark Banner (:standard8)]

Yep, updated.

Comment 22

[Vasilica Tamas, QA [:vtamas]]

Thanks Mark!

Marking this bug as Verified based on the above mentioned and on a recent testing on Firefox 40.0a1 (2015-04-20), Firefox 39.0a2 (2015-04-20), Firefox 38 Beta 6 (20150420134330) and Firefox 37.0.2 (20150415140819) using Windows 7 64-bit.