Closed Bug 1108302 Opened 5 years ago Closed 5 years ago

Menulists in the in-content preferences have too much padding at the start of their contents

Categories

(Firefox :: Preferences, defect, P1)

37 Branch
x86
macOS
defect
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 38
Iteration:
38.3 - 23 Feb
Tracking Status
firefox38 --- fixed

People

(Reporter: ori, Assigned: jaws)

References

Details

(Whiteboard: [good first bug][lang=css])

Attachments

(2 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:37.0) Gecko/20100101 Firefox/37.0
Build ID: 20141206030202

Steps to reproduce:

Click "Nightly" → "Preferences..." → "Content"


Actual results:

Under "Fonts & Colors", the select list for the default font size shows an ellipsis instead of the selected value (16, in my case).


Expected results:

Because the font size is almost always a two-digit number, the select list should be wide enough to display two-digit values without collapsing them to an ellipsis.
Component: Untriaged → Preferences
It's fine with Win 7 and Nightly. It could be OSX-specific or DPI-dependant. Did you test with a clean profile?
https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles
Flags: needinfo?(ori)
WFM on nightly 37.0a1 (2014-12-07) OS X 10.9.5.
(In reply to Paul Silaghi, QA [:pauly] from comment #2)
> WFM on nightly 37.0a1 (2014-12-07) OS X 10.9.5.

Ditto for me on today's... tentatively marking WFM. Ori, please let us know if you still see this and try to provide more information about the environment where you see this...
Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
... and then I saw it again myself today (on OS X). :-\
Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: WORKSFORME → ---
I think making the dropdown wider will be an easy fix for this.
Points: --- → 1
Whiteboard: [good first bug][lang=css]
Mentor: jaws
Hi Jared, this would be my first bug in Firefox, could you please tell me where the changes need to be made?
Flags: needinfo?(jaws)
Hi Tanay, thanks for requesting to work on this bug.

The root issue here is that menulists that are missing an icon still have an extra 5px of margin-end applied to where the icon would be placed had it been provided.

If we only apply the margin when the icon is provided, this issue will be fixed and potentially other issues that are similar in symptom will also be fixed.

At http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css?rev=666746987b4b#207, we can change the following line:
xul|menulist > xul|*.menulist-label-box > xul|*.menulist-icon {
to
xul|menulist > xul|*.menulist-label-box > xul|*.menulist-icon[src] {

Doing this change would make the margin only apply when the src value is supplied. This fixes the issue in my testing.
Assignee: nobody → tanay1337
Status: REOPENED → ASSIGNED
Flags: needinfo?(ori)
Flags: needinfo?(jaws)
Bug 1013695 can also be handled here in my opinion.
Other locations this affects:

General -> When &brandShortName; starts:
Content -> Fonts & Colors -> Advanced… (ignoring font dimensions already mentioned in this bug)
Privacy -> Accept third-party cookies:, Keep until:

See https://bug1128173.bugzilla.mozilla.org/attachment.cgi?id=8557504 for a screenshot.
Summary: Font size select list shows ellipsis instead of selected value → Menulists in the in-content preferences have too much padding at the start of their contents
Attached patch PatchSplinter Review
Tanay, can you apply the patch and see if this fixes the issue for you?
Flags: needinfo?(jaws)
Attachment #8563426 - Flags: review?(gijskruitbosch+bugs)
Attachment #8563426 - Flags: feedback?(tanay1337)
Attachment #8563426 - Flags: review?(gijskruitbosch+bugs) → review+
Assignee: tanay1337 → jaws
Iteration: --- → 38.3 - 23 Feb
Flags: qe-verify-
Flags: firefox-backlog+
https://hg.mozilla.org/integration/fx-team/rev/9fd93e84a01d
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: [good first bug][lang=css] → [good first bug][lang=css][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/9fd93e84a01d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][lang=css][fixed-in-fx-team] → [good first bug][lang=css]
Target Milestone: --- → Firefox 38
You need to log in before you can comment on or make changes to this bug.