large Windows font size causes unexpected margins above one-off search items

VERIFIED FIXED in Firefox 35

Status

()

VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: ws.bugzilla, Assigned: florian)

Tracking

Trunk
Firefox 37
x86_64
Windows 7
Points:
1
Bug Flags:
firefox-backlog +
qe-verify +

Firefox Tracking Flags

(firefox34 wontfix, firefox35+ verified, firefox36+ verified, firefox37 verified)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Created attachment 8533413 [details]
screenshot

The new search bar suggestions list is cut off at the bottom; see screenshot.

I have a larger window font size specified in the Windows font size settings; I suspect this is the cause.
Blocks: 1088660
(Assignee)

Updated

4 years ago
Summary: New search drop-down is cut off → large Windows font size causes unexpected margins above one-off search items
(Assignee)

Comment 1

4 years ago
Created attachment 8533733 [details] [diff] [review]
Fix

For some reason, a larger default font size changes the height of the lines in the <description> node where the one-off buttons are. I don't understand why that behavior happens as there's no text there, but setting the line-height to 0 (or anything <= 18px) makes the bug disappear.
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attachment #8533733 - Flags: review?(felipc)
(Assignee)

Comment 2

4 years ago
Note for people trying to reproduce this bug: the font size settings are non-trivial to find on Windows 7. All the obvious ways to change the text size actually change the DPI setting, which increases the icon sizes at the same time and doesn't reproduce the bug.

The way I've found to change the font size (and only the font size) is to search for "color" in the Control Panel, then click on "Change window colors and metrics", and there change the "Message Box" font size (I set it to 12px).
(Assignee)

Comment 3

4 years ago
[Tracking Requested - why for this release]: the patch is trivial and the issue here may make the new search UI look really unpolished for a (hopefully small) portion of our Windows users.
status-firefox34: --- → wontfix
status-firefox35: --- → affected
status-firefox36: --- → affected
status-firefox37: --- → affected
tracking-firefox35: --- → ?
tracking-firefox36: --- → ?
Attachment #8533733 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/cf7a81a592ba
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
(Assignee)

Comment 6

4 years ago
Comment on attachment 8533733 [details] [diff] [review]
Fix

Approval Request Comment
[Feature/regressing bug #]: bug 1088660
[User impact if declined]: ugly search panel for Windows users with large fonts
[Describe test coverage new/current, TBPL]: on central
[Risks and why]: very low
[String/UUID change made/needed]: none
Attachment #8533733 - Flags: approval-mozilla-beta?
Attachment #8533733 - Flags: approval-mozilla-aurora?
Hi Florian, can you assign a point value.
Iteration: --- → 37.2
Flags: qe-verify?
Flags: needinfo?(florian)
Flags: firefox-backlog+
Flags: qe-verify? → qe-verify+
QA Contact: petruta.rasa
status-firefox37: affected → fixed
tracking-firefox35: ? → +
tracking-firefox36: ? → +
Attachment #8533733 - Flags: approval-mozilla-beta?
Attachment #8533733 - Flags: approval-mozilla-beta+
Attachment #8533733 - Flags: approval-mozilla-aurora?
Attachment #8533733 - Flags: approval-mozilla-aurora+
(Assignee)

Updated

4 years ago
Points: --- → 1
Flags: needinfo?(florian)
(Assignee)

Comment 9

4 years ago
https://hg.mozilla.org/releases/mozilla-beta/rev/fd2c78cea9f8
status-firefox35: affected → fixed
Verified on Nightly 37.0a1 2014-12-12 after setting the font size as comment 2 suggests. The suggestions looks fine now, but at a lower width of the browser, the "Change Search Settings" button is cut off.
(Assignee)

Comment 11

4 years ago
(In reply to Petruta Rasa [QA] [:petruta] from comment #10)

> at a lower width of the
> browser, the "Change Search Settings" button is cut off.

This is a different known issue (but I don't remember if we have a bug on file for it or not).
I could only find bug 1104748 which was already fixed, so I logged bug 1111638 to cover this.

The issue no longer occurs in Developer Edition 36.0a2 2014-12-15.
Status: RESOLVED → VERIFIED
status-firefox36: fixed → verified
status-firefox37: fixed → verified
(Assignee)

Comment 13

4 years ago
(In reply to Petruta Rasa [QA] [:petruta] from comment #12)
> I logged bug 1111638 to cover this.

Thanks!
Verified as fixed using Firefox 34 beta 5, Win 7 64-bit.
status-firefox35: fixed → verified
You need to log in before you can comment on or make changes to this bug.