1108992 - Refactor testAdons_installTheme from multiple files into a single file

Status: RESOLVED INVALID

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Daniela Domnici]

Combined two tests from testAddons_installTheme into one test.

Comment 1

[Daniela Domnici]

Attachment: patch_V1

Combined two tests from testAddons_installTheme into one test.

Comment 2

[Mihaela Velimiroviciu (:mihaelav)]

Comment on attachment 8533644 [details] [diff] [review]
patch_V1

Review of attachment 8533644 [details] [diff] [review]:
-----------------------------------------------------------------

The patch failed to apply successfully.
Please update the commit message and remove [include:testAddons_installTheme/manifest.ini] from firefox/tests/functional/restartTests/manifest.ini

::: firefox/tests/functional/testAddons/testInstallTheme.js
@@ +31,3 @@
>    // Whitelist add the local test folder
>    addons.addToWhiteList(BASE_URL);
>  

Extra blank line

@@ +47,5 @@
>  
>  function teardownModule(aModule) {
> +  delete persisted.nextTest;
> +  prefs.clearUserPref(PREF_INSTALL_DIALOG);
> +

Also clear the extensions.ui.lastCategory preference

@@ +86,5 @@
> +
> +    // Wait for the notification to unload
> +    locationBar.waitForNotificationPanel(panel => {
> +      panel.keypress('VK_ESCAPE', {});
> +    }, {type: "notification", open: false});

nit: indentation of lines 74 to 90

Comment 3

[Mihaela Velimiroviciu (:mihaelav)]

Actually, this test can be removed from the repo since it is covered by the uninstallTheme one. 
I logged bug 1110639 for this.