Closed Bug 1061991 Opened 5 years ago Closed 5 years ago

Stumbler: add android.permission.ACCESS_WIFI_STATE and CHANGE_WIFI_STATE to AndroidManifest.xml

Categories

(Android Background Services Graveyard :: Geolocation, defect)

Firefox 33
All
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 35

People

(Reporter: garvan, Assigned: garvan)

References

Details

Attachments

(1 file)

These permissions are off for RELEASE_BUILD:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/AndroidManifest.xml.in#28

FFox 34 is the next permissions bump, at which time those can be on.

Both are required for wifi scanning performed by the stumbler lib.
I'm fuzzy on how we decide if and when we're going to take the permissions bump.  Over to blassey, mfinkle, and the product team.
(In reply to Garvan Keeley [:garvank] from comment #0)
> These permissions are off for RELEASE_BUILD:
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/
> AndroidManifest.xml.in#28
> 
> FFox 34 is the next permissions bump, at which time those can be on.

Stumbler is the driver for this permission bump and I think we want to enable that on 35 to get a full cycle of testing. Therefore, the 35 is now our permission bump release.
That is fine. There are various loose ends that will delay it landing in 34.
Comments on that are here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1032506#c4
Karen is cool with all this pending legal review. Jishnu, I think this is yours?
Flags: needinfo?(jmenon)
Hi guys - Mika reviewed this in 1007264 - I think she was fine with it as long as it hasn't changed since then.
Depends on: 10072
Flags: needinfo?(jmenon)
Removed #ifndef RELEASE_BUILD surrounding these permissions.
This is still in discussion, but a patch in the queue never hurts.
Attachment #8499746 - Flags: review?(mark.finkle)
Attachment #8499746 - Flags: review?(mark.finkle) → review+
Keywords: checkin-needed
I attempted to land this on fx-team, but had to revert for robocop failures.
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=829506&repo=fx-team
Assignee: nobody → gkeeley
Keywords: checkin-needed
And of course, that backout should have been for bug 1007264, not this one. FML.
https://hg.mozilla.org/integration/fx-team/rev/1c61b9e36869
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/1c61b9e36869
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
These permissions are unwrapped but the confvar still checks for release channel http://mxr.mozilla.org/mozilla-aurora/source/mobile/android/confvars.sh#90 e.g, on Aurora 35
(In reply to Aaron Train [:aaronmt] from comment #10)
> These permissions are unwrapped but the confvar still checks for release
> channel
> http://mxr.mozilla.org/mozilla-aurora/source/mobile/android/confvars.sh#90
> e.g, on Aurora 35

s/release/nightly ... where Nightly is (Nightly and Aurora) right?
(In reply to Aaron Train [:aaronmt] from comment #11)
> (In reply to Aaron Train [:aaronmt] from comment #10)
> > These permissions are unwrapped but the confvar still checks for release
> > channel
> > http://mxr.mozilla.org/mozilla-aurora/source/mobile/android/confvars.sh#90
> > e.g, on Aurora 35
> 
> s/release/nightly ... where Nightly is (Nightly and Aurora) right?

Thanks for catching that, added bug 1084557
You need to log in before you can comment on or make changes to this bug.