nsHyphenator assumes wrong bool size

RESOLVED FIXED in mozilla37

Status

()

Core
Internationalization
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: spectre, Assigned: spectre)

Tracking

Trunk
mozilla37
PowerPC
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
See also bug 720350, bug 724453 and bug 724456. Without this fix, hyphenation occurs in random unpredictable (and usually incorrect) locations on systems where sizeof(bool) != sizeof(char) (PowerPC, and possibly others).
(Assignee)

Comment 1

3 years ago
Created attachment 8534730 [details] [diff] [review]
Don't assume sizeof(bool) == sizeof(char).

Hopefully correct reviewer ... please advise if not.
Attachment #8534730 - Flags: review?(VYV03354)
Really jfkthame would be the right reviewer, but I can mark it.

This is a regression from https://hg.mozilla.org/mozilla-central/rev/e7854b4d29ba .
Blocks: 675553
Attachment #8534730 - Flags: review?(VYV03354) → review+
(Assignee)

Comment 3

3 years ago
Thanks, dbaron!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6fb9bf18be66
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.