Closed Bug 1111220 Opened 9 years ago Closed 9 years ago

Remove system search integration

Categories

(Firefox for Android Graveyard :: General, defect)

35 Branch
All
Android
defect
Not set
normal

Tracking

(firefox39+ fixed, firefox40 fixed, firefox41 fixed, fennec39+)

RESOLVED FIXED
Firefox 41
Tracking Status
firefox39 + fixed
firefox40 --- fixed
firefox41 --- fixed
fennec 39+ ---

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

Attachments

(1 file, 1 obsolete file)

This was removed from Android in KitKat: Bug 966491 has some details.

That means we can kill SearchManager, some manifest entries, and then tidy up BrowserProvider, ultimately addressing Bug 926234.
Depends on: 1111221
Just a note: The original functionality was added in bug 786029. Looking at that patch should provide a roadmap for removing the feature.
This seems to have been partly done already, but I'm going to finish the job.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
This finishes the removal of Bug 786029.
Attachment #8626224 - Flags: review?(mark.finkle)
Comment on attachment 8626224 [details] [diff] [review]
Remove searchable features from Android manifest. v1

We also have a GLOBAL_SEARCH part in the file that was added at the same time:

http://hg.mozilla.org/mozilla-central/annotate/0b2f5e8b7be5/mobile/android/base/AndroidManifest.xml.in#l412
Attachment #8626224 - Flags: review?(mark.finkle)
Tracking for 39 from email discussion. This issue blocks the 39 mobile release.  

Are other versions affected?
Here's the second part if we need it.
Attachment #8626387 - Flags: review?(mark.finkle)
Attachment #8626387 - Flags: review?(mark.finkle) → review+
(In reply to Liz Henry (:lizzard) from comment #6)

> Are other versions affected?

All versions.
tracking-fennec: --- → 39+
Comment on attachment 8626224 [details] [diff] [review]
Remove searchable features from Android manifest. v1

https://hg.mozilla.org/releases/mozilla-release/rev/288f04c0b2b9 (a+ from Sylvestre on IRC for rapid build start)
Comment on attachment 8626387 [details] [diff] [review]
Additional searchability removal. v1

Punting this to Bug 1177723.
Attachment #8626387 - Attachment is obsolete: true
Comment on attachment 8626224 [details] [diff] [review]
Remove searchable features from Android manifest. v1

Already in release; let's fill in the gaps.
Attachment #8626224 - Flags: approval-mozilla-beta?
Attachment #8626224 - Flags: approval-mozilla-aurora?
Comment on attachment 8626224 [details] [diff] [review]
Remove searchable features from Android manifest. v1

There is no beta for now, but happy to take it in aurora. Thanks!
Attachment #8626224 - Flags: approval-mozilla-beta?
Attachment #8626224 - Flags: approval-mozilla-beta-
Attachment #8626224 - Flags: approval-mozilla-aurora?
Attachment #8626224 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/1f597787c8d0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Blocks: 1177723
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.