Closed
Bug 1111220
Opened 9 years ago
Closed 9 years ago
Remove system search integration
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox39+ fixed, firefox40 fixed, firefox41 fixed, fennec39+)
RESOLVED
FIXED
Firefox 41
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
Attachments
(1 file, 1 obsolete file)
2.30 KB,
patch
|
mfinkle
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta-
|
Details | Diff | Splinter Review |
This was removed from Android in KitKat: Bug 966491 has some details. That means we can kill SearchManager, some manifest entries, and then tidy up BrowserProvider, ultimately addressing Bug 926234.
Comment 1•9 years ago
|
||
Just a note: The original functionality was added in bug 786029. Looking at that patch should provide a roadmap for removing the feature.
Assignee | ||
Comment 2•9 years ago
|
||
This seems to have been partly done already, but I'm going to finish the job.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=410528d4d92b
Assignee | ||
Comment 4•9 years ago
|
||
This finishes the removal of Bug 786029.
Attachment #8626224 -
Flags: review?(mark.finkle)
Comment 5•9 years ago
|
||
Comment on attachment 8626224 [details] [diff] [review] Remove searchable features from Android manifest. v1 We also have a GLOBAL_SEARCH part in the file that was added at the same time: http://hg.mozilla.org/mozilla-central/annotate/0b2f5e8b7be5/mobile/android/base/AndroidManifest.xml.in#l412
Attachment #8626224 -
Flags: review?(mark.finkle)
Comment 6•9 years ago
|
||
Tracking for 39 from email discussion. This issue blocks the 39 mobile release. Are other versions affected?
status-firefox39:
--- → affected
tracking-firefox39:
--- → +
Assignee | ||
Comment 7•9 years ago
|
||
Here's the second part if we need it.
Attachment #8626387 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 8•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d2ec33be950
Updated•9 years ago
|
Attachment #8626387 -
Flags: review?(mark.finkle) → review+
Updated•9 years ago
|
Attachment #8626224 -
Flags: review+
Assignee | ||
Comment 9•9 years ago
|
||
(In reply to Liz Henry (:lizzard) from comment #6) > Are other versions affected? All versions.
Assignee | ||
Updated•9 years ago
|
tracking-fennec: --- → 39+
status-firefox40:
--- → affected
status-firefox41:
--- → affected
status-firefox42:
--- → affected
Comment 10•9 years ago
|
||
Comment on attachment 8626224 [details] [diff] [review] Remove searchable features from Android manifest. v1 https://hg.mozilla.org/releases/mozilla-release/rev/288f04c0b2b9 (a+ from Sylvestre on IRC for rapid build start)
Updated•9 years ago
|
Assignee | ||
Comment 12•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/1f597787c8d0
Assignee | ||
Comment 13•9 years ago
|
||
Comment on attachment 8626387 [details] [diff] [review] Additional searchability removal. v1 Punting this to Bug 1177723.
Attachment #8626387 -
Attachment is obsolete: true
Assignee | ||
Comment 14•9 years ago
|
||
Comment on attachment 8626224 [details] [diff] [review] Remove searchable features from Android manifest. v1 Already in release; let's fill in the gaps.
Attachment #8626224 -
Flags: approval-mozilla-beta?
Attachment #8626224 -
Flags: approval-mozilla-aurora?
Comment 15•9 years ago
|
||
Comment on attachment 8626224 [details] [diff] [review] Remove searchable features from Android manifest. v1 There is no beta for now, but happy to take it in aurora. Thanks!
Attachment #8626224 -
Flags: approval-mozilla-beta?
Attachment #8626224 -
Flags: approval-mozilla-beta-
Attachment #8626224 -
Flags: approval-mozilla-aurora?
Attachment #8626224 -
Flags: approval-mozilla-aurora+
Comment 16•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/d2826245bf84
status-firefox42:
affected → ---
Comment 17•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1f597787c8d0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•