Closed
Bug 1111416
Opened 10 years ago
Closed 10 years ago
[Stingray] tv build unable to copy web components in tv_shared
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: johnhu, Assigned: johnhu)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(1 file)
We only enable css and html coping for tv_shared. Since smart-system also requires web components created in smart-home. We need to extends it and move all components from smart-home to tv_shared.
|
Assignee | |
Updated•10 years ago
|
|
|
Assignee | |
Comment 1•10 years ago
|
||
Chens,
This patch tries to detect the usage of tv's web components and copy them to tv apps. Please review it.
Rex,
I had moved the components folder from smart-home to tv_shared. Please help me to check if I break anything. Thanks.
Attachment #8536337 -
Flags: review?(shchen)
Attachment #8536337 -
Flags: feedback?(rexboy)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8536337 [details] [review]
enable webcomponents support
Looks good to me
Attachment #8536337 -
Flags: review?(shchen) → review+
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8536337 [details] [review]
enable webcomponents support
Since it moves only smart-button and smart menu, it'd be good I think.
Attachment #8536337 -
Flags: feedback?(rexboy) → feedback+
|
|
Assignee | |
Comment 4•10 years ago
|
||
merged to master:
https://github.com/mozilla-b2g/gaia/commit/af3d2f89f391c92667e04676fc0ac971e6021bb7
gaia-try is all green.
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=ea7bc19f713b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•