1114399 - [Stingray][Home] settings button group isn't collapsed consistently while losting focus

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

settings button group is still opened while focus transferred to app launcher buttons.

STR:
1. focus settings button group
2. press down or right while gear is rotating. <== button group is not closed

actual:
  button group is not closed
expected:
  button group should be closed.

note: the reproduce ratio is not 100%.

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: check before moving on next state

The root cause of this issue is the "setTimeout" which is added to work around a gecko css issue. Because of this setTimeout, we may have a opening and closing running at the same time. The sequence of each state are:

Opening States:
closed -> closed + enlarging -> closed + shrinking -> opening -> ''(this is opened)

Closing State:
'' -> closing -> closed

We had use a setTimeout at `closed + shrinking` state. So, while state is in `closed + shrinking` without timeout executed, we call close on menu group. It will run `closing` and `opening` at the same time.

Dwi2,

The is the whole story. Please review the patch. Thanks.

Comment 3

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8539905 [details] [review]
check before moving on next state

Looks good to me, thanks

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/6bc8ea474196145bd6461e5fcf577eef3aa80f79
gaia-try is all green:
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=7fea87b896b4